From 4dd33779a07fcf7972873c239c1559f2b9552c8b Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Wed, 4 Oct 2017 01:04:55 +0000 Subject: [PATCH] sysvipc-unteach-ids-next_id-for-checkpoint_restore-checkpatch-fixes ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit 0123456789ab ("commit description")' #14: 03f595668017f ("ipc: add sysctl to specify desired next object id"). WARNING: macros should not use a trailing semicolon #75: FILE: ipc/util.c:224: +#define ipc_idr_alloc(ids, new) \ + idr_alloc(&(ids)->ipcs_idr, (new), \ + (ids)->next_id < 0 ? 0: ipcid_to_idx((ids)->next_id), \ + 0, GFP_NOWAIT); ERROR: spaces required around that ':' (ctx:VxW) #77: FILE: ipc/util.c:226: + (ids)->next_id < 0 ? 0: ipcid_to_idx((ids)->next_id), \ ^ WARNING: macros should not use a trailing semicolon #96: FILE: ipc/util.c:245: +#define ipc_idr_alloc(ids, new) \ + idr_alloc(&(ids)->ipcs_idr, (new), 0, 0, GFP_NOWAIT); total: 2 errors, 2 warnings, 117 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/sysvipc-unteach-ids-next_id-for-checkpoint_restore.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Davidlohr Bueso <dave@stgolabs.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- ipc/util.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ipc/util.c b/ipc/util.c index fb69152705e6f6..05dd6e177a8267 100644 --- a/ipc/util.c +++ b/ipc/util.c @@ -223,8 +223,8 @@ int ipc_get_maxid(struct ipc_ids *ids) */ #define ipc_idr_alloc(ids, new) \ idr_alloc(&(ids)->ipcs_idr, (new), \ - (ids)->next_id < 0 ? 0: ipcid_to_idx((ids)->next_id), \ - 0, GFP_NOWAIT); + (ids)->next_id < 0 ? 0 : ipcid_to_idx((ids)->next_id),\ + 0, GFP_NOWAIT) static inline int ipc_buildid(int id, struct ipc_ids *ids, struct kern_ipc_perm *new) @@ -243,7 +243,7 @@ static inline int ipc_buildid(int id, struct ipc_ids *ids, #else #define ipc_idr_alloc(ids, new) \ - idr_alloc(&(ids)->ipcs_idr, (new), 0, 0, GFP_NOWAIT); + idr_alloc(&(ids)->ipcs_idr, (new), 0, 0, GFP_NOWAIT) static inline int ipc_buildid(int id, struct ipc_ids *ids, struct kern_ipc_perm *new)