From 2e3fa7c851745047f18f23c016bbcb3ba0fd572e Mon Sep 17 00:00:00 2001
From: German Saracca <gersaracca@gmail.com>
Date: Mon, 1 Apr 2024 09:01:45 -0300
Subject: [PATCH 1/9] feature(plugin-react-hooks): Install package and
 configure

---
 .eslintrc.json    |  1 +
 package-lock.json | 13 +++++++++++++
 package.json      |  1 +
 3 files changed, 15 insertions(+)

diff --git a/.eslintrc.json b/.eslintrc.json
index dbdefa329..dfba7a0aa 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -18,6 +18,7 @@
   "extends": [
     "eslint:recommended",
     "plugin:react/recommended",
+    "plugin:react-hooks/recommended",
     "plugin:@typescript-eslint/eslint-recommended",
     "plugin:@typescript-eslint/recommended",
     "plugin:@typescript-eslint/recommended-requiring-type-checking",
diff --git a/package-lock.json b/package-lock.json
index 700647615..0d0adffef 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -79,6 +79,7 @@
         "eslint-plugin-import": "2.27.5",
         "eslint-plugin-prettier": "4.2.1",
         "eslint-plugin-react": "7.32.2",
+        "eslint-plugin-react-hooks": "4.6.0",
         "eslint-plugin-simple-import-sort": "10.0.0",
         "eslint-plugin-storybook": "0.6.11",
         "eslint-plugin-unused-imports": "2.0.0",
@@ -22276,6 +22277,18 @@
         "eslint": "^3 || ^4 || ^5 || ^6 || ^7 || ^8"
       }
     },
+    "node_modules/eslint-plugin-react-hooks": {
+      "version": "4.6.0",
+      "resolved": "https://registry.npmjs.org/eslint-plugin-react-hooks/-/eslint-plugin-react-hooks-4.6.0.tgz",
+      "integrity": "sha512-oFc7Itz9Qxh2x4gNHStv3BqJq54ExXmfC+a1NjAta66IAN87Wu0R/QArgIS9qKzX3dXKPI9H5crl9QchNMY9+g==",
+      "dev": true,
+      "engines": {
+        "node": ">=10"
+      },
+      "peerDependencies": {
+        "eslint": "^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0-0"
+      }
+    },
     "node_modules/eslint-plugin-react/node_modules/doctrine": {
       "version": "2.1.0",
       "resolved": "https://registry.npmjs.org/doctrine/-/doctrine-2.1.0.tgz",
diff --git a/package.json b/package.json
index d6cd25938..a3e152174 100644
--- a/package.json
+++ b/package.json
@@ -143,6 +143,7 @@
     "eslint-plugin-import": "2.27.5",
     "eslint-plugin-prettier": "4.2.1",
     "eslint-plugin-react": "7.32.2",
+    "eslint-plugin-react-hooks": "4.6.0",
     "eslint-plugin-simple-import-sort": "10.0.0",
     "eslint-plugin-storybook": "0.6.11",
     "eslint-plugin-unused-imports": "2.0.0",

From c76aafd177a05cd8ec5ee072cf51019be00ce955 Mon Sep 17 00:00:00 2001
From: German Saracca <gersaracca@gmail.com>
Date: Mon, 1 Apr 2024 10:29:02 -0300
Subject: [PATCH 2/9] fix(plugin-react-hooks): Fix errors from calling react
 hooks conditionally

---
 .../edit-dataset-menu/DeaccessionDatasetButton.tsx |  3 ++-
 .../edit-dataset-menu/DeleteDatasetButton.tsx      |  3 ++-
 .../edit-dataset-menu/EditDatasetMenu.tsx          |  5 +++--
 .../EditDatasetPermissionsMenu.tsx                 | 14 +++++++-------
 .../publish-dataset-menu/PublishDatasetMenu.tsx    |  5 +++--
 .../SubmitForReviewButton.tsx                      |  3 ++-
 6 files changed, 19 insertions(+), 14 deletions(-)

diff --git a/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/DeaccessionDatasetButton.tsx b/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/DeaccessionDatasetButton.tsx
index 18527ffb5..00f1e68f6 100644
--- a/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/DeaccessionDatasetButton.tsx
+++ b/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/DeaccessionDatasetButton.tsx
@@ -6,6 +6,8 @@ interface DeaccessionDatasetButtonProps {
   dataset: Dataset
 }
 export function DeaccessionDatasetButton({ dataset }: DeaccessionDatasetButtonProps) {
+  const { t } = useTranslation('dataset')
+
   if (
     !dataset.version.someDatasetVersionHasBeenReleased ||
     !dataset.permissions.canPublishDataset
@@ -13,7 +15,6 @@ export function DeaccessionDatasetButton({ dataset }: DeaccessionDatasetButtonPr
     return <></>
   }
 
-  const { t } = useTranslation('dataset')
   return (
     <>
       <DropdownSeparator />
diff --git a/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/DeleteDatasetButton.tsx b/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/DeleteDatasetButton.tsx
index 9a1eaf9f7..1e2b4a632 100644
--- a/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/DeleteDatasetButton.tsx
+++ b/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/DeleteDatasetButton.tsx
@@ -6,6 +6,8 @@ interface DeleteDatasetButtonProps {
   dataset: Dataset
 }
 export function DeleteDatasetButton({ dataset }: DeleteDatasetButtonProps) {
+  const { t } = useTranslation('dataset')
+
   if (
     !dataset.permissions.canDeleteDataset ||
     dataset.version.latestVersionPublishingStatus !== DatasetPublishingStatus.DRAFT
@@ -13,7 +15,6 @@ export function DeleteDatasetButton({ dataset }: DeleteDatasetButtonProps) {
     return <></>
   }
 
-  const { t } = useTranslation('dataset')
   return (
     <>
       <DropdownSeparator />
diff --git a/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetMenu.tsx b/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetMenu.tsx
index 03faf3cd1..3f3a9e09a 100644
--- a/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetMenu.tsx
+++ b/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetMenu.tsx
@@ -13,12 +13,13 @@ interface EditDatasetMenuProps {
 
 export function EditDatasetMenu({ dataset }: EditDatasetMenuProps) {
   const { user } = useSession()
+  const { showModal } = useNotImplementedModal()
+  const { t } = useTranslation('dataset')
 
   if (!user || !dataset.permissions.canUpdateDataset) {
     return <></>
   }
-  const { showModal } = useNotImplementedModal()
-  const { t } = useTranslation('dataset')
+
   return (
     <DropdownButton
       onSelect={showModal}
diff --git a/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetPermissionsMenu.tsx b/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetPermissionsMenu.tsx
index 7ef7f3282..5fccf6009 100644
--- a/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetPermissionsMenu.tsx
+++ b/src/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetPermissionsMenu.tsx
@@ -10,13 +10,6 @@ interface EditDatasetPermissionsMenuProps {
   dataset: Dataset
 }
 export function EditDatasetPermissionsMenu({ dataset }: EditDatasetPermissionsMenuProps) {
-  if (
-    !dataset.permissions.canManageDatasetPermissions &&
-    !dataset.permissions.canManageFilesPermissions
-  ) {
-    return <></>
-  }
-
   const { t } = useTranslation('dataset')
   const { getSettingByName } = useSettings()
   const [hasPublicStore, setHasPublicStore] = useState<HasPublicStore>(false)
@@ -31,6 +24,13 @@ export function EditDatasetPermissionsMenu({ dataset }: EditDatasetPermissionsMe
       })
   }, [getSettingByName])
 
+  if (
+    !dataset.permissions.canManageDatasetPermissions &&
+    !dataset.permissions.canManageFilesPermissions
+  ) {
+    return <></>
+  }
+
   if (hasPublicStore) {
     return (
       <DropdownButtonItem>
diff --git a/src/sections/dataset/dataset-action-buttons/publish-dataset-menu/PublishDatasetMenu.tsx b/src/sections/dataset/dataset-action-buttons/publish-dataset-menu/PublishDatasetMenu.tsx
index 6ea678467..b96fff849 100644
--- a/src/sections/dataset/dataset-action-buttons/publish-dataset-menu/PublishDatasetMenu.tsx
+++ b/src/sections/dataset/dataset-action-buttons/publish-dataset-menu/PublishDatasetMenu.tsx
@@ -11,6 +11,9 @@ interface PublishDatasetMenuProps {
 
 export function PublishDatasetMenu({ dataset }: PublishDatasetMenuProps) {
   const { user } = useSession()
+  const { t } = useTranslation('dataset')
+  const { showModal } = useNotImplementedModal()
+
   if (
     !dataset.version.isLatest ||
     dataset.version.publishingStatus !== DatasetPublishingStatus.DRAFT ||
@@ -20,12 +23,10 @@ export function PublishDatasetMenu({ dataset }: PublishDatasetMenuProps) {
     return <></>
   }
 
-  const { t } = useTranslation('dataset')
   const handleSelect = () => {
     // TODO - Implement upload files
     showModal()
   }
-  const { showModal } = useNotImplementedModal()
 
   return (
     <DropdownButton
diff --git a/src/sections/dataset/dataset-action-buttons/submit-for-review-button/SubmitForReviewButton.tsx b/src/sections/dataset/dataset-action-buttons/submit-for-review-button/SubmitForReviewButton.tsx
index b352b4065..c31c72ff1 100644
--- a/src/sections/dataset/dataset-action-buttons/submit-for-review-button/SubmitForReviewButton.tsx
+++ b/src/sections/dataset/dataset-action-buttons/submit-for-review-button/SubmitForReviewButton.tsx
@@ -9,6 +9,8 @@ interface SubmitForReviewButtonProps {
 
 export function SubmitForReviewButton({ dataset }: SubmitForReviewButtonProps) {
   const { user } = useSession()
+  const { t } = useTranslation('dataset')
+
   if (
     !dataset.version.isLatest ||
     dataset.version.publishingStatus !== DatasetPublishingStatus.DRAFT ||
@@ -20,7 +22,6 @@ export function SubmitForReviewButton({ dataset }: SubmitForReviewButtonProps) {
     return <></>
   }
 
-  const { t } = useTranslation('dataset')
   return (
     <Button
       variant="secondary"

From 113aeea297530fa507ecafb5b404d1e5185681cf Mon Sep 17 00:00:00 2001
From: German Saracca <gersaracca@gmail.com>
Date: Mon, 1 Apr 2024 10:52:13 -0300
Subject: [PATCH 3/9] fix(plugin-react-hooks): Avoid eslint check for stories
 of alerst

---
 src/stories/dataset/dataset-alerts/DatasetAlert.stories.tsx | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/stories/dataset/dataset-alerts/DatasetAlert.stories.tsx b/src/stories/dataset/dataset-alerts/DatasetAlert.stories.tsx
index 9f43ae771..32ee4b222 100644
--- a/src/stories/dataset/dataset-alerts/DatasetAlert.stories.tsx
+++ b/src/stories/dataset/dataset-alerts/DatasetAlert.stories.tsx
@@ -30,6 +30,7 @@ type Story = StoryObj<typeof DatasetAlerts>
 export const UpdateAlerts: Story = {
   render: () => {
     const dataset = DatasetMother.createRealistic()
+    // eslint-disable-next-line react-hooks/rules-of-hooks
     const { addDatasetAlert } = useAlertContext()
     allUpdateAlerts.forEach((alert) => addDatasetAlert(alert))
     return (
@@ -44,6 +45,7 @@ const publishAlert = new Alert('warning', AlertMessageKey.PUBLISH_IN_PROGRESS)
 export const PublishInProgress: Story = {
   render: () => {
     const dataset = DatasetMother.createRealistic()
+    // eslint-disable-next-line react-hooks/rules-of-hooks
     const { addDatasetAlert } = useAlertContext()
     addDatasetAlert(publishAlert)
     return (

From 92d9cc6b3ec3b6b851bcd9b2148e1517e98a531a Mon Sep 17 00:00:00 2001
From: German Saracca <gersaracca@gmail.com>
Date: Fri, 19 Apr 2024 16:12:16 -0300
Subject: [PATCH 4/9] refactor: setIsLoading missing dependencies

---
 src/sections/collection/datasets-list/DatasetsList.tsx          | 2 +-
 .../collection/datasets-list/DatasetsListWithInfiniteScroll.tsx | 2 +-
 src/sections/create-dataset/CreateDatasetForm.tsx               | 2 +-
 src/sections/dataset/Dataset.tsx                                | 2 +-
 src/sections/file/File.tsx                                      | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/sections/collection/datasets-list/DatasetsList.tsx b/src/sections/collection/datasets-list/DatasetsList.tsx
index cd44c661a..a72202af2 100644
--- a/src/sections/collection/datasets-list/DatasetsList.tsx
+++ b/src/sections/collection/datasets-list/DatasetsList.tsx
@@ -32,7 +32,7 @@ export function DatasetsList({ datasetRepository, page, collectionId }: Datasets
 
   useEffect(() => {
     setIsLoading(isLoading)
-  }, [isLoading])
+  }, [isLoading, setIsLoading])
 
   if (isLoading) {
     return <DatasetsListSkeleton />
diff --git a/src/sections/collection/datasets-list/DatasetsListWithInfiniteScroll.tsx b/src/sections/collection/datasets-list/DatasetsListWithInfiniteScroll.tsx
index dd962ddeb..d757ccbb4 100644
--- a/src/sections/collection/datasets-list/DatasetsListWithInfiniteScroll.tsx
+++ b/src/sections/collection/datasets-list/DatasetsListWithInfiniteScroll.tsx
@@ -52,7 +52,7 @@ export function DatasetsListWithInfiniteScroll({
 
   useEffect(() => {
     setIsLoading(isLoading)
-  }, [isLoading])
+  }, [isLoading, setIsLoading])
 
   useEffect(() => {
     const updatePaginationTotalItems = () => {
diff --git a/src/sections/create-dataset/CreateDatasetForm.tsx b/src/sections/create-dataset/CreateDatasetForm.tsx
index 15d292549..e3718b2f6 100644
--- a/src/sections/create-dataset/CreateDatasetForm.tsx
+++ b/src/sections/create-dataset/CreateDatasetForm.tsx
@@ -52,7 +52,7 @@ export function CreateDatasetForm({
 
   useEffect(() => {
     setIsLoading(false)
-  }, [isLoading])
+  }, [isLoading, setIsLoading])
 
   const disableSubmitButton = useMemo(() => {
     return (
diff --git a/src/sections/dataset/Dataset.tsx b/src/sections/dataset/Dataset.tsx
index 8acd6dd59..6cc83be9c 100644
--- a/src/sections/dataset/Dataset.tsx
+++ b/src/sections/dataset/Dataset.tsx
@@ -38,7 +38,7 @@ export function Dataset({ fileRepository, created }: DatasetProps) {
   }
   useEffect(() => {
     setIsLoading(isLoading)
-  }, [isLoading])
+  }, [isLoading, setIsLoading])
 
   if (isLoading) {
     return <DatasetSkeleton />
diff --git a/src/sections/file/File.tsx b/src/sections/file/File.tsx
index 019099a9e..25412213e 100644
--- a/src/sections/file/File.tsx
+++ b/src/sections/file/File.tsx
@@ -28,7 +28,7 @@ export function File({ repository, id, datasetVersionNumber }: FileProps) {
 
   useEffect(() => {
     setIsLoading(isLoading)
-  }, [isLoading])
+  }, [isLoading, setIsLoading])
 
   if (isLoading) {
     return <FileSkeleton />

From 39d38fee75b39261b1a33fa9af7f72a0863a327f Mon Sep 17 00:00:00 2001
From: German Saracca <gersaracca@gmail.com>
Date: Fri, 19 Apr 2024 17:02:13 -0300
Subject: [PATCH 5/9] refactor: fixing more warnings

---
 src/sections/create-dataset/useGetMetadataBlocksInfo.tsx       | 2 +-
 .../dataset-metadata-fields/DatasetMetadataFields.tsx          | 3 ++-
 src/sections/shared/pagination/PaginationResultsInfo.tsx       | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/sections/create-dataset/useGetMetadataBlocksInfo.tsx b/src/sections/create-dataset/useGetMetadataBlocksInfo.tsx
index 417a74a18..4422cc27a 100644
--- a/src/sections/create-dataset/useGetMetadataBlocksInfo.tsx
+++ b/src/sections/create-dataset/useGetMetadataBlocksInfo.tsx
@@ -62,7 +62,7 @@ export const useGetMetadataBlocksInfo = ({
       }
     }
     void handleGetDatasetMetadataBlockFields()
-  }, [])
+  }, [collectionId, metadataBlockInfoRepository, onCreateMode])
 
   return {
     metadataBlocks,
diff --git a/src/sections/dataset/dataset-metadata/dataset-metadata-fields/DatasetMetadataFields.tsx b/src/sections/dataset/dataset-metadata/dataset-metadata-fields/DatasetMetadataFields.tsx
index 8a6b74751..6ad5e35f0 100644
--- a/src/sections/dataset/dataset-metadata/dataset-metadata-fields/DatasetMetadataFields.tsx
+++ b/src/sections/dataset/dataset-metadata/dataset-metadata-fields/DatasetMetadataFields.tsx
@@ -17,7 +17,8 @@ export function DatasetMetadataFields({
 
   useEffect(() => {
     setMetadataBlockName(metadataBlockName)
-  }, [metadataBlockName])
+  }, [metadataBlockName, setMetadataBlockName])
+  console.log('PEPE')
 
   return (
     <>
diff --git a/src/sections/shared/pagination/PaginationResultsInfo.tsx b/src/sections/shared/pagination/PaginationResultsInfo.tsx
index a23e2ccd5..4ddb6ea7b 100644
--- a/src/sections/shared/pagination/PaginationResultsInfo.tsx
+++ b/src/sections/shared/pagination/PaginationResultsInfo.tsx
@@ -20,7 +20,7 @@ export function PaginationResultsInfo({ paginationInfo, accumulated }: Paginatio
         : accumulated < paginationInfo.pageSize
         ? 'accumulated.lessThanPageSize'
         : 'accumulated.moreThanPageSize',
-    [accumulated, paginationInfo.pageSize]
+    [paginationInfo.pageSize]
   )
 
   return (

From bff308a2aaf10dbba1318e0076e14fc76c08627a Mon Sep 17 00:00:00 2001
From: German Saracca <gersaracca@gmail.com>
Date: Mon, 22 Apr 2024 11:12:03 -0300
Subject: [PATCH 6/9] refactor: eslint hooks warnings reduced to 7

---
 src/sections/dataset/DatasetFactory.tsx       |  2 +-
 src/sections/dataset/DatasetProvider.tsx      |  9 +--
 .../dataset-files/files-table/FilesTable.tsx  |  6 +-
 .../files-table/useFilesTable.tsx             |  8 ++-
 .../ZipDownloadLimitMessage.tsx               |  2 +-
 .../dataset/dataset-files/useFiles.tsx        | 68 ++++++++++---------
 .../DatasetMetadataFields.tsx                 |  1 -
 7 files changed, 51 insertions(+), 45 deletions(-)

diff --git a/src/sections/dataset/DatasetFactory.tsx b/src/sections/dataset/DatasetFactory.tsx
index c80597b45..cafed8de4 100644
--- a/src/sections/dataset/DatasetFactory.tsx
+++ b/src/sections/dataset/DatasetFactory.tsx
@@ -54,7 +54,7 @@ function DatasetWithSearchParams() {
 
   useEffect(() => {
     if (privateUrlToken) setAnonymizedView(true)
-  }, [privateUrlToken])
+  }, [privateUrlToken, setAnonymizedView])
 
   if (privateUrlToken) {
     return (
diff --git a/src/sections/dataset/DatasetProvider.tsx b/src/sections/dataset/DatasetProvider.tsx
index 41ebd2504..e121485aa 100644
--- a/src/sections/dataset/DatasetProvider.tsx
+++ b/src/sections/dataset/DatasetProvider.tsx
@@ -1,4 +1,4 @@
-import { PropsWithChildren, useEffect, useState } from 'react'
+import { PropsWithChildren, useCallback, useEffect, useState } from 'react'
 import { DatasetContext } from './DatasetContext'
 import { DatasetRepository } from '../../dataset/domain/repositories/DatasetRepository'
 import { Dataset } from '../../dataset/domain/models/Dataset'
@@ -20,7 +20,8 @@ export function DatasetProvider({
 }: PropsWithChildren<DatasetProviderProps>) {
   const [dataset, setDataset] = useState<Dataset>()
   const [isLoading, setIsLoading] = useState(true)
-  const getDataset = () => {
+
+  const getDataset = useCallback(() => {
     if (searchParams.persistentId) {
       return getDatasetByPersistentId(repository, searchParams.persistentId, searchParams.version)
     }
@@ -28,7 +29,7 @@ export function DatasetProvider({
       return getDatasetByPrivateUrlToken(repository, searchParams.privateUrlToken)
     }
     return Promise.resolve(undefined)
-  }
+  }, [repository, searchParams])
 
   useEffect(() => {
     setIsLoading(true)
@@ -42,7 +43,7 @@ export function DatasetProvider({
         console.error('There was an error getting the dataset', error)
         setIsLoading(false)
       })
-  }, [repository, searchParams])
+  }, [repository, searchParams, getDataset])
 
   return (
     <DatasetContext.Provider value={{ dataset, isLoading }}>{children}</DatasetContext.Provider>
diff --git a/src/sections/dataset/dataset-files/files-table/FilesTable.tsx b/src/sections/dataset/dataset-files/files-table/FilesTable.tsx
index 8bf0b8874..aca03aa38 100644
--- a/src/sections/dataset/dataset-files/files-table/FilesTable.tsx
+++ b/src/sections/dataset/dataset-files/files-table/FilesTable.tsx
@@ -32,21 +32,21 @@ export function FilesTable({
   )
   const [visitedPagination, setVisitedPagination] = useState<FilePaginationInfo>(paginationInfo)
   const [visitedFiles, setVisitedFiles] = useState<FileSelection>({})
+  const [previousCriteria, setPreviousCriteria] = useState<FileCriteria>(criteria)
 
   useEffect(() => {
     if (visitedPagination.page == paginationInfo.page) {
       setVisitedFiles((visitedFiles) => ({ ...visitedFiles, ...fileSelection }))
     }
     setVisitedPagination(paginationInfo)
-  }, [fileSelection])
+  }, [fileSelection, paginationInfo, visitedPagination.page])
 
-  const [previousCriteria, setPreviousCriteria] = useState<FileCriteria>(criteria)
   useEffect(() => {
     if (previousCriteria != criteria) {
       clearFileSelection()
     }
     setPreviousCriteria(criteria)
-  })
+  }, [criteria, previousCriteria, clearFileSelection])
 
   if (isLoading) {
     return <SpinnerSymbol />
diff --git a/src/sections/dataset/dataset-files/files-table/useFilesTable.tsx b/src/sections/dataset/dataset-files/files-table/useFilesTable.tsx
index 1ffa88043..02e7be148 100644
--- a/src/sections/dataset/dataset-files/files-table/useFilesTable.tsx
+++ b/src/sections/dataset/dataset-files/files-table/useFilesTable.tsx
@@ -32,14 +32,16 @@ export function useFilesTable(files: FilePreview[], paginationInfo: FilePaginati
     pageCount: paginationInfo.totalPages
   })
 
+  const selectedRowsById = table.getSelectedRowModel().rowsById
+
   useEffect(() => {
     table.setPageSize(paginationInfo.pageSize)
     table.setPageIndex(paginationInfo.page - 1)
-  }, [paginationInfo])
+  }, [paginationInfo, table])
 
   useEffect(() => {
-    setCurrentPageSelectedRowModel(table.getSelectedRowModel().rowsById)
-  }, [table.getSelectedRowModel().rowsById])
+    setCurrentPageSelectedRowModel(selectedRowsById)
+  }, [selectedRowsById])
 
   return {
     table,
diff --git a/src/sections/dataset/dataset-files/files-table/zip-download-limit-message/ZipDownloadLimitMessage.tsx b/src/sections/dataset/dataset-files/files-table/zip-download-limit-message/ZipDownloadLimitMessage.tsx
index 47a39d1d9..32b7f55ef 100644
--- a/src/sections/dataset/dataset-files/files-table/zip-download-limit-message/ZipDownloadLimitMessage.tsx
+++ b/src/sections/dataset/dataset-files/files-table/zip-download-limit-message/ZipDownloadLimitMessage.tsx
@@ -41,7 +41,7 @@ export function ZipDownloadLimitMessage({
       filesTotalDownloadSize
     )
     setFileSelectionTotalSizeInInBytes(totalSize)
-  }, [fileSelection])
+  }, [fileSelection, visitedFiles, filesTotalDownloadSize])
 
   const showMessage =
     zipDownloadLimitInBytes &&
diff --git a/src/sections/dataset/dataset-files/useFiles.tsx b/src/sections/dataset/dataset-files/useFiles.tsx
index afd1fa222..be3b77cee 100644
--- a/src/sections/dataset/dataset-files/useFiles.tsx
+++ b/src/sections/dataset/dataset-files/useFiles.tsx
@@ -1,4 +1,4 @@
-import { useEffect, useState } from 'react'
+import { useCallback, useEffect, useState } from 'react'
 import { FileRepository } from '../../../files/domain/repositories/FileRepository'
 import { FilePreview } from '../../../files/domain/models/FilePreview'
 import { getFilesByDatasetPersistentId } from '../../../files/domain/useCases/getFilesByDatasetPersistentId'
@@ -21,7 +21,8 @@ export function useFiles(
   const [isLoading, setIsLoading] = useState<boolean>(true)
   const [filesCountInfo, setFilesCountInfo] = useState<FilesCountInfo>()
   const [filesTotalDownloadSize, setFilesTotalDownloadSize] = useState<number>(0)
-  const getFilesCountInfo = () => {
+
+  const getFilesCountInfo = useCallback(() => {
     return getFilesCountInfoByDatasetPersistentId(
       filesRepository,
       datasetPersistentId,
@@ -38,30 +39,40 @@ export function useFiles(
       .catch(() => {
         throw new Error('There was an error getting the files count info')
       })
-  }
+  }, [
+    criteria,
+    datasetPersistentId,
+    datasetVersion.number,
+    filesRepository,
+    onPaginationInfoChange,
+    paginationInfo
+  ])
 
-  const getFiles = (filesCount: FilesCountInfo) => {
-    if (filesCount) {
-      if (filesCount.total === 0) {
-        setIsLoading(false)
-        return
-      }
-      return getFilesByDatasetPersistentId(
-        filesRepository,
-        datasetPersistentId,
-        datasetVersion,
-        paginationInfo.withTotal(filesCount.total),
-        criteria
-      )
-        .then((files: FilePreview[]) => {
-          setFiles(files)
+  const getFiles = useCallback(
+    (filesCount: FilesCountInfo) => {
+      if (filesCount) {
+        if (filesCount.total === 0) {
           setIsLoading(false)
-        })
-        .catch(() => {
-          throw new Error('There was an error getting the files')
-        })
-    }
-  }
+          return
+        }
+        return getFilesByDatasetPersistentId(
+          filesRepository,
+          datasetPersistentId,
+          datasetVersion,
+          paginationInfo.withTotal(filesCount.total),
+          criteria
+        )
+          .then((files: FilePreview[]) => {
+            setFiles(files)
+            setIsLoading(false)
+          })
+          .catch(() => {
+            throw new Error('There was an error getting the files')
+          })
+      }
+    },
+    [criteria, datasetPersistentId, datasetVersion, filesRepository, paginationInfo]
+  )
 
   useEffect(() => {
     setIsLoading(true)
@@ -72,14 +83,7 @@ export function useFiles(
         console.error('There was an error getting the files')
         setIsLoading(false)
       })
-  }, [
-    filesRepository,
-    datasetPersistentId,
-    datasetVersion,
-    paginationInfo.page,
-    paginationInfo.pageSize,
-    criteria
-  ])
+  }, [getFiles, getFilesCountInfo])
 
   useEffect(() => {
     getFilesTotalDownloadSize(filesRepository, datasetPersistentId, datasetVersion.number, criteria)
diff --git a/src/sections/dataset/dataset-metadata/dataset-metadata-fields/DatasetMetadataFields.tsx b/src/sections/dataset/dataset-metadata/dataset-metadata-fields/DatasetMetadataFields.tsx
index 6ad5e35f0..5cd70e011 100644
--- a/src/sections/dataset/dataset-metadata/dataset-metadata-fields/DatasetMetadataFields.tsx
+++ b/src/sections/dataset/dataset-metadata/dataset-metadata-fields/DatasetMetadataFields.tsx
@@ -18,7 +18,6 @@ export function DatasetMetadataFields({
   useEffect(() => {
     setMetadataBlockName(metadataBlockName)
   }, [metadataBlockName, setMetadataBlockName])
-  console.log('PEPE')
 
   return (
     <>

From 3f7f468ce3ac14cf59a5884665cb31e2eec58053 Mon Sep 17 00:00:00 2001
From: German Saracca <gersaracca@gmail.com>
Date: Mon, 29 Apr 2024 08:36:43 -0300
Subject: [PATCH 7/9] refactor: reverte useFiles changes

---
 .../dataset/dataset-files/useFiles.tsx        | 68 +++++++++----------
 1 file changed, 32 insertions(+), 36 deletions(-)

diff --git a/src/sections/dataset/dataset-files/useFiles.tsx b/src/sections/dataset/dataset-files/useFiles.tsx
index be3b77cee..afd1fa222 100644
--- a/src/sections/dataset/dataset-files/useFiles.tsx
+++ b/src/sections/dataset/dataset-files/useFiles.tsx
@@ -1,4 +1,4 @@
-import { useCallback, useEffect, useState } from 'react'
+import { useEffect, useState } from 'react'
 import { FileRepository } from '../../../files/domain/repositories/FileRepository'
 import { FilePreview } from '../../../files/domain/models/FilePreview'
 import { getFilesByDatasetPersistentId } from '../../../files/domain/useCases/getFilesByDatasetPersistentId'
@@ -21,8 +21,7 @@ export function useFiles(
   const [isLoading, setIsLoading] = useState<boolean>(true)
   const [filesCountInfo, setFilesCountInfo] = useState<FilesCountInfo>()
   const [filesTotalDownloadSize, setFilesTotalDownloadSize] = useState<number>(0)
-
-  const getFilesCountInfo = useCallback(() => {
+  const getFilesCountInfo = () => {
     return getFilesCountInfoByDatasetPersistentId(
       filesRepository,
       datasetPersistentId,
@@ -39,40 +38,30 @@ export function useFiles(
       .catch(() => {
         throw new Error('There was an error getting the files count info')
       })
-  }, [
-    criteria,
-    datasetPersistentId,
-    datasetVersion.number,
-    filesRepository,
-    onPaginationInfoChange,
-    paginationInfo
-  ])
+  }
 
-  const getFiles = useCallback(
-    (filesCount: FilesCountInfo) => {
-      if (filesCount) {
-        if (filesCount.total === 0) {
-          setIsLoading(false)
-          return
-        }
-        return getFilesByDatasetPersistentId(
-          filesRepository,
-          datasetPersistentId,
-          datasetVersion,
-          paginationInfo.withTotal(filesCount.total),
-          criteria
-        )
-          .then((files: FilePreview[]) => {
-            setFiles(files)
-            setIsLoading(false)
-          })
-          .catch(() => {
-            throw new Error('There was an error getting the files')
-          })
+  const getFiles = (filesCount: FilesCountInfo) => {
+    if (filesCount) {
+      if (filesCount.total === 0) {
+        setIsLoading(false)
+        return
       }
-    },
-    [criteria, datasetPersistentId, datasetVersion, filesRepository, paginationInfo]
-  )
+      return getFilesByDatasetPersistentId(
+        filesRepository,
+        datasetPersistentId,
+        datasetVersion,
+        paginationInfo.withTotal(filesCount.total),
+        criteria
+      )
+        .then((files: FilePreview[]) => {
+          setFiles(files)
+          setIsLoading(false)
+        })
+        .catch(() => {
+          throw new Error('There was an error getting the files')
+        })
+    }
+  }
 
   useEffect(() => {
     setIsLoading(true)
@@ -83,7 +72,14 @@ export function useFiles(
         console.error('There was an error getting the files')
         setIsLoading(false)
       })
-  }, [getFiles, getFilesCountInfo])
+  }, [
+    filesRepository,
+    datasetPersistentId,
+    datasetVersion,
+    paginationInfo.page,
+    paginationInfo.pageSize,
+    criteria
+  ])
 
   useEffect(() => {
     getFilesTotalDownloadSize(filesRepository, datasetPersistentId, datasetVersion.number, criteria)

From 352c0005febfa2648c7108bee7f9ab95a44b07ac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Germ=C3=A1n=20Saracca?= <gersaracca@gmail.com>
Date: Fri, 17 May 2024 10:32:22 -0300
Subject: [PATCH 8/9] chore: fix formatting issues

---
 public/locales/en/pagination.json                               | 2 +-
 .../sections/shared/pagination/PaginationResultsInfo.spec.tsx   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/public/locales/en/pagination.json b/public/locales/en/pagination.json
index 672595da0..ae19aa386 100644
--- a/public/locales/en/pagination.json
+++ b/public/locales/en/pagination.json
@@ -7,4 +7,4 @@
     "moreThanPageSize": "{{accumulated}} of {{formattedCount}} {{item}}s seen"
   },
   "pageSize": "{{item}}s per page"
-}
\ No newline at end of file
+}
diff --git a/tests/component/sections/shared/pagination/PaginationResultsInfo.spec.tsx b/tests/component/sections/shared/pagination/PaginationResultsInfo.spec.tsx
index a35b8bd3b..699397683 100644
--- a/tests/component/sections/shared/pagination/PaginationResultsInfo.spec.tsx
+++ b/tests/component/sections/shared/pagination/PaginationResultsInfo.spec.tsx
@@ -66,4 +66,4 @@ describe('PaginationResultsInfo', () => {
     )
     cy.findByText(`500 of ${expectedFormattedTotalCount} Items seen`).should('exist')
   })
-})
\ No newline at end of file
+})

From fafc7a69d592338b9566f67d3611e175ce010de1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Germ=C3=A1n=20Saracca?= <gersaracca@gmail.com>
Date: Mon, 20 May 2024 16:59:53 -0300
Subject: [PATCH 9/9] fix: remove old dependency

---
 src/sections/create-dataset/useGetMetadataBlocksInfo.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sections/create-dataset/useGetMetadataBlocksInfo.tsx b/src/sections/create-dataset/useGetMetadataBlocksInfo.tsx
index 17b6acc31..4ee7eab4f 100644
--- a/src/sections/create-dataset/useGetMetadataBlocksInfo.tsx
+++ b/src/sections/create-dataset/useGetMetadataBlocksInfo.tsx
@@ -49,7 +49,7 @@ export const useGetMetadataBlocksInfo = ({
       }
     }
     void handleGetDatasetMetadataBlockFields()
-  }, [collectionId, metadataBlockInfoRepository, onCreateMode])
+  }, [collectionId, metadataBlockInfoRepository])
 
   return {
     metadataBlocks,