From e112d4991f22d26e4e2361c0a7c2ce914c9197c3 Mon Sep 17 00:00:00 2001 From: Yi Tao Date: Wed, 17 May 2023 18:23:10 +0800 Subject: [PATCH] add CHANGELOG --- CHANGELOG.md | 5 +++++ test/integration/translation_failures_test.go | 7 ++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index af5e2b843f..1372851552 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -114,6 +114,11 @@ Adding a new version? You'll need three changes: during the start-up phase. From now on, they will be dynamically started in runtime once their installation is detected, making restarting the process unnecessary. [#3996](https://github.com/Kong/kubernetes-ingress-controller/pull/3996) +- Disable translation of unspported kubernetes objects when translating to + expression based routes is enabled (`ExpressionRoutes` feature enabled AND + kong using router flavor `expressions`), and generate a translation failure + event attached to each of the unsupported objects. + [#4022](https://github.com/Kong/kubernetes-ingress-controller/pull/4022) ### Changed diff --git a/test/integration/translation_failures_test.go b/test/integration/translation_failures_test.go index 359d39ecd9..351754d0b4 100644 --- a/test/integration/translation_failures_test.go +++ b/test/integration/translation_failures_test.go @@ -516,8 +516,10 @@ func TestTranslationFailuresUnsupportedObjectsWithExpressionRoutes(t *testing.T) c, err := client.New(env.Cluster().Config(), client.Options{}) require.NoError(t, err) - gatewayv1alpha2.AddToScheme(c.Scheme()) - kongv1beta1.AddToScheme(c.Scheme()) + err = gatewayv1alpha2.AddToScheme(c.Scheme()) + require.NoError(t, err) + err = kongv1beta1.AddToScheme(c.Scheme()) + require.NoError(t, err) for _, tc := range testCases { tc := tc @@ -572,7 +574,6 @@ func TestTranslationFailuresUnsupportedObjectsWithExpressionRoutes(t *testing.T) return false }, time.Minute, time.Second) - }) } }