From 20d8f0c1cc29878b5feab8d8801ada207a307797 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mewen=20Le=20H=C3=B4?= <92363071+MewenLeHo@users.noreply.github.com> Date: Fri, 30 Dec 2022 13:14:59 +0100 Subject: [PATCH] feat(accordion): add padding to accordion content (#1727) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: louismaxime.piton Co-authored-by: Julien Déramond --- scss/_accordion.scss | 8 +++++--- scss/_variables.scss | 10 ++++++++-- site/content/docs/5.2/migration.md | 12 ++++++++++++ 3 files changed, 25 insertions(+), 5 deletions(-) diff --git a/scss/_accordion.scss b/scss/_accordion.scss index ec547575cb..7fe3dce003 100644 --- a/scss/_accordion.scss +++ b/scss/_accordion.scss @@ -26,8 +26,10 @@ // Boosted mod: no --#{$prefix}accordion-btn-active-icon // Boosted mod: no --#{$prefix}accordion-btn-focus-border-color // Boosted mod: no --#{$prefix}accordion-btn-focus-box-shadow - --#{$prefix}accordion-body-padding-x: #{$accordion-body-padding-x}; - --#{$prefix}accordion-body-padding-y: #{$accordion-body-padding-y}; + --#{$prefix}accordion-body-padding-top: #{$accordion-body-padding-top}; // Boosted mod + --#{$prefix}accordion-body-padding-end: #{$accordion-body-padding-end}; // Boosted mod + --#{$prefix}accordion-body-padding-bottom: #{$accordion-body-padding-bottom}; // Boosted mod + --#{$prefix}accordion-body-padding-start: #{$accordion-body-padding-start}; // Boosted mod --#{$prefix}accordion-active-color: #{$accordion-button-active-color}; --#{$prefix}accordion-active-bg: #{$accordion-button-active-bg}; // scss-docs-end accordion-css-vars @@ -123,7 +125,7 @@ } .accordion-body { - padding: 0 var(--#{$prefix}accordion-body-padding-x) var(--#{$prefix}accordion-body-padding-y) 0; // Boosted mod + padding: var(--#{$prefix}accordion-body-padding-top) var(--#{$prefix}accordion-body-padding-end) var(--#{$prefix}accordion-body-padding-bottom) var(--#{$prefix}accordion-body-padding-start); // Boosted mod } // Boosted mod: no Flush accordion items diff --git a/scss/_variables.scss b/scss/_variables.scss index e7592c4685..bcac2f9f3a 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -1563,8 +1563,14 @@ $accordion-border-color: $gray-500 !default; // Boosted mod $accordion-border-radius: $border-radius !default; $accordion-inner-border-radius: subtract($accordion-border-radius, #{$accordion-border-width}) !default; -$accordion-body-padding-y: $spacer !default; // Boosted mod -$accordion-body-padding-x: $spacer !default; // Boosted mod +$accordion-body-padding-top: 5px !default; // Boosted mod +$accordion-body-padding-end: $spacer !default; // Boosted mod +$accordion-body-padding-bottom: $spacer !default; // Boosted mod +$accordion-body-padding-start: 0 !default; // Boosted mod +// fusv-disable +$accordion-body-padding-y: $spacer !default; // Deprecated in Boosted 5.2.3 to divide it in -padding +$accordion-body-padding-x: $spacer !default; // Deprecated in Boosted 5.2.3 to divide it in -padding +// fusv-enable $accordion-button-padding-y: $accordion-padding-y !default; $accordion-button-padding-x: $accordion-padding-x !default; diff --git a/site/content/docs/5.2/migration.md b/site/content/docs/5.2/migration.md index e792a2bdcf..3fd495a770 100644 --- a/site/content/docs/5.2/migration.md +++ b/site/content/docs/5.2/migration.md @@ -135,6 +135,8 @@ If you need more details about the changes, please refer to the [v5.2.3 release] -
Breaking Deprecated CSS variables:
    +
  • --bs-accordion-body-padding-x
  • +
  • --bs-accordion-body-padding-y
  • --bs-dropdown-toggle-bg
  • --bs-dropdown-toggle-border-color
  • --bs-dropdown-toggle-color
  • @@ -147,6 +149,10 @@ If you need more details about the changes, please refer to the [v5.2.3 release] -
    New CSS variables:
      +
    • --bs-accordion-body-padding-bottom
    • +
    • --bs-accordion-body-padding-end
    • +
    • --bs-accordion-body-padding-start
    • +
    • --bs-accordion-body-padding-top
    • --bs-dropdown-line-height
    • --bs-focus-visible-inner-color
    • --bs-focus-visible-outer-color
    • @@ -161,6 +167,8 @@ If you need more details about the changes, please refer to the [v5.2.3 release] -
      Breaking Deprecated Sass variables:
        +
      • $accordion-body-padding-x
      • +
      • $accordion-body-padding-y
      • $btn-close-focus-shadow
      • $form-range-thumb-active-border
      • $form-star-focus-box-shadow
      • @@ -176,6 +184,10 @@ If you need more details about the changes, please refer to the [v5.2.3 release] -
        New Sass variables:
          +
        • $accordion-body-padding-bottom
        • +
        • $accordion-body-padding-end
        • +
        • $accordion-body-padding-start
        • +
        • $accordion-body-padding-top
        • $focus-visible-inner-color
        • $focus-visible-inner-color-dark
        • $focus-visible-inner-width