diff --git a/vendor.mod b/vendor.mod index d0f7ef4815083..da466f072eeca 100644 --- a/vendor.mod +++ b/vendor.mod @@ -98,7 +98,7 @@ require ( resenje.org/singleflight v0.3.0 ) -replace github.com/moby/buildkit => github.com/dcermak/buildkit v0.0.0-20240212085728-98616a35568e +replace github.com/moby/buildkit => github.com/cyphar/buildkit v0.0.0-20240506154547-88b38858b334 require ( cloud.google.com/go v0.102.1 // indirect diff --git a/vendor.sum b/vendor.sum index 8abac7df84e12..282537e6f889a 100644 --- a/vendor.sum +++ b/vendor.sum @@ -446,6 +446,8 @@ github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ3 github.com/creack/pty v1.1.11/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E= github.com/creack/pty v1.1.18 h1:n56/Zwd5o6whRC5PMGretI4IdRLlmBXYNjScPaBgsbY= github.com/creack/pty v1.1.18/go.mod h1:MOBLtS5ELjhRRrroQr9kyvTxUAFNvYEK993ew/Vr4O4= +github.com/cyphar/buildkit v0.0.0-20240506154547-88b38858b334 h1:iyTSK8R6bhXJzEAusap2te9JHDCJXq7wUFOpn6iydF8= +github.com/cyphar/buildkit v0.0.0-20240506154547-88b38858b334/go.mod h1:bMQDryngJKGvJ/ZuRFhrejurbvYSv3NkGCheQ59X4AM= github.com/cyphar/filepath-securejoin v0.2.2/go.mod h1:FpkQEhXnPnOthhzymB7CGsFk2G9VLXONKD9G7QGMM+4= github.com/cyphar/filepath-securejoin v0.2.3 h1:YX6ebbZCZP7VkM3scTTokDgBL2TY741X51MTk3ycuNI= github.com/cyphar/filepath-securejoin v0.2.3/go.mod h1:aPGpWjXOXUn2NCNjFvBE6aRxGGx79pTxQpKOJNYHHl4= @@ -458,8 +460,6 @@ github.com/danieljoos/wincred v1.1.2/go.mod h1:GijpziifJoIBfYh+S7BbkdUTU4LfM+QnG github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= -github.com/dcermak/buildkit v0.0.0-20240212085728-98616a35568e h1:7PFscyViZvzxx/vKuNCcx8tpu1cttYaxsSK/Z60v0Jw= -github.com/dcermak/buildkit v0.0.0-20240212085728-98616a35568e/go.mod h1:bMQDryngJKGvJ/ZuRFhrejurbvYSv3NkGCheQ59X4AM= github.com/deckarep/golang-set/v2 v2.3.0 h1:qs18EKUfHm2X9fA50Mr/M5hccg2tNnVqsiBImnyDs0g= github.com/deckarep/golang-set/v2 v2.3.0/go.mod h1:VAky9rY/yGXJOLEDv3OMci+7wtDpOF4IN+y82NBOac4= github.com/denverdino/aliyungo v0.0.0-20190125010748-a747050bb1ba/go.mod h1:dV8lFg6daOBZbT6/BDGIz6Y3WFGn8juu6G+CQ6LHtl0= diff --git a/vendor/github.com/moby/buildkit/cache/contenthash/checksum.go b/vendor/github.com/moby/buildkit/cache/contenthash/checksum.go index dcf424a6b4fcb..aba3a52e3c7b7 100644 --- a/vendor/github.com/moby/buildkit/cache/contenthash/checksum.go +++ b/vendor/github.com/moby/buildkit/cache/contenthash/checksum.go @@ -405,7 +405,7 @@ func (cc *cacheContext) Checksum(ctx context.Context, mountable cache.Mountable, defer m.clean() if !opts.Wildcard && len(opts.IncludePatterns) == 0 && len(opts.ExcludePatterns) == 0 { - return cc.checksumFollow(ctx, m, p, opts.FollowLinks) + return cc.lazyChecksum(ctx, m, p, opts.FollowLinks) } includedPaths, err := cc.includedPaths(ctx, m, p, opts) @@ -416,7 +416,7 @@ func (cc *cacheContext) Checksum(ctx context.Context, mountable cache.Mountable, if opts.FollowLinks { for i, w := range includedPaths { if w.record.Type == CacheRecordTypeSymlink { - dgst, err := cc.checksumFollow(ctx, m, w.path, opts.FollowLinks) + dgst, err := cc.lazyChecksum(ctx, m, w.path, opts.FollowLinks) if err != nil { return "", err } @@ -443,30 +443,6 @@ func (cc *cacheContext) Checksum(ctx context.Context, mountable cache.Mountable, return digester.Digest(), nil } -func (cc *cacheContext) checksumFollow(ctx context.Context, m *mount, p string, follow bool) (digest.Digest, error) { - const maxSymlinkLimit = 255 - i := 0 - for { - if i > maxSymlinkLimit { - return "", errors.Errorf("too many symlinks: %s", p) - } - cr, err := cc.checksumNoFollow(ctx, m, p) - if err != nil { - return "", err - } - if cr.Type == CacheRecordTypeSymlink && follow { - link := cr.Linkname - if !path.IsAbs(cr.Linkname) { - link = path.Join(path.Dir(p), link) - } - i++ - p = link - } else { - return cr.Digest, nil - } - } -} - func (cc *cacheContext) includedPaths(ctx context.Context, m *mount, p string, opts ChecksumOpts) ([]*includedPath, error) { cc.mu.Lock() defer cc.mu.Unlock() @@ -476,12 +452,12 @@ func (cc *cacheContext) includedPaths(ctx context.Context, m *mount, p string, o } root := cc.tree.Root() - scan, err := cc.needsScan(root, "") + scan, err := cc.needsScan(root, "", false) if err != nil { return nil, err } if scan { - if err := cc.scanPath(ctx, m, ""); err != nil { + if err := cc.scanPath(ctx, m, "", false); err != nil { return nil, err } } @@ -540,7 +516,7 @@ func (cc *cacheContext) includedPaths(ctx context.Context, m *mount, p string, o // involves a symlink. That will match fsutil behavior of // calling functions such as stat and walk. var cr *CacheRecord - k, cr, err = getFollowLinks(root, k, true) + k, cr, err = getFollowLinks(root, k, false) if err != nil { return nil, err } @@ -749,36 +725,12 @@ func wildcardPrefix(root *iradix.Node, p string) (string, []byte, bool, error) { return "", nil, false, nil } - linksWalked := 0 - k, cr, err := getFollowLinksWalk(root, convertPathToKey([]byte(d1)), true, &linksWalked) + // Only resolve the final symlink component if there are components in the + // wildcard segment. + k, cr, err := getFollowLinks(root, convertPathToKey([]byte(d1)), d2 != "") if err != nil { return "", k, false, err } - - if d2 != "" && cr != nil && cr.Type == CacheRecordTypeSymlink { - // getFollowLinks only handles symlinks in path - // components before the last component, so - // handle last component in d1 specially. - resolved := string(convertKeyToPath(k)) - for { - v, ok := root.Get(k) - - if !ok { - return d1, k, false, nil - } - if v.(*CacheRecord).Type != CacheRecordTypeSymlink { - break - } - - linksWalked++ - if linksWalked > 255 { - return "", k, false, errors.Errorf("too many links") - } - - resolved := cleanLink(resolved, v.(*CacheRecord).Linkname) - k = convertPathToKey([]byte(resolved)) - } - } return d1, k, cr != nil, nil } @@ -814,19 +766,22 @@ func containsWildcards(name string) bool { return false } -func (cc *cacheContext) checksumNoFollow(ctx context.Context, m *mount, p string) (*CacheRecord, error) { +func (cc *cacheContext) lazyChecksum(ctx context.Context, m *mount, p string, followTrailing bool) (digest.Digest, error) { p = keyPath(p) + k := convertPathToKey([]byte(p)) + // Try to look up the path directly without doing a scan. cc.mu.RLock() if cc.txn == nil { root := cc.tree.Root() cc.mu.RUnlock() - v, ok := root.Get(convertPathToKey([]byte(p))) - if ok { - cr := v.(*CacheRecord) - if cr.Digest != "" { - return cr, nil - } + + _, cr, err := getFollowLinks(root, k, followTrailing) + if err != nil { + return "", err + } + if cr != nil && cr.Digest != "" { + return cr.Digest, nil } } else { cc.mu.RUnlock() @@ -846,7 +801,11 @@ func (cc *cacheContext) checksumNoFollow(ctx context.Context, m *mount, p string } }() - return cc.lazyChecksum(ctx, m, p) + cr, err := cc.scanChecksum(ctx, m, p, followTrailing) + if err != nil { + return "", err + } + return cr.Digest, nil } func (cc *cacheContext) commitActiveTransaction() { @@ -865,21 +824,21 @@ func (cc *cacheContext) commitActiveTransaction() { cc.txn = nil } -func (cc *cacheContext) lazyChecksum(ctx context.Context, m *mount, p string) (*CacheRecord, error) { +func (cc *cacheContext) scanChecksum(ctx context.Context, m *mount, p string, followTrailing bool) (*CacheRecord, error) { root := cc.tree.Root() - scan, err := cc.needsScan(root, p) + scan, err := cc.needsScan(root, p, followTrailing) if err != nil { return nil, err } if scan { - if err := cc.scanPath(ctx, m, p); err != nil { + if err := cc.scanPath(ctx, m, p, followTrailing); err != nil { return nil, err } } k := convertPathToKey([]byte(p)) txn := cc.tree.Txn() root = txn.Root() - cr, updated, err := cc.checksum(ctx, root, txn, m, k, true) + cr, updated, err := cc.checksum(ctx, root, txn, m, k, followTrailing) if err != nil { return nil, err } @@ -888,9 +847,9 @@ func (cc *cacheContext) lazyChecksum(ctx context.Context, m *mount, p string) (* return cr, err } -func (cc *cacheContext) checksum(ctx context.Context, root *iradix.Node, txn *iradix.Txn, m *mount, k []byte, follow bool) (*CacheRecord, bool, error) { +func (cc *cacheContext) checksum(ctx context.Context, root *iradix.Node, txn *iradix.Txn, m *mount, k []byte, followTrailing bool) (*CacheRecord, bool, error) { origk := k - k, cr, err := getFollowLinks(root, k, follow) + k, cr, err := getFollowLinks(root, k, followTrailing) if err != nil { return nil, false, err } @@ -916,7 +875,9 @@ func (cc *cacheContext) checksum(ctx context.Context, root *iradix.Node, txn *ir } h.Write(bytes.TrimPrefix(subk, k)) - subcr, _, err := cc.checksum(ctx, root, txn, m, subk, true) + // We do not follow trailing links when checksumming a directory's + // contents. + subcr, _, err := cc.checksum(ctx, root, txn, m, subk, false) if err != nil { return nil, false, err } @@ -966,41 +927,41 @@ func (cc *cacheContext) checksum(ctx context.Context, root *iradix.Node, txn *ir } // needsScan returns false if path is in the tree or a parent path is in tree -// and subpath is missing -func (cc *cacheContext) needsScan(root *iradix.Node, p string) (bool, error) { - var linksWalked int - return cc.needsScanFollow(root, p, &linksWalked) -} - -func (cc *cacheContext) needsScanFollow(root *iradix.Node, p string, linksWalked *int) (bool, error) { - if p == "/" { - p = "" - } - v, ok := root.Get(convertPathToKey([]byte(p))) - if !ok { - if p == "" { - return true, nil - } - return cc.needsScanFollow(root, path.Clean(path.Dir(p)), linksWalked) - } - cr := v.(*CacheRecord) - if cr.Type == CacheRecordTypeSymlink { - if *linksWalked > 255 { - return false, errTooManyLinks - } - *linksWalked++ - link := path.Clean(cr.Linkname) - if !path.IsAbs(cr.Linkname) { - link = path.Join("/", path.Dir(p), link) +// and subpath is missing. +func (cc *cacheContext) needsScan(root *iradix.Node, path string, followTrailing bool) (bool, error) { + var ( + lastGoodPath string + hasParentInTree bool + ) + k := convertPathToKey([]byte(path)) + _, cr, err := getFollowLinksCallback(root, k, followTrailing, func(subpath string, cr *CacheRecord) error { + if cr != nil { + // If the path is not a symlink, then for now we have a parent in + // the tree. Otherwise, we reset hasParentInTree because we + // might've jumped to a part of the tree that hasn't been scanned. + hasParentInTree = (cr.Type != CacheRecordTypeSymlink) + if hasParentInTree { + lastGoodPath = subpath + } + } else if hasParentInTree { + // If the current component was something like ".." and the subpath + // couldn't be found, then we need to invalidate hasParentInTree. + // In practice this means that our subpath needs to be prefixed by + // the last good path. We add a trailing slash to make sure the + // prefix is a proper lexical prefix (as opposed to /a/b being seen + // as a prefix of /a/bc). + hasParentInTree = strings.HasPrefix(subpath+"/", lastGoodPath+"/") } - return cc.needsScanFollow(root, link, linksWalked) + return nil + }) + if err != nil { + return false, err } - return false, nil + return cr == nil && !hasParentInTree, nil } -func (cc *cacheContext) scanPath(ctx context.Context, m *mount, p string) (retErr error) { +func (cc *cacheContext) scanPath(ctx context.Context, m *mount, p string, followTrailing bool) (retErr error) { p = path.Join("/", p) - d, _ := path.Split(p) mp, err := m.mount(ctx) if err != nil { @@ -1010,7 +971,7 @@ func (cc *cacheContext) scanPath(ctx context.Context, m *mount, p string) (retEr n := cc.tree.Root() txn := cc.tree.Txn() - parentPath, err := rootPath(mp, filepath.FromSlash(d), func(p, link string) error { + resolvedPath, err := rootPath(mp, filepath.FromSlash(p), followTrailing, func(p, link string) error { cr := &CacheRecord{ Type: CacheRecordTypeSymlink, Linkname: filepath.ToSlash(link), @@ -1024,8 +985,19 @@ func (cc *cacheContext) scanPath(ctx context.Context, m *mount, p string) (retEr return err } - err = filepath.Walk(parentPath, func(itemPath string, fi os.FileInfo, err error) error { + // Scan the parent directory of the path we resolved, unless we're at the + // root (in which case we scan the root). + scanPath := filepath.Dir(resolvedPath) + if !strings.HasPrefix(filepath.ToSlash(scanPath)+"/", filepath.ToSlash(mp)+"/") { + scanPath = resolvedPath + } + + err = filepath.Walk(scanPath, func(itemPath string, fi os.FileInfo, err error) error { if err != nil { + // If the root doesn't exist, ignore the error. + if errors.Is(err, os.ErrNotExist) { + return nil + } return errors.Wrapf(err, "failed to walk %s", itemPath) } rel, err := filepath.Rel(mp, itemPath) @@ -1069,55 +1041,103 @@ func (cc *cacheContext) scanPath(ctx context.Context, m *mount, p string) (retEr return nil } -func getFollowLinks(root *iradix.Node, k []byte, follow bool) ([]byte, *CacheRecord, error) { - var linksWalked int - return getFollowLinksWalk(root, k, follow, &linksWalked) +// followLinksCallback is called after we try to resolve each element. If the +// path was not found, cr is nil. +type followLinksCallback func(path string, cr *CacheRecord) error + +// getFollowLinks looks up the requested key, fully resolving any symlink +// components encountered. +// +// followTrailing indicates whether the *final component* of the path should be +// resolved (effectively O_PATH|O_NOFOLLOW). Note that (in contrast to some +// Linux APIs), followTrailing is obeyed even if the key has a trailing slash +// (though paths like "foo/link/." will cause the link to be resolved). +func getFollowLinks(root *iradix.Node, k []byte, followTrailing bool) ([]byte, *CacheRecord, error) { + return getFollowLinksCallback(root, k, followTrailing, nil) } -func getFollowLinksWalk(root *iradix.Node, k []byte, follow bool, linksWalked *int) ([]byte, *CacheRecord, error) { +func getFollowLinksCallback(root *iradix.Node, k []byte, followTrailing bool, cb followLinksCallback) ([]byte, *CacheRecord, error) { v, ok := root.Get(k) - if ok { + if ok && (!followTrailing || v.(*CacheRecord).Type != CacheRecordTypeSymlink) { return k, v.(*CacheRecord), nil } - if !follow || len(k) == 0 { + if len(k) == 0 { return k, nil, nil } - dir, file := splitKey(k) + var ( + currentPath = "/" + remainingPath = string(convertKeyToPath(k)) + linksWalked int + cr *CacheRecord + ) + // Trailing slashes are significant for the cache, but path.Clean strips + // them. We only care about the slash for the final lookup. + remainingPath, hadTrailingSlash := strings.CutSuffix(remainingPath, "/") + for remainingPath != "" { + // Get next component. + var part string + if i := strings.IndexRune(remainingPath, '/'); i == -1 { + part, remainingPath = remainingPath, "" + } else { + part, remainingPath = remainingPath[:i], remainingPath[i+1:] + } - k, parent, err := getFollowLinksWalk(root, dir, follow, linksWalked) - if err != nil { - return nil, nil, err - } - if parent != nil { - if parent.Type == CacheRecordTypeSymlink { - *linksWalked++ - if *linksWalked > 255 { - return nil, nil, errors.Errorf("too many links") + // Apply the component to the path. Since it is a single component, and + // our current path contains no symlinks, we can just apply it + // leixically. + nextPath := path.Join("/", currentPath, part) + if nextPath == "/" { + // If we hit the root, just treat it as a directory. + currentPath = "/" + continue + } + if nextPath == currentPath { + // noop component + continue + } + + cr = nil + v, ok := root.Get(convertPathToKey([]byte(nextPath))) + if ok { + cr = v.(*CacheRecord) + } + if cb != nil { + if err := cb(nextPath, cr); err != nil { + return nil, nil, err } + } + if !ok || cr.Type != CacheRecordTypeSymlink { + currentPath = nextPath + continue + } + if !followTrailing && remainingPath == "" { + currentPath = nextPath + break + } - link := cleanLink(string(convertKeyToPath(dir)), parent.Linkname) - return getFollowLinksWalk(root, append(convertPathToKey([]byte(link)), file...), follow, linksWalked) + linksWalked++ + if linksWalked > maxSymlinkLimit { + return nil, nil, errTooManyLinks } - } - k = append(k, file...) - v, ok = root.Get(k) - if ok { - return k, v.(*CacheRecord), nil - } - return k, nil, nil -} -func cleanLink(dir, linkname string) string { - dirPath := path.Clean(dir) - if dirPath == "." || dirPath == "/" { - dirPath = "" + remainingPath = cr.Linkname + "/" + remainingPath + if path.IsAbs(cr.Linkname) { + currentPath = "/" + } } - link := path.Clean(linkname) - if !path.IsAbs(link) { - return path.Join("/", path.Join(path.Dir(dirPath), link)) + // We've already looked up the final component. However, if there was a + // trailing slash in the original path, we need to do the lookup again with + // the slash applied. + if hadTrailingSlash { + cr = nil + currentPath += "/" + v, ok := root.Get(convertPathToKey([]byte(currentPath))) + if ok { + cr = v.(*CacheRecord) + } } - return link + return convertPathToKey([]byte(currentPath)), cr, nil } func prepareDigest(fp, p string, fi os.FileInfo) (digest.Digest, error) { @@ -1181,18 +1201,3 @@ func convertPathToKey(p []byte) []byte { func convertKeyToPath(p []byte) []byte { return bytes.Replace([]byte(p), []byte{0}, []byte("/"), -1) } - -func splitKey(k []byte) ([]byte, []byte) { - foundBytes := false - i := len(k) - 1 - for { - if i <= 0 || foundBytes && k[i] == 0 { - break - } - if k[i] != 0 { - foundBytes = true - } - i-- - } - return append([]byte{}, k[:i]...), k[i:] -} diff --git a/vendor/github.com/moby/buildkit/cache/contenthash/path.go b/vendor/github.com/moby/buildkit/cache/contenthash/path.go index 42b7fd8349c72..4f367a6a81a93 100644 --- a/vendor/github.com/moby/buildkit/cache/contenthash/path.go +++ b/vendor/github.com/moby/buildkit/cache/contenthash/path.go @@ -3,106 +3,98 @@ package contenthash import ( "os" "path/filepath" + "strings" "github.com/pkg/errors" + "golang.org/x/sys/unix" ) -var ( - errTooManyLinks = errors.New("too many links") -) +var errTooManyLinks error = unix.ELOOP + +const maxSymlinkLimit = 255 type onSymlinkFunc func(string, string) error // rootPath joins a path with a root, evaluating and bounding any // symlink to the root directory. -// This is containerd/continuity/fs RootPath implementation with a callback on -// resolving the symlink. -func rootPath(root, path string, cb onSymlinkFunc) (string, error) { - if path == "" { +// This is github.com/cyphar/filepath-securejoin.SecureJoinVFS's implementation +// with a callback on resolving the symlink. +func rootPath(root, unsafePath string, followTrailing bool, cb onSymlinkFunc) (string, error) { + if unsafePath == "" { return root, nil } - var linksWalked int // to protect against cycles - for { - i := linksWalked - newpath, err := walkLinks(root, path, &linksWalked, cb) - if err != nil { - return "", err - } - path = newpath - if i == linksWalked { - newpath = filepath.Join("/", newpath) - if path == newpath { - return filepath.Join(root, newpath), nil - } - path = newpath + unsafePath = filepath.FromSlash(unsafePath) + + var ( + path string + linksWalked int + ) + for unsafePath != "" { + // Windows-specific: remove any drive letters from the path. + if v := filepath.VolumeName(unsafePath); v != "" { + unsafePath = unsafePath[len(v):] } - } -} -func walkLink(root, path string, linksWalked *int, cb onSymlinkFunc) (newpath string, islink bool, err error) { - if *linksWalked > 255 { - return "", false, errTooManyLinks - } + // Get the next path component. + var part string + if i := strings.IndexRune(unsafePath, filepath.Separator); i == -1 { + part, unsafePath = unsafePath, "" + } else { + part, unsafePath = unsafePath[:i], unsafePath[i+1:] + } - path = filepath.Join("/", path) - if path == "/" { - return path, false, nil - } - realPath := filepath.Join(root, path) + // Apply the component lexically to the path we are building. path does + // not contain any symlinks, and we are lexically dealing with a single + // component, so it's okay to do filepath.Clean here. + nextPath := filepath.Join(string(filepath.Separator), path, part) + if nextPath == string(filepath.Separator) { + // If we end up back at the root, we don't need to re-evaluate /. + path = "/" + continue + } + fullPath := filepath.Join(root, nextPath) - fi, err := os.Lstat(realPath) - if err != nil { - // If path does not yet exist, treat as non-symlink - if errors.Is(err, os.ErrNotExist) { - return path, false, nil + // Figure out whether the path is a symlink. + fi, err := os.Lstat(fullPath) + if err != nil && !errors.Is(err, os.ErrNotExist) { + return "", err } - return "", false, err - } - if fi.Mode()&os.ModeSymlink == 0 { - return path, false, nil - } - newpath, err = os.Readlink(realPath) - if err != nil { - return "", false, err - } - if cb != nil { - if err := cb(path, newpath); err != nil { - return "", false, err + // Treat non-existent path components the same as non-symlinks (we + // can't do any better here). + if errors.Is(err, os.ErrNotExist) || fi.Mode()&os.ModeSymlink == 0 { + path = nextPath + continue } - } - *linksWalked++ - return newpath, true, nil -} - -func walkLinks(root, path string, linksWalked *int, cb onSymlinkFunc) (string, error) { - switch dir, file := filepath.Split(path); { - case dir == "": - newpath, _, err := walkLink(root, file, linksWalked, cb) - return newpath, err - case file == "": - if os.IsPathSeparator(dir[len(dir)-1]) { - if dir == "/" { - return dir, nil - } - return walkLinks(root, dir[:len(dir)-1], linksWalked, cb) + if !followTrailing && unsafePath == "" { + path = nextPath + break } - newpath, _, err := walkLink(root, dir, linksWalked, cb) - return newpath, err - default: - newdir, err := walkLinks(root, dir, linksWalked, cb) - if err != nil { - return "", err + + // It's a symlink, so get its contents and expand it by prepending it + // to the yet-unparsed path. + linksWalked++ + if linksWalked > maxSymlinkLimit { + return "", errTooManyLinks } - newpath, islink, err := walkLink(root, filepath.Join(newdir, file), linksWalked, cb) + + dest, err := os.Readlink(fullPath) if err != nil { return "", err } - if !islink { - return newpath, nil + if cb != nil { + if err := cb(nextPath, dest); err != nil { + return "", err + } } - if filepath.IsAbs(newpath) { - return newpath, nil + unsafePath = dest + string(filepath.Separator) + unsafePath + // Absolute symlinks reset any work we've already done. + if filepath.IsAbs(dest) { + path = "/" } - return filepath.Join(newdir, newpath), nil } + + // There should be no lexical components left in path here, but just for + // safety do a filepath.Clean before the join. + finalPath := filepath.Join(string(filepath.Separator), path) + return filepath.Join(root, finalPath), nil } diff --git a/vendor/modules.txt b/vendor/modules.txt index 638455f1762a1..e0aef77dfe017 100644 --- a/vendor/modules.txt +++ b/vendor/modules.txt @@ -577,7 +577,7 @@ github.com/mistifyio/go-zfs/v3 # github.com/mitchellh/hashstructure/v2 v2.0.2 ## explicit; go 1.14 github.com/mitchellh/hashstructure/v2 -# github.com/moby/buildkit v0.11.7-0.20230908085316-d3e6c1360f6e => github.com/dcermak/buildkit v0.0.0-20240212085728-98616a35568e +# github.com/moby/buildkit v0.11.7-0.20230908085316-d3e6c1360f6e => github.com/cyphar/buildkit v0.0.0-20240506154547-88b38858b334 ## explicit; go 1.18 github.com/moby/buildkit/api/services/control github.com/moby/buildkit/api/types @@ -1312,4 +1312,4 @@ k8s.io/klog/v2/internal/severity # resenje.org/singleflight v0.3.0 ## explicit; go 1.18 resenje.org/singleflight -# github.com/moby/buildkit => github.com/dcermak/buildkit v0.0.0-20240212085728-98616a35568e +# github.com/moby/buildkit => github.com/cyphar/buildkit v0.0.0-20240506154547-88b38858b334