From 96037851ab1fc4a3ee658edeb3488179c7e4fc46 Mon Sep 17 00:00:00 2001
From: Tibor Blenessy <saberduck@users.noreply.github.com>
Date: Wed, 15 Nov 2023 01:05:19 +0100
Subject: [PATCH 1/6] Create rule S6847
 (`jsx-a11y/no-noninteractive-element-interactions`): Non-interactive elements
 shouldn't have event handlers

---
 .../jsts/ant-design/javascript-S6847.json     | 13 +++++++
 .../jsts/ant-design/typescript-S6847.json     | 17 +++++++++
 .../jsts/desktop/typescript-S6847.json        | 24 ++++++++++++
 .../jsts/file-for-rules/javascript-S1082.json |  6 +++
 .../jsts/file-for-rules/javascript-S1438.json |  3 ++
 .../jsts/file-for-rules/javascript-S6819.json |  3 ++
 .../jsts/file-for-rules/javascript-S6847.json |  6 +++
 .../react-cloud-music/javascript-S6847.json   | 20 ++++++++++
 .../expected/jsts/redux/javascript-S6847.json |  8 ++++
 .../jsts/vuetify/typescript-S6847.json        |  8 ++++
 its/sources/jsts/custom/S6847.js              |  6 +++
 .../sonar/javascript/checks/CheckList.java    |  1 +
 ...nInteractiveElementsWithHandlersCheck.java | 37 +++++++++++++++++++
 .../javascript/rules/javascript/S6847.html    | 32 ++++++++++++++++
 .../javascript/rules/javascript/S6847.json    | 30 +++++++++++++++
 .../rules/javascript/Sonar_way_profile.json   |  1 +
 16 files changed, 215 insertions(+)
 create mode 100644 its/ruling/src/test/expected/jsts/ant-design/javascript-S6847.json
 create mode 100644 its/ruling/src/test/expected/jsts/ant-design/typescript-S6847.json
 create mode 100644 its/ruling/src/test/expected/jsts/desktop/typescript-S6847.json
 create mode 100644 its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1082.json
 create mode 100644 its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6847.json
 create mode 100644 its/ruling/src/test/expected/jsts/react-cloud-music/javascript-S6847.json
 create mode 100644 its/ruling/src/test/expected/jsts/redux/javascript-S6847.json
 create mode 100644 its/ruling/src/test/expected/jsts/vuetify/typescript-S6847.json
 create mode 100644 its/sources/jsts/custom/S6847.js
 create mode 100644 sonar-plugin/javascript-checks/src/main/java/org/sonar/javascript/checks/NoNonInteractiveElementsWithHandlersCheck.java
 create mode 100644 sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.html
 create mode 100644 sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.json

diff --git a/its/ruling/src/test/expected/jsts/ant-design/javascript-S6847.json b/its/ruling/src/test/expected/jsts/ant-design/javascript-S6847.json
new file mode 100644
index 00000000000..2ebb2a3887a
--- /dev/null
+++ b/its/ruling/src/test/expected/jsts/ant-design/javascript-S6847.json
@@ -0,0 +1,13 @@
+{
+"ant-design:components/space/__tests__/index.test.js": [
+142
+],
+"ant-design:site/theme/template/Content/Demo/index.jsx": [
+146,
+379,
+396,
+416,
+464,
+474
+]
+}
diff --git a/its/ruling/src/test/expected/jsts/ant-design/typescript-S6847.json b/its/ruling/src/test/expected/jsts/ant-design/typescript-S6847.json
new file mode 100644
index 00000000000..e0f84e33720
--- /dev/null
+++ b/its/ruling/src/test/expected/jsts/ant-design/typescript-S6847.json
@@ -0,0 +1,17 @@
+{
+"ant-design:components/alert/index.tsx": [
+177
+],
+"ant-design:components/avatar/avatar.tsx": [
+168
+],
+"ant-design:components/checkbox/Checkbox.tsx": [
+120
+],
+"ant-design:components/radio/radio.tsx": [
+68
+],
+"ant-design:site/theme/template/Content/Article.tsx": [
+113
+]
+}
diff --git a/its/ruling/src/test/expected/jsts/desktop/typescript-S6847.json b/its/ruling/src/test/expected/jsts/desktop/typescript-S6847.json
new file mode 100644
index 00000000000..b081e684ddc
--- /dev/null
+++ b/its/ruling/src/test/expected/jsts/desktop/typescript-S6847.json
@@ -0,0 +1,24 @@
+{
+"desktop:app/src/ui/changes/commit-message.tsx": [
+753
+],
+"desktop:app/src/ui/dialog/dialog.tsx": [
+593
+],
+"desktop:app/src/ui/diff/image-diffs/image-container.tsx": [
+23
+],
+"desktop:app/src/ui/dropdown-select-button.tsx": [
+161
+],
+"desktop:app/src/ui/lib/avatar.tsx": [
+223
+],
+"desktop:app/src/ui/lib/vertical-segmented-control/vertical-segmented-control.tsx": [
+197
+],
+"desktop:app/src/ui/tutorial/tutorial-step-instruction.tsx": [
+34,
+35
+]
+}
diff --git a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1082.json b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1082.json
new file mode 100644
index 00000000000..77bf4c91fcd
--- /dev/null
+++ b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1082.json
@@ -0,0 +1,6 @@
+{
+"file-for-rules:S6847.js": [
+3,
+4
+]
+}
diff --git a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1438.json b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1438.json
index f2b31b12da4..433b502b9eb 100644
--- a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1438.json
+++ b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1438.json
@@ -40,5 +40,8 @@
 ],
 "file-for-rules:S6332.js": [
 3
+],
+"file-for-rules:S6847.js": [
+5
 ]
 }
diff --git a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6819.json b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6819.json
index 1e34f32d355..51983cefb4d 100644
--- a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6819.json
+++ b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6819.json
@@ -4,5 +4,8 @@
 ],
 "file-for-rules:S6843.js": [
 2
+],
+"file-for-rules:S6847.js": [
+4
 ]
 }
diff --git a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6847.json b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6847.json
new file mode 100644
index 00000000000..77bf4c91fcd
--- /dev/null
+++ b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6847.json
@@ -0,0 +1,6 @@
+{
+"file-for-rules:S6847.js": [
+3,
+4
+]
+}
diff --git a/its/ruling/src/test/expected/jsts/react-cloud-music/javascript-S6847.json b/its/ruling/src/test/expected/jsts/react-cloud-music/javascript-S6847.json
new file mode 100644
index 00000000000..3efc4a82b4d
--- /dev/null
+++ b/its/ruling/src/test/expected/jsts/react-cloud-music/javascript-S6847.json
@@ -0,0 +1,20 @@
+{
+"react-cloud-music:src/application/Player/play-list/index.jsx": [
+225
+],
+"react-cloud-music:src/application/Search/index.jsx": [
+54,
+152
+],
+"react-cloud-music:src/application/SongList/index.jsx": [
+41
+],
+"react-cloud-music:src/application/User/Login/LoginForm/index.jsx": [
+46,
+51,
+56
+],
+"react-cloud-music:src/application/User/Login/PhoneForm/index.jsx": [
+42
+]
+}
diff --git a/its/ruling/src/test/expected/jsts/redux/javascript-S6847.json b/its/ruling/src/test/expected/jsts/redux/javascript-S6847.json
new file mode 100644
index 00000000000..54854479ba2
--- /dev/null
+++ b/its/ruling/src/test/expected/jsts/redux/javascript-S6847.json
@@ -0,0 +1,8 @@
+{
+"redux:examples/todomvc/components/TodoItem.js": [
+43
+],
+"redux:examples/todos-with-undo/components/Todo.js": [
+6
+]
+}
diff --git a/its/ruling/src/test/expected/jsts/vuetify/typescript-S6847.json b/its/ruling/src/test/expected/jsts/vuetify/typescript-S6847.json
new file mode 100644
index 00000000000..9ebd62bb3ae
--- /dev/null
+++ b/its/ruling/src/test/expected/jsts/vuetify/typescript-S6847.json
@@ -0,0 +1,8 @@
+{
+"vuetify:packages/vuetify/src/components/VImg/VImg.tsx": [
+206
+],
+"vuetify:packages/vuetify/src/components/VRating/VRating.tsx": [
+181
+]
+}
diff --git a/its/sources/jsts/custom/S6847.js b/its/sources/jsts/custom/S6847.js
new file mode 100644
index 00000000000..e4956bbd6e4
--- /dev/null
+++ b/its/sources/jsts/custom/S6847.js
@@ -0,0 +1,6 @@
+function div() {
+    return <>
+      <li onClick={() => void 0} />
+      <div onClick={() => void 0} role="listitem" />
+    </>
+}
diff --git a/sonar-plugin/javascript-checks/src/main/java/org/sonar/javascript/checks/CheckList.java b/sonar-plugin/javascript-checks/src/main/java/org/sonar/javascript/checks/CheckList.java
index 5c07eaa49b9..2ac0382f769 100644
--- a/sonar-plugin/javascript-checks/src/main/java/org/sonar/javascript/checks/CheckList.java
+++ b/sonar-plugin/javascript-checks/src/main/java/org/sonar/javascript/checks/CheckList.java
@@ -300,6 +300,7 @@ public static List<Class<? extends JavaScriptCheck>> getAllChecks() {
       NoNewNativeNonconstructorCheck.class,
       NoNonNullAssertionCheck.class,
       NoNoninteractiveElementToInteractiveRoleCheck.class,
+      NoNonInteractiveElementsWithHandlersCheck.class,
       NoNoninteractiveTabindexCheck.class,
       NoOctalEscapeCheck.class,
       NoOneIterationLoopCheck.class,
diff --git a/sonar-plugin/javascript-checks/src/main/java/org/sonar/javascript/checks/NoNonInteractiveElementsWithHandlersCheck.java b/sonar-plugin/javascript-checks/src/main/java/org/sonar/javascript/checks/NoNonInteractiveElementsWithHandlersCheck.java
new file mode 100644
index 00000000000..c5a207bf1ad
--- /dev/null
+++ b/sonar-plugin/javascript-checks/src/main/java/org/sonar/javascript/checks/NoNonInteractiveElementsWithHandlersCheck.java
@@ -0,0 +1,37 @@
+/*
+ * SonarQube JavaScript Plugin
+ * Copyright (C) 2011-2023 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+package org.sonar.javascript.checks;
+
+import org.sonar.check.Rule;
+import org.sonar.plugins.javascript.api.EslintBasedCheck;
+import org.sonar.plugins.javascript.api.JavaScriptRule;
+import org.sonar.plugins.javascript.api.TestFileCheck;
+import org.sonar.plugins.javascript.api.TypeScriptRule;
+
+@TypeScriptRule
+@JavaScriptRule
+@Rule(key = "S6847")
+public class NoNonInteractiveElementsWithHandlersCheck implements EslintBasedCheck {
+
+  @Override
+  public String eslintKey() {
+    return "no-noninteractive-element-interactions";
+  }
+}
diff --git a/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.html b/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.html
new file mode 100644
index 00000000000..609dd058a6f
--- /dev/null
+++ b/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.html
@@ -0,0 +1,32 @@
+<p>Non-interactive HTML elements, such as divs and spans, are not designed to have event handlers. When these elements are given event handlers, it
+can lead to accessibility issues.</p>
+<h2>Why is this an issue?</h2>
+<p>Attaching event handlers to non-interactive HTML elements can lead to significant accessibility issues. These elements, such as divs and spans, are
+not designed to interact with assistive technologies like screen readers, making it difficult for users with disabilities to navigate and interact
+with the website. Additionally, these elements may not be focusable or provide visual feedback when interacted with, resulting in a confusing and
+potentially frustrating user experience. Therefore, to maintain an accessible and user-friendly website, event handlers should be used exclusively
+with interactive elements.</p>
+<h2>How to fix it</h2>
+<h3>Code examples</h3>
+<h4>Noncompliant code example</h4>
+<pre data-diff-id="1" data-diff-type="noncompliant">
+&lt;li onClick={() =&gt; void 0} /&gt;
+&lt;div onClick={() =&gt; void 0} role="listitem" /&gt;
+</pre>
+<h4>Compliant solution</h4>
+<pre data-diff-id="1" data-diff-type="compliant">
+&lt;div onClick={() =&gt; void 0} role="button" /&gt;
+&lt;div onClick={() =&gt; void 0} role="presentation" /&gt;
+&lt;input type="text" onClick={() =&gt; void 0} /&gt; // Interactive element does not require role.
+&lt;button onClick={() =&gt; void 0} className="foo" /&gt; // button is interactive.
+&lt;div onClick={() =&gt; void 0} role="button" aria-hidden /&gt; // This is hidden from screenreader.
+&lt;Input onClick={() =&gt; void 0} type="hidden" /&gt; // This is a higher-level DOM component
+</pre>
+<h2>Resources</h2>
+<h3>Documentation</h3>
+<ul>
+  <li> <a href="https://www.w3.org/TR/wai-aria-practices-1.1/#aria_ex">WAI-ARIA Authoring Practices Guide - Design Patterns and Widgets</a> </li>
+  <li> MDN - <a href="https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_button_role#Keyboard_and_focus">ARIA
+  Techniques</a> </li>
+</ul>
+
diff --git a/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.json b/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.json
new file mode 100644
index 00000000000..4ee0f5acd43
--- /dev/null
+++ b/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.json
@@ -0,0 +1,30 @@
+{
+  "title": "Non-interactive elements shouldn\u0027t have event handlers",
+  "type": "CODE_SMELL",
+  "status": "ready",
+  "remediation": {
+    "func": "Constant\/Issue",
+    "constantCost": "5min"
+  },
+  "tags": [
+    "accessibility",
+    "react"
+  ],
+  "defaultSeverity": "Major",
+  "ruleSpecification": "RSPEC-6847",
+  "sqKey": "S6847",
+  "scope": "All",
+  "quickfix": "infeasible",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "LOW",
+      "RELIABILITY": "LOW",
+      "SECURITY": "LOW"
+    },
+    "attribute": "CONVENTIONAL"
+  },
+  "compatibleLanguages": [
+    "JAVASCRIPT",
+    "TYPESCRIPT"
+  ]
+}
diff --git a/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/Sonar_way_profile.json b/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/Sonar_way_profile.json
index 33100f28ac7..49c984c3258 100644
--- a/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/Sonar_way_profile.json
+++ b/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/Sonar_way_profile.json
@@ -315,6 +315,7 @@
     "S6844",
     "S6845",
     "S6846",
+    "S6847",
     "S6848",
     "S6849",
     "S6850",

From 044917ea5f8d876676cc677793ebb3050edf0c32 Mon Sep 17 00:00:00 2001
From: Tibor Blenessy <saberduck@users.noreply.github.com>
Date: Wed, 15 Nov 2023 10:00:09 +0100
Subject: [PATCH 2/6] fix smell

---
 .../checks/NoNonInteractiveElementsWithHandlersCheck.java        | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sonar-plugin/javascript-checks/src/main/java/org/sonar/javascript/checks/NoNonInteractiveElementsWithHandlersCheck.java b/sonar-plugin/javascript-checks/src/main/java/org/sonar/javascript/checks/NoNonInteractiveElementsWithHandlersCheck.java
index c5a207bf1ad..30ccb9099cc 100644
--- a/sonar-plugin/javascript-checks/src/main/java/org/sonar/javascript/checks/NoNonInteractiveElementsWithHandlersCheck.java
+++ b/sonar-plugin/javascript-checks/src/main/java/org/sonar/javascript/checks/NoNonInteractiveElementsWithHandlersCheck.java
@@ -22,7 +22,6 @@
 import org.sonar.check.Rule;
 import org.sonar.plugins.javascript.api.EslintBasedCheck;
 import org.sonar.plugins.javascript.api.JavaScriptRule;
-import org.sonar.plugins.javascript.api.TestFileCheck;
 import org.sonar.plugins.javascript.api.TypeScriptRule;
 
 @TypeScriptRule

From b31f12dc83f9d181396ddcd88156a7276dea3d7c Mon Sep 17 00:00:00 2001
From: Tibor Blenessy <saberduck@users.noreply.github.com>
Date: Thu, 16 Nov 2023 14:44:50 +0100
Subject: [PATCH 3/6] update meta

---
 .../javascript/rules/javascript/S6847.html    | 22 ++++++++++---------
 .../javascript/rules/javascript/S6847.json    |  7 +++---
 2 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.html b/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.html
index 609dd058a6f..10b840b6b0b 100644
--- a/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.html
+++ b/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.html
@@ -1,12 +1,14 @@
-<p>Non-interactive HTML elements, such as divs and spans, are not designed to have event handlers. When these elements are given event handlers, it
-can lead to accessibility issues.</p>
+<p>Non-interactive HTML elements, such as <code>&lt;div&gt;</code> and <code>&lt;span&gt;</code>, are not designed to have event handlers. When these
+elements are given event handlers, it can lead to accessibility issues.</p>
 <h2>Why is this an issue?</h2>
-<p>Attaching event handlers to non-interactive HTML elements can lead to significant accessibility issues. These elements, such as divs and spans, are
-not designed to interact with assistive technologies like screen readers, making it difficult for users with disabilities to navigate and interact
-with the website. Additionally, these elements may not be focusable or provide visual feedback when interacted with, resulting in a confusing and
-potentially frustrating user experience. Therefore, to maintain an accessible and user-friendly website, event handlers should be used exclusively
-with interactive elements.</p>
+<p>Attaching event handlers to non-interactive HTML elements can lead to significant accessibility issues. These elements, such as
+<code>&lt;div&gt;</code> and <code>&lt;span&gt;</code>, are not designed to interact with assistive technologies like screen readers, making it
+difficult for users with disabilities to navigate and interact with the website. Additionally, these elements may not be focusable or provide visual
+feedback when interacted with, resulting in a confusing and potentially frustrating user experience. Therefore, to maintain an accessible and
+user-friendly website, event handlers should be used exclusively with interactive elements.</p>
 <h2>How to fix it</h2>
+<p>To fix this issue, remove the event handler from the non-interactive element and attach it to an interactive element instead. If the element is not
+interactive, it should not have an event handler.</p>
 <h3>Code examples</h3>
 <h4>Noncompliant code example</h4>
 <pre data-diff-id="1" data-diff-type="noncompliant">
@@ -19,13 +21,13 @@ <h4>Compliant solution</h4>
 &lt;div onClick={() =&gt; void 0} role="presentation" /&gt;
 &lt;input type="text" onClick={() =&gt; void 0} /&gt; // Interactive element does not require role.
 &lt;button onClick={() =&gt; void 0} className="foo" /&gt; // button is interactive.
-&lt;div onClick={() =&gt; void 0} role="button" aria-hidden /&gt; // This is hidden from screenreader.
-&lt;Input onClick={() =&gt; void 0} type="hidden" /&gt; // This is a higher-level DOM component
+&lt;div onClick={() =&gt; void 0} role="button" aria-hidden /&gt; // This is hidden from the screenreader.
 </pre>
 <h2>Resources</h2>
 <h3>Documentation</h3>
 <ul>
-  <li> <a href="https://www.w3.org/TR/wai-aria-practices-1.1/#aria_ex">WAI-ARIA Authoring Practices Guide - Design Patterns and Widgets</a> </li>
+  <li> WCAG - <a href="https://www.w3.org/TR/wai-aria-practices-1.1/#aria_ex">WAI-ARIA Authoring Practices Guide - Design Patterns and Widgets</a>
+  </li>
   <li> MDN - <a href="https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_button_role#Keyboard_and_focus">ARIA
   Techniques</a> </li>
 </ul>
diff --git a/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.json b/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.json
index 4ee0f5acd43..f4894d6e44b 100644
--- a/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.json
+++ b/sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6847.json
@@ -10,16 +10,15 @@
     "accessibility",
     "react"
   ],
-  "defaultSeverity": "Major",
+  "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-6847",
   "sqKey": "S6847",
   "scope": "All",
   "quickfix": "infeasible",
   "code": {
     "impacts": {
-      "MAINTAINABILITY": "LOW",
-      "RELIABILITY": "LOW",
-      "SECURITY": "LOW"
+      "MAINTAINABILITY": "MEDIUM",
+      "RELIABILITY": "LOW"
     },
     "attribute": "CONVENTIONAL"
   },

From b7c6380a172ff1d475cf7e7d110ec5af90c731da Mon Sep 17 00:00:00 2001
From: Tibor Blenessy <saberduck@users.noreply.github.com>
Date: Thu, 16 Nov 2023 14:58:38 +0100
Subject: [PATCH 4/6] remove custom file

---
 .../test/expected/jsts/file-for-rules/javascript-S6847.json | 6 ------
 its/sources/jsts/custom/S6847.js                            | 6 ------
 2 files changed, 12 deletions(-)
 delete mode 100644 its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6847.json
 delete mode 100644 its/sources/jsts/custom/S6847.js

diff --git a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6847.json b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6847.json
deleted file mode 100644
index 77bf4c91fcd..00000000000
--- a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6847.json
+++ /dev/null
@@ -1,6 +0,0 @@
-{
-"file-for-rules:S6847.js": [
-3,
-4
-]
-}
diff --git a/its/sources/jsts/custom/S6847.js b/its/sources/jsts/custom/S6847.js
deleted file mode 100644
index e4956bbd6e4..00000000000
--- a/its/sources/jsts/custom/S6847.js
+++ /dev/null
@@ -1,6 +0,0 @@
-function div() {
-    return <>
-      <li onClick={() => void 0} />
-      <div onClick={() => void 0} role="listitem" />
-    </>
-}

From e29eb6a20f6927c71106ca2426c8b2247e502557 Mon Sep 17 00:00:00 2001
From: Tibor Blenessy <saberduck@users.noreply.github.com>
Date: Thu, 16 Nov 2023 15:16:03 +0100
Subject: [PATCH 5/6] fix

---
 .../test/expected/jsts/file-for-rules/javascript-S1438.json    | 3 ---
 .../test/expected/jsts/file-for-rules/javascript-S6819.json    | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1438.json b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1438.json
index 433b502b9eb..f2b31b12da4 100644
--- a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1438.json
+++ b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1438.json
@@ -40,8 +40,5 @@
 ],
 "file-for-rules:S6332.js": [
 3
-],
-"file-for-rules:S6847.js": [
-5
 ]
 }
diff --git a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6819.json b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6819.json
index 51983cefb4d..1e34f32d355 100644
--- a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6819.json
+++ b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S6819.json
@@ -4,8 +4,5 @@
 ],
 "file-for-rules:S6843.js": [
 2
-],
-"file-for-rules:S6847.js": [
-4
 ]
 }

From 22f8cf248d4a7b077a5c7aa41a3ca57e91c5d820 Mon Sep 17 00:00:00 2001
From: Tibor Blenessy <saberduck@users.noreply.github.com>
Date: Thu, 16 Nov 2023 16:46:23 +0100
Subject: [PATCH 6/6] damn!

---
 .../test/expected/jsts/file-for-rules/javascript-S1082.json | 6 ------
 1 file changed, 6 deletions(-)
 delete mode 100644 its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1082.json

diff --git a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1082.json b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1082.json
deleted file mode 100644
index 77bf4c91fcd..00000000000
--- a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S1082.json
+++ /dev/null
@@ -1,6 +0,0 @@
-{
-"file-for-rules:S6847.js": [
-3,
-4
-]
-}