diff --git a/its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/CssIssuesTest.java b/its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/CssIssuesTest.java index 007e6e33938..39ab86bc2b5 100644 --- a/its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/CssIssuesTest.java +++ b/its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/CssIssuesTest.java @@ -69,10 +69,10 @@ public static void prepare() { void parsing_error_not_on_excluded_files() { assertThat(buildResult.getLogs()) .doesNotMatch( - "(?s).*ERROR: Failed to parse file:\\S*file-with-parsing-error-excluded\\.css.*" + "(?s).*WARN: Failed to parse file file:\\S*file-with-parsing-error-excluded\\.css.*" ) .matches( - "(?s).*ERROR: Failed to parse file:\\S*file-with-parsing-error\\.css, line 1, Unclosed block.*" + "(?s).*WARN: Failed to parse file file:\\S*file-with-parsing-error\\.css, line 1, Unclosed block.*" ); } diff --git a/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/AnalysisProcessor.java b/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/AnalysisProcessor.java index 29eaffa4a34..df0cf68c7d8 100644 --- a/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/AnalysisProcessor.java +++ b/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/AnalysisProcessor.java @@ -145,7 +145,7 @@ private void processParsingError(BridgeServer.ParsingError parsingError) { String message = parsingError.message; if (line != null) { - LOG.error("Failed to parse file [{}] at line {}: {}", file, line, message); + LOG.warn("Failed to parse file [{}] at line {}: {}", file, line, message); } else if (parsingError.code == BridgeServer.ParsingErrorCode.FAILING_TYPESCRIPT) { LOG.error("Failed to analyze file [{}] from TypeScript: {}", file, message); } else { diff --git a/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/CssRuleSensor.java b/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/CssRuleSensor.java index 5c71c8a26de..dd6ee342e9e 100644 --- a/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/CssRuleSensor.java +++ b/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/CssRuleSensor.java @@ -158,9 +158,9 @@ private void saveIssues( if (ruleKey == null) { if ("CssSyntaxError".equals(issue.ruleId)) { String errorMessage = issue.message.replace("(CssSyntaxError)", "").trim(); - logErrorOrDebug( + logWarningOrDebug( inputFile, - "Failed to parse {}, line {}, {}", + "Failed to parse file {}, line {}, {}", inputFile.uri(), issue.line, errorMessage @@ -192,6 +192,14 @@ private static void logErrorOrDebug(InputFile file, String msg, Object... argume } } + private static void logWarningOrDebug(InputFile file, String msg, Object... arguments) { + if (CssLanguage.KEY.equals(file.language())) { + LOG.warn(msg, arguments); + } else { + LOG.debug(msg, arguments); + } + } + @Override protected void logErrorOrWarn(String msg, Throwable e) { if (hasCssFiles(context)) { diff --git a/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/CssRuleSensorTest.java b/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/CssRuleSensorTest.java index 329340b59f8..08fdae039ee 100644 --- a/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/CssRuleSensorTest.java +++ b/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/CssRuleSensorTest.java @@ -322,10 +322,10 @@ void test_syntax_error() throws IOException { InputFile inputFileNotCss = addInputFile("syntax-error.html"); sensor.execute(context); assertThat(context.allIssues()).isEmpty(); - assertThat(logTester.logs(LoggerLevel.ERROR)) - .contains("Failed to parse " + inputFile.uri() + ", line 2, Missed semicolon"); + assertThat(logTester.logs(LoggerLevel.WARN)) + .contains("Failed to parse file " + inputFile.uri() + ", line 2, Missed semicolon"); assertThat(logTester.logs(LoggerLevel.DEBUG)) - .contains("Failed to parse " + inputFileNotCss.uri() + ", line 2, Missed semicolon"); + .contains("Failed to parse file " + inputFileNotCss.uri() + ", line 2, Missed semicolon"); } @Test diff --git a/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/HtmlSensorTest.java b/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/HtmlSensorTest.java index a4f3fc8b68a..4c36880620b 100644 --- a/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/HtmlSensorTest.java +++ b/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/HtmlSensorTest.java @@ -216,7 +216,7 @@ void should_raise_a_parsing_error() throws IOException { assertThat(issue.primaryLocation().textRange().start().line()).isEqualTo(1); assertThat(issue.primaryLocation().message()).isEqualTo("Parse error message"); assertThat(context.allAnalysisErrors()).hasSize(1); - assertThat(logTester.logs(LoggerLevel.ERROR)) + assertThat(logTester.logs(LoggerLevel.WARN)) .contains("Failed to parse file [dir/file.html] at line 1: Parse error message"); } diff --git a/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/JavaScriptEslintBasedSensorTest.java b/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/JavaScriptEslintBasedSensorTest.java index 6ab8605bb21..823667c10ea 100644 --- a/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/JavaScriptEslintBasedSensorTest.java +++ b/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/JavaScriptEslintBasedSensorTest.java @@ -588,7 +588,7 @@ void should_raise_a_parsing_error() throws IOException { assertThat(issue.primaryLocation().textRange().start().line()).isEqualTo(3); assertThat(issue.primaryLocation().message()).isEqualTo("Parse error message"); assertThat(context.allAnalysisErrors()).hasSize(1); - assertThat(logTester.logs(LoggerLevel.ERROR)) + assertThat(logTester.logs(LoggerLevel.WARN)) .contains("Failed to parse file [dir/file.js] at line 3: Parse error message"); } @@ -615,7 +615,7 @@ void should_not_create_parsing_issue_when_no_rule() throws IOException { Collection issues = context.allIssues(); assertThat(issues).isEmpty(); assertThat(context.allAnalysisErrors()).hasSize(1); - assertThat(logTester.logs(LoggerLevel.ERROR)) + assertThat(logTester.logs(LoggerLevel.WARN)) .contains("Failed to parse file [dir/file.js] at line 3: Parse error message"); } diff --git a/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/JsTsSensorTest.java b/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/JsTsSensorTest.java index 5a8d22dacc0..a2c0bd14310 100644 --- a/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/JsTsSensorTest.java +++ b/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/JsTsSensorTest.java @@ -286,7 +286,7 @@ void should_raise_a_parsing_error() throws IOException { assertThat(issue.primaryLocation().textRange().start().line()).isEqualTo(3); assertThat(issue.primaryLocation().message()).isEqualTo("Parse error message"); assertThat(context.allAnalysisErrors()).hasSize(1); - assertThat(logTester.logs(LoggerLevel.ERROR)) + assertThat(logTester.logs(LoggerLevel.WARN)) .contains("Failed to parse file [dir/file.ts] at line 3: Parse error message"); } diff --git a/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/YamlSensorTest.java b/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/YamlSensorTest.java index 926359ef0fd..82dc96fc429 100644 --- a/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/YamlSensorTest.java +++ b/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/YamlSensorTest.java @@ -182,7 +182,7 @@ void should_raise_a_parsing_error() throws IOException { assertThat(issue.primaryLocation().textRange().start().line()).isEqualTo(1); assertThat(issue.primaryLocation().message()).isEqualTo("Parse error message"); assertThat(context.allAnalysisErrors()).hasSize(1); - assertThat(logTester.logs(LoggerLevel.ERROR)) + assertThat(logTester.logs(LoggerLevel.WARN)) .contains("Failed to parse file [dir/file.yaml] at line 1: Parse error message"); }