From 15c12bdd39d1c2298e5bd2363f5c64fb8142f0d8 Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Sun, 6 Nov 2022 00:16:20 +0100 Subject: [PATCH] Rename all `vis-editors` and `datavis` to `visualizations` (#144589) * rename all the vis-editors * rename datavis to visualizations --- .github/CODEOWNERS | 10 +++++----- dev_docs/key_concepts/building_blocks.mdx | 2 +- packages/kbn-chart-icons/kibana.jsonc | 2 +- packages/kbn-coloring/kibana.jsonc | 2 +- .../kbn-language-documentation-popover/kibana.jsonc | 2 +- packages/kbn-timelion-grammar/kibana.jsonc | 2 +- packages/kbn-tinymath/kibana.jsonc | 2 +- renovate.json | 8 ++++---- .../chart_expressions/expression_gauge/kibana.json | 2 +- .../chart_expressions/expression_heatmap/kibana.json | 2 +- .../expression_legacy_metric/kibana.json | 2 +- .../chart_expressions/expression_metric/kibana.json | 2 +- .../expression_partition_vis/kibana.json | 2 +- .../chart_expressions/expression_tagcloud/kibana.json | 2 +- .../chart_expressions/expression_xy/kibana.json | 2 +- src/plugins/charts/kibana.json | 2 +- src/plugins/event_annotation/kibana.json | 2 +- src/plugins/management/kibana.json | 2 +- src/plugins/url_forwarding/kibana.json | 2 +- src/plugins/vis_default_editor/kibana.json | 2 +- src/plugins/vis_types/gauge/kibana.json | 2 +- src/plugins/vis_types/heatmap/kibana.json | 2 +- src/plugins/vis_types/metric/kibana.json | 2 +- src/plugins/vis_types/pie/kibana.json | 2 +- src/plugins/vis_types/table/kibana.json | 2 +- src/plugins/vis_types/tagcloud/kibana.json | 2 +- src/plugins/vis_types/timelion/kibana.json | 2 +- src/plugins/vis_types/timeseries/kibana.json | 2 +- src/plugins/vis_types/vega/kibana.json | 2 +- src/plugins/vis_types/vislib/kibana.json | 2 +- src/plugins/vis_types/xy/kibana.json | 2 +- src/plugins/visualizations/kibana.json | 2 +- .../plugins/kbn_tp_custom_visualizations/kibana.json | 2 +- x-pack/examples/embedded_lens_example/kibana.json | 2 +- x-pack/examples/testing_embedded_lens/kibana.json | 2 +- .../third_party_lens_navigation_prompt/kibana.json | 2 +- .../examples/third_party_vis_lens_example/kibana.json | 2 +- x-pack/plugins/lens/kibana.json | 2 +- x-pack/plugins/lens/readme.md | 2 +- 39 files changed, 46 insertions(+), 46 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index ebe418db4e6585..20081992d725a1 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -885,12 +885,12 @@ packages/kbn-babel-preset @elastic/kibana-operations packages/kbn-bazel-packages @elastic/kibana-operations packages/kbn-bazel-runner @elastic/kibana-operations packages/kbn-cases-components @elastic/response-ops -packages/kbn-chart-icons @elastic/kibana-vis-editors +packages/kbn-chart-icons @elastic/kibana-visualizations packages/kbn-ci-stats-core @elastic/kibana-operations packages/kbn-ci-stats-performance-metrics @elastic/kibana-operations packages/kbn-ci-stats-reporter @elastic/kibana-operations packages/kbn-cli-dev-mode @elastic/kibana-operations -packages/kbn-coloring @elastic/kibana-vis-editors +packages/kbn-coloring @elastic/kibana-visualizations packages/kbn-config @elastic/kibana-core packages/kbn-config-mocks @elastic/kibana-core packages/kbn-config-schema @elastic/kibana-core @@ -933,7 +933,7 @@ packages/kbn-io-ts-utils @elastic/apm-ui packages/kbn-jest-serializers @elastic/kibana-operations packages/kbn-journeys @elastic/kibana-operations packages/kbn-kibana-manifest-schema @elastic/kibana-operations -packages/kbn-language-documentation-popover @elastic/kibana-vis-editors +packages/kbn-language-documentation-popover @elastic/kibana-visualizations packages/kbn-logging @elastic/kibana-core packages/kbn-logging-mocks @elastic/kibana-core packages/kbn-managed-vscode-config @elastic/kibana-operations @@ -982,8 +982,8 @@ packages/kbn-telemetry-tools @elastic/kibana-core packages/kbn-test @elastic/kibana-operations packages/kbn-test-jest-helpers @elastic/kibana-operations packages/kbn-test-subj-selector @elastic/kibana-operations -packages/kbn-timelion-grammar @elastic/kibana-vis-editors -packages/kbn-tinymath @elastic/kibana-vis-editors +packages/kbn-timelion-grammar @elastic/kibana-visualizations +packages/kbn-tinymath @elastic/kibana-visualizations packages/kbn-tooling-log @elastic/kibana-operations packages/kbn-type-summarizer @elastic/kibana-operations packages/kbn-type-summarizer-cli @elastic/kibana-operations diff --git a/dev_docs/key_concepts/building_blocks.mdx b/dev_docs/key_concepts/building_blocks.mdx index 5a7b79b93debf2..29cf2df7a764fa 100644 --- a/dev_docs/key_concepts/building_blocks.mdx +++ b/dev_docs/key_concepts/building_blocks.mdx @@ -52,7 +52,7 @@ The Dashboard Embeddable is one of the highest-level UI components you can add t Check out the Lens Embeddable if you wish to show users visualizations based on Elasticsearch data without worrying about query building and chart rendering. It's built on top of the , and integrates with and . Using the same configuration, it's also possible to link to a prefilled Lens editor, allowing the user to drill deeper and explore their data. -**Github labels**: `Team:VisEditors`, `Feature:Lens` +**Github labels**: `Team:Visualizations`, `Feature:Lens` ### Map Embeddable diff --git a/packages/kbn-chart-icons/kibana.jsonc b/packages/kbn-chart-icons/kibana.jsonc index 1d1de945c95de2..47e7394190fa7d 100644 --- a/packages/kbn-chart-icons/kibana.jsonc +++ b/packages/kbn-chart-icons/kibana.jsonc @@ -1,7 +1,7 @@ { "type": "shared-common", "id": "@kbn/chart-icons", - "owner": "@elastic/kibana-vis-editors", + "owner": "@elastic/kibana-visualizations", "runtimeDeps": [], "typeDeps": [] } diff --git a/packages/kbn-coloring/kibana.jsonc b/packages/kbn-coloring/kibana.jsonc index 0b1ff8a4492864..410698f3458091 100644 --- a/packages/kbn-coloring/kibana.jsonc +++ b/packages/kbn-coloring/kibana.jsonc @@ -1,7 +1,7 @@ { "type": "shared-common", "id": "@kbn/coloring", - "owner": "@elastic/kibana-vis-editors", + "owner": "@elastic/kibana-visualizations", "runtimeDeps": [], "typeDeps": [] } diff --git a/packages/kbn-language-documentation-popover/kibana.jsonc b/packages/kbn-language-documentation-popover/kibana.jsonc index 1c03d32e93d672..45b3f21296bd4c 100644 --- a/packages/kbn-language-documentation-popover/kibana.jsonc +++ b/packages/kbn-language-documentation-popover/kibana.jsonc @@ -1,7 +1,7 @@ { "type": "shared-common", "id": "@kbn/language-documentation-popover", - "owner": "@elastic/kibana-vis-editors", + "owner": "@elastic/kibana-visualizations", "runtimeDeps": [], "typeDeps": [] } diff --git a/packages/kbn-timelion-grammar/kibana.jsonc b/packages/kbn-timelion-grammar/kibana.jsonc index 211d8483089c27..ec0f5079abb807 100644 --- a/packages/kbn-timelion-grammar/kibana.jsonc +++ b/packages/kbn-timelion-grammar/kibana.jsonc @@ -1,7 +1,7 @@ { "type": "shared-common", "id": "@kbn/timelion-grammar", - "owner": "@elastic/kibana-vis-editors", + "owner": "@elastic/kibana-visualizations", "runtimeDeps": [], "typeDeps": [] } diff --git a/packages/kbn-tinymath/kibana.jsonc b/packages/kbn-tinymath/kibana.jsonc index 6ebf2ac0c00ea6..3a26322d2394b9 100644 --- a/packages/kbn-tinymath/kibana.jsonc +++ b/packages/kbn-tinymath/kibana.jsonc @@ -1,7 +1,7 @@ { "type": "shared-common", "id": "@kbn/tinymath", - "owner": "@elastic/kibana-vis-editors", + "owner": "@elastic/kibana-visualizations", "runtimeDeps": [], "typeDeps": [] } diff --git a/renovate.json b/renovate.json index bdaf373932fa1e..9c0f4150b9c80d 100644 --- a/renovate.json +++ b/renovate.json @@ -25,9 +25,9 @@ { "groupName": "@elastic/charts", "matchPackageNames": ["@elastic/charts"], - "reviewers": ["team:datavis", "markov00", "nickofthyme"], + "reviewers": ["team:visualizations", "markov00", "nickofthyme"], "matchBaseBranches": ["main"], - "labels": ["release_note:skip", "backport:skip", "Team:DataVis"], + "labels": ["release_note:skip", "backport:skip", "Team:Visualizations"], "draftPR": true, "enabled": true, "assignAutomerge": true, @@ -97,9 +97,9 @@ { "groupName": "vega related modules", "matchPackageNames": ["vega", "vega-lite", "vega-schema-url-parser", "vega-tooltip"], - "reviewers": ["team:kibana-vis-editors"], + "reviewers": ["team:kibana-visualizations"], "matchBaseBranches": ["main"], - "labels": ["Feature:Vega", "Team:VisEditors"], + "labels": ["Feature:Vega", "Team:Visualizations"], "enabled": true }, { diff --git a/src/plugins/chart_expressions/expression_gauge/kibana.json b/src/plugins/chart_expressions/expression_gauge/kibana.json index 9e5d4da5d7ec64..1de64537db116b 100755 --- a/src/plugins/chart_expressions/expression_gauge/kibana.json +++ b/src/plugins/chart_expressions/expression_gauge/kibana.json @@ -4,7 +4,7 @@ "kibanaVersion": "kibana", "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Expression Gauge plugin adds a `gauge` renderer and function to the expression plugin. The renderer will display the `gauge` chart.", "server": true, diff --git a/src/plugins/chart_expressions/expression_heatmap/kibana.json b/src/plugins/chart_expressions/expression_heatmap/kibana.json index 3608144a8617c0..d0c6acc2a23e51 100755 --- a/src/plugins/chart_expressions/expression_heatmap/kibana.json +++ b/src/plugins/chart_expressions/expression_heatmap/kibana.json @@ -4,7 +4,7 @@ "kibanaVersion": "kibana", "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Expression Heatmap plugin adds a `heatmap` renderer and function to the expression plugin. The renderer will display the `heatmap` chart.", "server": true, diff --git a/src/plugins/chart_expressions/expression_legacy_metric/kibana.json b/src/plugins/chart_expressions/expression_legacy_metric/kibana.json index 5027ff2625d0bf..d3badb13dd0bbc 100755 --- a/src/plugins/chart_expressions/expression_legacy_metric/kibana.json +++ b/src/plugins/chart_expressions/expression_legacy_metric/kibana.json @@ -4,7 +4,7 @@ "kibanaVersion": "kibana", "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Adds a `metric` renderer and function to the expression plugin. The renderer will display the `legacy metric` chart.", "server": true, diff --git a/src/plugins/chart_expressions/expression_metric/kibana.json b/src/plugins/chart_expressions/expression_metric/kibana.json index 5c09ef3b6c365c..ed3ef2173f2009 100755 --- a/src/plugins/chart_expressions/expression_metric/kibana.json +++ b/src/plugins/chart_expressions/expression_metric/kibana.json @@ -4,7 +4,7 @@ "kibanaVersion": "kibana", "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Adds a `metric` renderer and function to the expression plugin. The renderer will display the `metric` chart.", "server": true, diff --git a/src/plugins/chart_expressions/expression_partition_vis/kibana.json b/src/plugins/chart_expressions/expression_partition_vis/kibana.json index e4819f822148d4..17d6e40aaf1b07 100755 --- a/src/plugins/chart_expressions/expression_partition_vis/kibana.json +++ b/src/plugins/chart_expressions/expression_partition_vis/kibana.json @@ -4,7 +4,7 @@ "kibanaVersion": "kibana", "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Expression Partition Visualization plugin adds a `partitionVis` renderer and `pieVis`, `mosaicVis`, `treemapVis`, `waffleVis` functions to the expression plugin. The renderer will display the `pie`, `waffle`, `treemap` and `mosaic` charts.", "server": true, diff --git a/src/plugins/chart_expressions/expression_tagcloud/kibana.json b/src/plugins/chart_expressions/expression_tagcloud/kibana.json index 20ed1ec360969f..b90c1f6e71c7ad 100755 --- a/src/plugins/chart_expressions/expression_tagcloud/kibana.json +++ b/src/plugins/chart_expressions/expression_tagcloud/kibana.json @@ -9,7 +9,7 @@ "optionalPlugins": ["usageCollection"], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Expression Tagcloud plugin adds a `tagcloud` renderer and function to the expression plugin. The renderer will display the `Wordcloud` chart." } diff --git a/src/plugins/chart_expressions/expression_xy/kibana.json b/src/plugins/chart_expressions/expression_xy/kibana.json index eebc9f1382b850..5c37e14072ed5c 100755 --- a/src/plugins/chart_expressions/expression_xy/kibana.json +++ b/src/plugins/chart_expressions/expression_xy/kibana.json @@ -4,7 +4,7 @@ "kibanaVersion": "kibana", "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Expression XY plugin adds a `xy` renderer and function to the expression plugin. The renderer will display the `xy` chart.", "server": true, diff --git a/src/plugins/charts/kibana.json b/src/plugins/charts/kibana.json index a3e0da41056d77..db8143b15f330e 100644 --- a/src/plugins/charts/kibana.json +++ b/src/plugins/charts/kibana.json @@ -7,6 +7,6 @@ "requiredPlugins": ["expressions"], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" } } diff --git a/src/plugins/event_annotation/kibana.json b/src/plugins/event_annotation/kibana.json index d981af8ab165b4..deccb699617bae 100644 --- a/src/plugins/event_annotation/kibana.json +++ b/src/plugins/event_annotation/kibana.json @@ -13,6 +13,6 @@ ], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" } } \ No newline at end of file diff --git a/src/plugins/management/kibana.json b/src/plugins/management/kibana.json index bf285cbbeadd34..c3659ce2232fac 100644 --- a/src/plugins/management/kibana.json +++ b/src/plugins/management/kibana.json @@ -7,6 +7,6 @@ "requiredBundles": ["kibanaReact", "kibanaUtils"], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" } } diff --git a/src/plugins/url_forwarding/kibana.json b/src/plugins/url_forwarding/kibana.json index 3e48cf73de5ef4..12132c2a096669 100644 --- a/src/plugins/url_forwarding/kibana.json +++ b/src/plugins/url_forwarding/kibana.json @@ -5,6 +5,6 @@ "ui": true, "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" } } diff --git a/src/plugins/vis_default_editor/kibana.json b/src/plugins/vis_default_editor/kibana.json index 7ae2321828a555..e5385724cf4a36 100644 --- a/src/plugins/vis_default_editor/kibana.json +++ b/src/plugins/vis_default_editor/kibana.json @@ -16,7 +16,7 @@ ], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "The default editor used in most aggregation-based visualizations." } diff --git a/src/plugins/vis_types/gauge/kibana.json b/src/plugins/vis_types/gauge/kibana.json index 428ee970c4e7f1..942fa032e1e0a2 100755 --- a/src/plugins/vis_types/gauge/kibana.json +++ b/src/plugins/vis_types/gauge/kibana.json @@ -23,7 +23,7 @@ ], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Contains the gauge chart implementation using the elastic-charts library. The goal is to eventually deprecate the old implementation and keep only this. Until then, the library used is defined by the Legacy charts library advanced setting." } \ No newline at end of file diff --git a/src/plugins/vis_types/heatmap/kibana.json b/src/plugins/vis_types/heatmap/kibana.json index b7f4a3bacbb906..077e9015b00af5 100644 --- a/src/plugins/vis_types/heatmap/kibana.json +++ b/src/plugins/vis_types/heatmap/kibana.json @@ -21,7 +21,7 @@ ], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Contains the heatmap implementation using the elastic-charts library. The goal is to eventually deprecate the old implementation and keep only this. Until then, the library used is defined by the Legacy heatmap charts library advanced setting." } \ No newline at end of file diff --git a/src/plugins/vis_types/metric/kibana.json b/src/plugins/vis_types/metric/kibana.json index 4d8f776d2a0bba..07b3586b950e00 100644 --- a/src/plugins/vis_types/metric/kibana.json +++ b/src/plugins/vis_types/metric/kibana.json @@ -17,7 +17,7 @@ ], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Registers the Metric aggregation-based visualization." } \ No newline at end of file diff --git a/src/plugins/vis_types/pie/kibana.json b/src/plugins/vis_types/pie/kibana.json index d9dca861e33be4..13bc61667dfd73 100644 --- a/src/plugins/vis_types/pie/kibana.json +++ b/src/plugins/vis_types/pie/kibana.json @@ -21,7 +21,7 @@ ], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Contains the pie chart implementation using the elastic-charts library. The goal is to eventually deprecate the old implementation and keep only this. Until then, the library used is defined by the Legacy charts library advanced setting." } \ No newline at end of file diff --git a/src/plugins/vis_types/table/kibana.json b/src/plugins/vis_types/table/kibana.json index d0ab6489ae61e5..ba8b90e7df337f 100644 --- a/src/plugins/vis_types/table/kibana.json +++ b/src/plugins/vis_types/table/kibana.json @@ -19,7 +19,7 @@ ], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Registers the datatable aggregation-based visualization." } diff --git a/src/plugins/vis_types/tagcloud/kibana.json b/src/plugins/vis_types/tagcloud/kibana.json index 67d57dec9f1fac..53e6141b9fb0da 100644 --- a/src/plugins/vis_types/tagcloud/kibana.json +++ b/src/plugins/vis_types/tagcloud/kibana.json @@ -7,7 +7,7 @@ "requiredBundles": ["kibanaReact", "visDefaultEditor"], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Registers the tagcloud visualization. It is based on elastic-charts wordcloud." diff --git a/src/plugins/vis_types/timelion/kibana.json b/src/plugins/vis_types/timelion/kibana.json index cf02808ec5c40e..584593d69a546f 100644 --- a/src/plugins/vis_types/timelion/kibana.json +++ b/src/plugins/vis_types/timelion/kibana.json @@ -9,7 +9,7 @@ "optionalPlugins": ["usageCollection"], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Registers the timelion visualization. Also contains the backend for both timelion app and timelion visualization." } diff --git a/src/plugins/vis_types/timeseries/kibana.json b/src/plugins/vis_types/timeseries/kibana.json index 049bd6beffd6f0..9ce16f65ec7538 100644 --- a/src/plugins/vis_types/timeseries/kibana.json +++ b/src/plugins/vis_types/timeseries/kibana.json @@ -9,7 +9,7 @@ "requiredBundles": ["unifiedSearch", "kibanaUtils", "kibanaReact", "fieldFormats"], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Registers the TSVB visualization. TSVB has its one editor, works with index patterns and index strings and contains 6 types of charts: timeseries, topN, table. markdown, metric and gauge." } diff --git a/src/plugins/vis_types/vega/kibana.json b/src/plugins/vis_types/vega/kibana.json index 5fbaabec722aa2..da5e8c40714020 100644 --- a/src/plugins/vis_types/vega/kibana.json +++ b/src/plugins/vis_types/vega/kibana.json @@ -8,7 +8,7 @@ "requiredBundles": ["kibanaUtils", "kibanaReact", "visDefaultEditor"], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Registers the vega visualization. Is the elastic version of vega and vega-lite libraries." } diff --git a/src/plugins/vis_types/vislib/kibana.json b/src/plugins/vis_types/vislib/kibana.json index 1f0a76bd364f8b..e12149bb5ab017 100644 --- a/src/plugins/vis_types/vislib/kibana.json +++ b/src/plugins/vis_types/vislib/kibana.json @@ -8,7 +8,7 @@ "requiredBundles": ["kibanaUtils", "visTypePie", "visTypeHeatmap", "visTypeGauge", "kibanaReact"], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Contains the vislib visualizations. These are the classical area/line/bar, pie, gauge/goal and heatmap charts. We want to replace them with elastic-charts." } diff --git a/src/plugins/vis_types/xy/kibana.json b/src/plugins/vis_types/xy/kibana.json index 474a70431fc73d..567c56fbcf9db9 100644 --- a/src/plugins/vis_types/xy/kibana.json +++ b/src/plugins/vis_types/xy/kibana.json @@ -8,7 +8,7 @@ "extraPublicDirs": ["common/index"], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Contains the new xy-axis chart using the elastic-charts library, which will eventually replace the vislib xy-axis charts including bar, area, and line." } diff --git a/src/plugins/visualizations/kibana.json b/src/plugins/visualizations/kibana.json index fc35feb51039cc..f650b85dd71e1a 100644 --- a/src/plugins/visualizations/kibana.json +++ b/src/plugins/visualizations/kibana.json @@ -25,7 +25,7 @@ "extraPublicDirs": ["common/constants", "common/utils", "common/expression_functions", "common/convert_to_lens"], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Contains the shared architecture among all the legacy visualizations, e.g. the visualization type registry or the visualization embeddable." } diff --git a/test/plugin_functional/plugins/kbn_tp_custom_visualizations/kibana.json b/test/plugin_functional/plugins/kbn_tp_custom_visualizations/kibana.json index 35be433601f45e..25be1386e52321 100644 --- a/test/plugin_functional/plugins/kbn_tp_custom_visualizations/kibana.json +++ b/test/plugin_functional/plugins/kbn_tp_custom_visualizations/kibana.json @@ -2,7 +2,7 @@ "id": "kbnTpCustomVisualizations", "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "version": "0.0.1", "kibanaVersion": "kibana", diff --git a/x-pack/examples/embedded_lens_example/kibana.json b/x-pack/examples/embedded_lens_example/kibana.json index dc979e21aeff57..735118211647d3 100644 --- a/x-pack/examples/embedded_lens_example/kibana.json +++ b/x-pack/examples/embedded_lens_example/kibana.json @@ -15,6 +15,6 @@ "requiredBundles": [], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" } } diff --git a/x-pack/examples/testing_embedded_lens/kibana.json b/x-pack/examples/testing_embedded_lens/kibana.json index febfc95bcecc25..2d4250165a1599 100644 --- a/x-pack/examples/testing_embedded_lens/kibana.json +++ b/x-pack/examples/testing_embedded_lens/kibana.json @@ -16,6 +16,6 @@ "requiredBundles": [], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" } } diff --git a/x-pack/examples/third_party_lens_navigation_prompt/kibana.json b/x-pack/examples/third_party_lens_navigation_prompt/kibana.json index 81af0557a92c66..76618ca62bfe14 100644 --- a/x-pack/examples/third_party_lens_navigation_prompt/kibana.json +++ b/x-pack/examples/third_party_lens_navigation_prompt/kibana.json @@ -17,6 +17,6 @@ ], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" } } diff --git a/x-pack/examples/third_party_vis_lens_example/kibana.json b/x-pack/examples/third_party_vis_lens_example/kibana.json index 858466f7f76404..9a00bf0750c6e0 100644 --- a/x-pack/examples/third_party_vis_lens_example/kibana.json +++ b/x-pack/examples/third_party_vis_lens_example/kibana.json @@ -19,6 +19,6 @@ ], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" } } diff --git a/x-pack/plugins/lens/kibana.json b/x-pack/plugins/lens/kibana.json index ad4475ed9faa80..56e1970cc764b6 100644 --- a/x-pack/plugins/lens/kibana.json +++ b/x-pack/plugins/lens/kibana.json @@ -53,7 +53,7 @@ ], "owner": { "name": "Vis Editors", - "githubTeam": "kibana-vis-editors" + "githubTeam": "kibana-visualizations" }, "description": "Visualization editor allowing to quickly and easily configure compelling visualizations to use on dashboards and canvas workpads. Exposes components to embed visualizations and link into the Lens editor from within other apps in Kibana." } diff --git a/x-pack/plugins/lens/readme.md b/x-pack/plugins/lens/readme.md index 4dbb303fe8090c..b01f19e4ee8ce5 100644 --- a/x-pack/plugins/lens/readme.md +++ b/x-pack/plugins/lens/readme.md @@ -31,7 +31,7 @@ When adding visualizations to a solution page, there are multiple ways to approa * Limited data processing options - if the Lens UI doesn't support it, it can't be used * Limited visualization options - if Lens can't do it, it's not possible * #### **Using custom data fetching and rendering** - In case the disadvantages of using the Lens embeddable heavily affect your use case, it sometimes makes sense to roll your own data fetching and rendering by using the underlying APIs of search service and `elastic-charts` directly. This allows a high degree of flexibility when it comes to data processing, efficiently querying data for multiple charts in a single query and adjusting small details in how charts are rendered. However, do not choose these option lightly as maintenance as well as initial development effort will most likely be much higher than by using the Lens embeddable directly. In this case, almost always an "Open in Lens" button can still be offered to the user to drill down and further explore the data by generating a Lens configuration which is similar to the displayed visualization given the possibilities of Lens. Keep in mind that for the "Open in Lens" flow, the most important property isn't perfect fidelity of the chart but retaining the mental context of the user when switching so they don't have to start over. It's also possible to mix this approach with Lens embeddables on a single page. **Note**: In this situation, please let the VisEditors team know what features you are missing / why you chose not to use Lens. + In case the disadvantages of using the Lens embeddable heavily affect your use case, it sometimes makes sense to roll your own data fetching and rendering by using the underlying APIs of search service and `elastic-charts` directly. This allows a high degree of flexibility when it comes to data processing, efficiently querying data for multiple charts in a single query and adjusting small details in how charts are rendered. However, do not choose these option lightly as maintenance as well as initial development effort will most likely be much higher than by using the Lens embeddable directly. In this case, almost always an "Open in Lens" button can still be offered to the user to drill down and further explore the data by generating a Lens configuration which is similar to the displayed visualization given the possibilities of Lens. Keep in mind that for the "Open in Lens" flow, the most important property isn't perfect fidelity of the chart but retaining the mental context of the user when switching so they don't have to start over. It's also possible to mix this approach with Lens embeddables on a single page. **Note**: In this situation, please let the Visualizations team know what features you are missing / why you chose not to use Lens. Pros: * Full flexibility in data fetching optimization and chart rendering