From f94820e63831054b7f3c1c65f889f18a9c808d30 Mon Sep 17 00:00:00 2001 From: Ryan Schmukler Date: Sun, 21 Jun 2015 17:33:02 -0400 Subject: [PATCH] fix(menu): fix error on clicking on menu container element closes #3252, closes #3369 --- src/components/menu/menu-interim-element.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/menu/menu-interim-element.js b/src/components/menu/menu-interim-element.js index 0cb508b0d26..d2b523f6795 100644 --- a/src/components/menu/menu-interim-element.js +++ b/src/components/menu/menu-interim-element.js @@ -148,13 +148,14 @@ function MenuProvider($$interimElementProvider) { // Traverse up the event until we get to the menuContentEl to see if // there is an ng-click and that the ng-click is not disabled do { + if (target == opts.menuContentEl[0]) return; if (hasAnyAttribute(target, ['ng-click', 'data-ng-click', 'x-ng-click'])) { if (!target.hasAttribute('disabled')) { close(); } break; } - } while ((target = target.parentNode) && target != opts.menuContentEl) + } while (target = target.parentNode) function close() { scope.$apply(function() {