From fbdd8554730b8c1f61b8d26a0871f7c310f26b05 Mon Sep 17 00:00:00 2001 From: Chris Lenfest Date: Wed, 22 May 2024 16:26:50 -0500 Subject: [PATCH 1/2] Add changeset for #3014 --- .changeset/quick-zebras-wave.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/quick-zebras-wave.md diff --git a/.changeset/quick-zebras-wave.md b/.changeset/quick-zebras-wave.md new file mode 100644 index 000000000..173efbe74 --- /dev/null +++ b/.changeset/quick-zebras-wave.md @@ -0,0 +1,7 @@ +--- +"@apollo/query-graphs": patch +--- + + Fix bug in context-matching logic for interfaces-implementing-interfaces (#3014) + + A field is considered to match a context if the field's parent type (in the original query) either has `@context` on it, or implements/is a member of a type with `@context` on it. We ended up missing the case where interfaces implement interfaces; this PR introduces a fix. From 1d7e9184b1e7c930584839fa869a42d8adadf4f0 Mon Sep 17 00:00:00 2001 From: Chris Lenfest Date: Wed, 22 May 2024 16:29:19 -0500 Subject: [PATCH 2/2] formatting --- .changeset/quick-zebras-wave.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.changeset/quick-zebras-wave.md b/.changeset/quick-zebras-wave.md index 173efbe74..37a5838e5 100644 --- a/.changeset/quick-zebras-wave.md +++ b/.changeset/quick-zebras-wave.md @@ -2,6 +2,6 @@ "@apollo/query-graphs": patch --- - Fix bug in context-matching logic for interfaces-implementing-interfaces (#3014) +Fix bug in context-matching logic for interfaces-implementing-interfaces (#3014) - A field is considered to match a context if the field's parent type (in the original query) either has `@context` on it, or implements/is a member of a type with `@context` on it. We ended up missing the case where interfaces implement interfaces; this PR introduces a fix. +A field is considered to match a context if the field's parent type (in the original query) either has `@context` on it, or implements/is a member of a type with `@context` on it. We ended up missing the case where interfaces implement interfaces; this PR introduces a fix.