From 241781539313929ae7155bfdc1557f60a3b145b7 Mon Sep 17 00:00:00 2001
From: Damian Ho <damian_ho_xu_yang@yahoo.com>
Date: Wed, 15 Nov 2023 16:59:12 -0500
Subject: [PATCH] Don't clear assessment penalty fields on initial load (#2006)

* Don't clear on initial load

* Remove extraneous spaces
---
 app/assets/javascripts/edit_assessment.js | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/app/assets/javascripts/edit_assessment.js b/app/assets/javascripts/edit_assessment.js
index 54d63e2c..76994a33 100644
--- a/app/assets/javascripts/edit_assessment.js
+++ b/app/assets/javascripts/edit_assessment.js
@@ -55,13 +55,15 @@
     });
 
     // Penalties tab
+    let initial_load = true; // determines if the page is loading for the first time, if so, don't clear the fields
+
     function unlimited_submissions_callback() {
       const checked = $(this).prop('checked');
       const $max_submissions = $('#assessment_max_submissions');
       $max_submissions.prop('disabled', checked);
       if (checked) {
         $max_submissions.val('Unlimited submissions');
-      } else {
+      } else if (!initial_load) {
         $max_submissions.val('');
       }
     }
@@ -73,7 +75,7 @@
       $max_grace_days.prop('disabled', checked);
       if (checked) {
         $max_grace_days.val('Unlimited grace days');
-      } else {
+      } else if (!initial_load) {
         $max_grace_days.val('');
       }
     }
@@ -87,7 +89,7 @@
       $latePenaltyField.find('select').prop('disabled', checked);
       if (checked) {
         $latePenaltyValue.val('Course default');
-      } else {
+      } else if (!initial_load) {
         $latePenaltyValue.val('');
       }
     }
@@ -99,7 +101,7 @@
       $version_threshold.prop('disabled', checked);
       if (checked) {
         $version_threshold.val('Course default');
-      } else {
+      } else if (!initial_load) {
         $version_threshold.val('');
       }
     }
@@ -113,7 +115,7 @@
       $versionPenaltyField.find('select').prop('disabled', checked);
       if (checked) {
         $versionPenaltyValue.val('Course default');
-      } else {
+      } else if (!initial_load) {
         $versionPenaltyValue.val('');
       }
     }
@@ -125,6 +127,7 @@
     use_default_late_penalty_callback.call($('#use_default_late_penalty'));
     use_default_version_threshold_callback.call($('#use_default_version_threshold'));
     use_default_version_penalty_callback.call($('#use_default_version_penalty'));
+    initial_load = false;
   });
 
 })();