From 1db7f5a412fa5c1515b3aecf36d797a8e5cddf55 Mon Sep 17 00:00:00 2001
From: MaxGenash <max.henash@bigcommerce.com>
Date: Mon, 17 Aug 2020 19:08:10 +0300
Subject: [PATCH] refactor: strf-8606; removed unused modules "good",
 "good-console"

---
 package-lock.json  | 64 ++++------------------------------------------
 package.json       |  2 --
 server/config.js   | 12 ---------
 server/manifest.js |  1 -
 4 files changed, 5 insertions(+), 74 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index ed6644f3..8fee56ed 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -2044,56 +2044,6 @@
         }
       }
     },
-    "@hapi/good": {
-      "version": "8.2.4",
-      "resolved": "https://registry.npmjs.org/@hapi/good/-/good-8.2.4.tgz",
-      "integrity": "sha512-Paj7BX4C295I+opJ5eIV0XvLhRPcKDLpP9RsnUWGXH/gLRi1SwVMOCYAqitSBjhYSIeZoq+jMmJn6+hUg4W3ug==",
-      "requires": {
-        "@hapi/hoek": "8.x.x",
-        "@hapi/joi": "16.x.x",
-        "@hapi/oppsy": "2.x.x",
-        "pumpify": "1.x.x"
-      },
-      "dependencies": {
-        "@hapi/joi": {
-          "version": "16.1.8",
-          "resolved": "https://registry.npmjs.org/@hapi/joi/-/joi-16.1.8.tgz",
-          "integrity": "sha512-wAsVvTPe+FwSrsAurNt5vkg3zo+TblvC5Bb1zMVK6SJzZqw9UrJnexxR+76cpePmtUZKHAPxcQ2Bf7oVHyahhg==",
-          "requires": {
-            "@hapi/address": "^2.1.2",
-            "@hapi/formula": "^1.2.0",
-            "@hapi/hoek": "^8.2.4",
-            "@hapi/pinpoint": "^1.0.2",
-            "@hapi/topo": "^3.1.3"
-          }
-        }
-      }
-    },
-    "@hapi/good-console": {
-      "version": "8.1.2",
-      "resolved": "https://registry.npmjs.org/@hapi/good-console/-/good-console-8.1.2.tgz",
-      "integrity": "sha512-35Uxe7+EsPsbhjQXrhCGB5Ul0W51CxYBBjN7JC95RZnFiB2DAt52pXLZ6aagUPk8yA/DM2OmIsmWJBr+N28hLw==",
-      "requires": {
-        "@hapi/hoek": "8.x.x",
-        "@hapi/joi": "16.x.x",
-        "json-stringify-safe": "5.x.x",
-        "moment": "2.x.x"
-      },
-      "dependencies": {
-        "@hapi/joi": {
-          "version": "16.1.8",
-          "resolved": "https://registry.npmjs.org/@hapi/joi/-/joi-16.1.8.tgz",
-          "integrity": "sha512-wAsVvTPe+FwSrsAurNt5vkg3zo+TblvC5Bb1zMVK6SJzZqw9UrJnexxR+76cpePmtUZKHAPxcQ2Bf7oVHyahhg==",
-          "requires": {
-            "@hapi/address": "^2.1.2",
-            "@hapi/formula": "^1.2.0",
-            "@hapi/hoek": "^8.2.4",
-            "@hapi/pinpoint": "^1.0.2",
-            "@hapi/topo": "^3.1.3"
-          }
-        }
-      }
-    },
     "@hapi/h2o2": {
       "version": "8.3.2",
       "resolved": "https://registry.npmjs.org/@hapi/h2o2/-/h2o2-8.3.2.tgz",
@@ -2642,14 +2592,6 @@
         }
       }
     },
-    "@hapi/oppsy": {
-      "version": "2.1.2",
-      "resolved": "https://registry.npmjs.org/@hapi/oppsy/-/oppsy-2.1.2.tgz",
-      "integrity": "sha512-V/KNuFemyA//sowFFpeMRY4zE6szuy8vh6v2vWDPDhZFowOIwB7kqdFvmnBogk+aHHR+iKgKCU/SuUiv/xZyzg==",
-      "requires": {
-        "@hapi/hoek": "8.x.x"
-      }
-    },
     "@hapi/pinpoint": {
       "version": "1.0.2",
       "resolved": "https://registry.npmjs.org/@hapi/pinpoint/-/pinpoint-1.0.2.tgz",
@@ -8392,6 +8334,7 @@
       "version": "3.7.1",
       "resolved": "https://registry.npmjs.org/duplexify/-/duplexify-3.7.1.tgz",
       "integrity": "sha512-07z8uv2wMyS51kKhD1KsdXJg5WQ6t93RneqRxUHnskXVtlYYkLqM0gqStQZ3pj073g687jPCHrqNfCzawLYh5g==",
+      "dev": true,
       "requires": {
         "end-of-stream": "^1.0.0",
         "inherits": "^2.0.1",
@@ -18338,6 +18281,7 @@
       "version": "2.0.1",
       "resolved": "https://registry.npmjs.org/pump/-/pump-2.0.1.tgz",
       "integrity": "sha512-ruPMNRkN3MHP1cWJc9OWr+T/xDP0jhXYCLfJcBuX54hhfIBnaQmAUMfDcG4DM5UMWByBbJY69QSphm3jtDKIkA==",
+      "dev": true,
       "requires": {
         "end-of-stream": "^1.1.0",
         "once": "^1.3.1"
@@ -18347,6 +18291,7 @@
       "version": "1.5.1",
       "resolved": "https://registry.npmjs.org/pumpify/-/pumpify-1.5.1.tgz",
       "integrity": "sha512-oClZI37HvuUJJxSKKrC17bZ9Cu0ZYhEAGPsPUy9KlMUmv9dKX2o77RUmq7f3XjIxbwyGwYzbzQ1L2Ks8sIradQ==",
+      "dev": true,
       "requires": {
         "duplexify": "^3.6.0",
         "inherits": "^2.0.3",
@@ -20517,7 +20462,8 @@
     "stream-shift": {
       "version": "1.0.1",
       "resolved": "https://registry.npmjs.org/stream-shift/-/stream-shift-1.0.1.tgz",
-      "integrity": "sha512-AiisoFqQ0vbGcZgQPY1cdP2I76glaVA/RauYR4G4thNFgkTqr90yXTo4LYX60Jl+sIlPNHHdGSwo01AvbKUSVQ=="
+      "integrity": "sha512-AiisoFqQ0vbGcZgQPY1cdP2I76glaVA/RauYR4G4thNFgkTqr90yXTo4LYX60Jl+sIlPNHHdGSwo01AvbKUSVQ==",
+      "dev": true
     },
     "stream-throttle": {
       "version": "0.1.3",
diff --git a/package.json b/package.json
index e881104a..30b06662 100644
--- a/package.json
+++ b/package.json
@@ -38,8 +38,6 @@
     "@octokit/rest": "^18.0.3",
     "@hapi/boom": "^8.0.1",
     "@hapi/glue": "^6.2.0",
-    "@hapi/good": "^8.2.4",
-    "@hapi/good-console": "^8.1.2",
     "@hapi/h2o2": "^8.3.2",
     "@hapi/hapi": "^18.4.1",
     "@hapi/inert": "^5.2.2",
diff --git a/server/config.js b/server/config.js
index 6312d867..58a2a931 100644
--- a/server/config.js
+++ b/server/config.js
@@ -1,7 +1,6 @@
 'use strict';
 
 const Confidence = require('confidence');
-const GoodConsole = require('@hapi/good-console');
 
 const config = {
     $meta: 'Config file',
@@ -9,17 +8,6 @@ const config = {
         host: 'localhost',
         port: 3000,
     },
-    good: {
-        ops: {
-            interval: 1000,
-        },
-        reporters: {
-            goodConsoleReporter: [{
-                module: GoodConsole,
-                args: [{log: '*', request: '*'}],
-            }],
-        },
-    },
 };
 
 const criteria = {
diff --git a/server/manifest.js b/server/manifest.js
index 188f803b..f2fa5dc4 100644
--- a/server/manifest.js
+++ b/server/manifest.js
@@ -14,7 +14,6 @@ const manifest = {
     register: {
         plugins: {
             // Third Party Plugins
-            '@hapi/good': config.get('/good'),
             '@hapi/inert': {},
             '@hapi/h2o2': {},
             // First Party Plugins