From 48c1f301a02628a363410dfd5a23b5e4e2bfa3e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D0=91=D1=80=D0=B0=D0=BD=D0=B8=D0=BC=D0=B8=D1=80=20=D0=9A?=
 =?UTF-8?q?=D0=B0=D1=80=D0=B0=D1=9F=D0=B8=D1=9B?=
 <branimirkaradzic@gmail.com>
Date: Mon, 2 Jan 2023 20:28:30 -0800
Subject: [PATCH] Provide type trait struct for use in template arguments to
 make MSVC happy.

---
 include/bx/inline/typetraits.inl | 200 ++++++++++++++++++++++---------
 1 file changed, 142 insertions(+), 58 deletions(-)

diff --git a/include/bx/inline/typetraits.inl b/include/bx/inline/typetraits.inl
index 3af6a0514..c1ecb404f 100644
--- a/include/bx/inline/typetraits.inl
+++ b/include/bx/inline/typetraits.inl
@@ -114,7 +114,6 @@ namespace bx
 	template<typename Ty>  using RemoveVolatileType = typename RemoveVolatileT<Ty>::Type;
 
 	//---
-
 	template<typename Ty>               struct IsBoundedArrayT            : FalseConstant {};
 	template<typename Ty, size_t SizeT> struct IsBoundedArrayT<Ty[SizeT]> :  TrueConstant {};
 
@@ -124,6 +123,7 @@ namespace bx
 		return IsBoundedArrayT<Ty>::value;
 	}
 
+	//---
 	template<typename Ty> struct IsUnboundedArrayT       : FalseConstant {};
 	template<typename Ty> struct IsUnboundedArrayT<Ty[]> :  TrueConstant {};
 
@@ -133,194 +133,255 @@ namespace bx
 		return IsUnboundedArrayT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsArrayT : public BoolConstantT<false
+		|| IsBoundedArrayT<Ty>::value
+		|| IsUnboundedArrayT<Ty>::value
+	> {};
+
 	template<typename Ty>
 	inline constexpr bool isArray()
 	{
-		return isBoundedArray<Ty>()
-			|| isUnboundedArray<Ty>()
-			;
+		return IsArrayT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsEnumT : public BoolConstantT<__is_enum(Ty)> {};
+
 	template<typename Ty>
 	inline constexpr bool isEnum()
 	{
-		return !!__is_enum(Ty);
+		return IsEnumT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsUnionT : public BoolConstantT<__is_union(Ty)> {};
+
 	template<typename Ty>
 	inline constexpr bool isUnion()
 	{
-		return !!__is_union(Ty);
+		return IsUnionT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsAbstractT : public BoolConstantT<__is_abstract(Ty)> {};
+
 	template<typename Ty>
 	inline constexpr bool isAbstract()
 	{
-		return !!__is_abstract(Ty);
+		return IsAbstractT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsAggregateT : public BoolConstantT<__is_aggregate(Ty)> {};
+
 	template<typename Ty>
 	inline constexpr bool isAggregate()
 	{
-		return !!__is_aggregate(Ty);
+		return IsAggregateT<Ty>::value;
 	}
 
+	//---
+	template<typename BaseT, typename DerivedT> struct IsBaseOfT : public BoolConstantT<__is_base_of(BaseT, DerivedT)> {};
+
 	template<typename BaseT, typename DerivedT>
 	inline constexpr bool isBaseOf()
 	{
-		return !!__is_base_of(BaseT, DerivedT);
+		return IsBaseOfT<BaseT, DerivedT>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsPolymorphicT : public BoolConstantT<__is_polymorphic(Ty)> {};
+
 	template<typename Ty>
 	inline constexpr bool isPolymorphic()
 	{
-		return !!__is_polymorphic(Ty);
+		return IsPolymorphicT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsDestructorVirtualT : public BoolConstantT<__has_virtual_destructor(Ty)> {};
+
 	template<typename Ty>
 	inline constexpr bool isDestructorVirtual()
 	{
-		return __has_virtual_destructor(Ty);
+		return IsDestructorVirtualT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsClassT : public BoolConstantT<__is_class(Ty)> {};
+
 	template<typename Ty>
 	inline constexpr bool isClass()
 	{
-		return !!__is_class(Ty);
+		return IsClassT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsFinalT : public BoolConstantT<__is_final(Ty)> {};
+
 	template<typename Ty>
 	inline constexpr bool isFinal()
 	{
-		return !!__is_final(Ty);
+		return IsFinalT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsEmptyT : public BoolConstantT<__is_empty(Ty)> {};
+
 	template<typename Ty>
 	inline constexpr bool isEmpty()
 	{
-		return !!__is_empty(Ty);
+		return IsEmptyT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsStandardLayoutT : public BoolConstantT<__is_standard_layout(Ty)> {};
+
 	template<typename Ty>
 	inline constexpr bool isStandardLayout()
 	{
-		return !!__is_standard_layout(Ty);
+		return IsStandardLayoutT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsTrivialT : public BoolConstantT<__is_trivial(Ty)> {};
+
 	template<typename Ty>
 	inline constexpr bool isTrivial()
 	{
-		return !!__is_trivial(Ty);
+		return IsTrivialT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsPodT : public BoolConstantT<true
+		&& IsStandardLayoutT<Ty>::value
+		&& IsTrivialT<Ty>::value
+	> {};
+
 	template<typename Ty>
 	inline constexpr bool isPod()
 	{
-		return isStandardLayout<Ty>()
-			&& isTrivial<Ty>()
-			;
+		return IsPodT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty, typename FromT> struct IsAssignableT     : public BoolConstantT<__is_assignable(Ty, FromT)> {};
+	template<typename Ty>                 struct IsCopyAssignableT : public IsAssignableT<AddLvalueReferenceType<Ty>, AddRvalueReferenceType<const Ty>> {};
+	template<typename Ty>                 struct IsMoveAssignableT : public IsAssignableT<AddLvalueReferenceType<Ty>, AddRvalueReferenceType<Ty>> {};
+
 	template<typename Ty, typename FromT>
 	inline constexpr bool isAssignable()
 	{
-		return !!__is_assignable(Ty, FromT);
+		return IsAssignableT<Ty, FromT>::value;
 	}
 
 	template<typename Ty>
 	inline constexpr bool isCopyAssignable()
 	{
-		return isAssignable<
-				  AddLvalueReferenceType<Ty>
-				, AddLvalueReferenceType<const Ty>
-				>();
+		return IsCopyAssignableT<Ty>::value;
 	}
 
 	template<typename Ty>
 	inline constexpr bool isMoveAssignable()
 	{
-		return isAssignable<
-				  AddLvalueReferenceType<Ty>
-				, AddRvalueReferenceType<Ty>
-				>();
+		return IsMoveAssignableT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty, typename FromT> struct IsTriviallyAssignableT     : public BoolConstantT<__is_trivially_assignable(Ty, FromT)>                                  {};
+	template<typename Ty>                 struct IsTriviallyCopyAssignableT : public IsTriviallyAssignableT<AddLvalueReferenceType<Ty>, AddRvalueReferenceType<const Ty>> {};
+	template<typename Ty>                 struct IsTriviallyMoveAssignableT : public IsTriviallyAssignableT<AddLvalueReferenceType<Ty>, AddRvalueReferenceType<Ty>>       {};
+
 	template<typename Ty, typename FromT>
 	inline constexpr bool isTriviallyAssignable()
 	{
-		return !!__is_trivially_assignable(Ty, FromT);
+		return IsTriviallyAssignableT<Ty, FromT>::value;
 	}
 
 	template<typename Ty>
 	inline constexpr bool isTriviallyCopyAssignable()
 	{
-		return isTriviallyAssignable<
-				  AddLvalueReferenceType<Ty>
-				, AddRvalueReferenceType<const Ty>
-				>();
+		return IsTriviallyCopyAssignableT<Ty>::value;
 	}
 
 	template<typename Ty>
 	inline constexpr bool isTriviallyMoveAssignable()
 	{
-		return isTriviallyAssignable<
-				  AddLvalueReferenceType<Ty>
-				, AddRvalueReferenceType<Ty>
-				>();
+		return IsTriviallyMoveAssignableT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty, typename... ArgsT> struct IsConstructibleT     : public BoolConstantT<__is_constructible(Ty, ArgsT...)>  {};
+	template<typename Ty>                    struct IsCopyConstructibleT : public IsConstructibleT<Ty, AddLvalueReferenceType<Ty>> {};
+	template<typename Ty>                    struct IsMoveConstructibleT : public IsConstructibleT<Ty, AddRvalueReferenceType<Ty>> {};
+
 	template<typename Ty, typename... ArgsT>
 	inline constexpr bool isConstructible()
 	{
-		return !!__is_constructible(Ty, ArgsT...);
+		return IsConstructibleT<Ty, ArgsT...>::value;
 	}
 
 	template<typename Ty>
 	inline constexpr bool isCopyConstructible()
 	{
-		return isConstructible<Ty, AddLvalueReferenceType<Ty>>();
+		return IsCopyConstructibleT<Ty>::value;
 	}
 
 	template<typename Ty>
 	inline constexpr bool isMoveConstructible()
 	{
-		return isConstructible<Ty, AddRvalueReferenceType<Ty>>();
+		return IsMoveConstructibleT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty, typename... ArgsT> struct IsTriviallyConstructibleT     : public BoolConstantT<__is_trivially_constructible(Ty, ArgsT...)> {};
+	template<typename Ty>                    struct IsTriviallyCopyConstructibleT : public IsTriviallyConstructibleT<Ty, AddLvalueReferenceType<Ty>>  {};
+	template<typename Ty>                    struct IsTriviallyMoveConstructibleT : public IsTriviallyConstructibleT<Ty, AddRvalueReferenceType<Ty>>  {};
+
 	template<typename Ty, typename... ArgsT>
-	inline constexpr bool isTriviallyConstructible()
+	constexpr bool isTriviallyConstructible()
 	{
-		return !!__is_trivially_constructible(Ty, ArgsT...);
+		return IsTriviallyConstructibleT<Ty, ArgsT...>::value;
 	}
 
 	template<typename Ty>
 	inline constexpr bool isTriviallyCopyConstructible()
 	{
-		return isTriviallyConstructible<Ty, AddLvalueReferenceType<Ty>>();
+		return IsTriviallyCopyConstructibleT<Ty>::value;
 	}
 
 	template<typename Ty>
 	inline constexpr bool isTriviallyMoveConstructible()
 	{
-		return isTriviallyConstructible<Ty, AddRvalueReferenceType<Ty>>();
+		return IsTriviallyMoveConstructibleT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsTriviallyCopyableT : public BoolConstantT<__is_trivially_copyable(Ty)> {};
+
 	template<typename Ty>
 	inline constexpr bool isTriviallyCopyable()
 	{
-		return !!__is_trivially_copyable(Ty);
+		return IsTriviallyCopyableT<Ty>::value;
 	}
 
-	template<typename Ty>
-	inline constexpr bool isTriviallyDestructible()
-	{
+	//---
+	template<typename Ty> struct IsTriviallyDestructibleT : public BoolConstantT<
 #if BX_COMPILER_GCC
-		return !!__has_trivial_destructor(Ty);
+		__has_trivial_destructor(Ty)
 #else
-		return !!__is_trivially_destructible(Ty);
+		__is_trivially_destructible(Ty)
 #endif // BX_COMPILER_GCC
+	> {};
+
+	template<typename Ty>
+	inline constexpr bool isTriviallyDestructible()
+	{
+		return IsTriviallyDestructibleT<Ty>::value;
 	}
 
+	//---
 	template<typename Ty> struct IsConstT           : FalseConstant {};
 	template<typename Ty> struct IsConstT<const Ty> :  TrueConstant {};
 
@@ -330,6 +391,7 @@ namespace bx
 		return IsConstT<Ty>::value;
 	}
 
+	//---
 	template<typename Ty> struct IsVolatileT              : FalseConstant {};
 	template<typename Ty> struct IsVolatileT<volatile Ty> :  TrueConstant {};
 
@@ -339,6 +401,7 @@ namespace bx
 		return IsVolatileT<Ty>::value;
 	}
 
+	//---
 	template<typename Ty> struct IsLvalueReferenceT      : FalseConstant {};
 	template<typename Ty> struct IsLvalueReferenceT<Ty&> :  TrueConstant {};
 
@@ -348,6 +411,7 @@ namespace bx
 		return IsLvalueReferenceT<Ty>::value;
 	}
 
+	//---
 	template<typename Ty> struct IsRvalueReferenceT       : FalseConstant {};
 	template<typename Ty> struct IsRvalueReferenceT<Ty&&> :  TrueConstant {};
 
@@ -357,14 +421,19 @@ namespace bx
 		return IsRvalueReferenceT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsReferenceT : public BoolConstantT<false
+		|| IsLvalueReferenceT<Ty>::value
+		|| IsRvalueReferenceT<Ty>::value
+	> {};
+
 	template<typename Ty>
 	inline constexpr bool isReference()
 	{
-		return isLvalueReference<Ty>()
-			|| isRvalueReference<Ty>()
-			;
+		return IsReferenceT<Ty>::value;
 	}
 
+	//---
 	template<typename Ty> struct IsPointerT                     : FalseConstant {};
 	template<typename Ty> struct IsPointerT<Ty*>                :  TrueConstant {};
 	template<typename Ty> struct IsPointerT<Ty* const>          :  TrueConstant {};
@@ -377,18 +446,25 @@ namespace bx
 		return IsPointerT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsSignedT : public BoolConstantT<Ty(-1) < Ty(0)> {};
+
 	template<typename Ty>
 	inline constexpr bool isSigned()
 	{
-		return Ty(-1) < Ty(0);
+		return IsSignedT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsUnsignedT : public BoolConstantT<Ty(0) < Ty(-1)> {};
+
 	template<typename Ty>
 	inline constexpr bool isUnsigned()
 	{
-		return Ty(-1) > Ty(0);
+		return IsUnsignedT<Ty>::value;
 	}
 
+	//---
 	template<typename Ty> struct IsIntegerT                     : FalseConstant {};
 	template<>            struct IsIntegerT<bool              > :  TrueConstant {};
 	template<>            struct IsIntegerT<char              > :  TrueConstant {};
@@ -412,6 +488,7 @@ namespace bx
 		return IsIntegerT<Ty>::value;
 	}
 
+	//---
 	template<typename Ty> struct IsFloatingPointT              : FalseConstant {};
 	template<>            struct IsFloatingPointT<float      > :  TrueConstant {};
 	template<>            struct IsFloatingPointT<     double> :  TrueConstant {};
@@ -423,14 +500,20 @@ namespace bx
 		return IsFloatingPointT<Ty>::value;
 	}
 
+	//---
+	template<typename Ty> struct IsArithmeticT : BoolConstantT<false
+		|| IsIntegerT<Ty>::value
+		|| IsFloatingPointT<Ty>::value
+	>
+	{};
+
 	template<typename Ty>
 	inline constexpr bool isArithmetic()
 	{
-		return isInteger<Ty>()
-			|| isFloatingPoint<Ty>()
-			;
+		return IsArithmeticT<Ty>::value;
 	}
 
+	//---
 	template<typename Ty, typename Uy> struct IsSameT         : FalseConstant {};
 	template<typename Ty>              struct IsSameT<Ty, Ty> :  TrueConstant {};
 
@@ -440,6 +523,7 @@ namespace bx
 		return IsSameT<Ty, Uy>::value;
 	}
 
+	//---
 	template<typename Ty>
 	inline constexpr RemoveReferenceType<Ty>&& move(Ty&& _a)
 	{