From e93543983c74852cb7587870a4d629cf438e485c Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Fri, 27 Nov 2020 22:45:31 +1300 Subject: [PATCH 01/16] Follow Jeremy's wild speculation --- core/dbt/contracts/graph/unparsed.py | 2 +- core/dbt/node_types.py | 1 + core/dbt/parser/manifest.py | 14 ++++++++++++++ 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/core/dbt/contracts/graph/unparsed.py b/core/dbt/contracts/graph/unparsed.py index 57da34f4a24..693ab57516a 100644 --- a/core/dbt/contracts/graph/unparsed.py +++ b/core/dbt/contracts/graph/unparsed.py @@ -411,7 +411,7 @@ class ExposureOwner(JsonSchemaMixin, Replaceable): @dataclass -class UnparsedExposure(JsonSchemaMixin, Replaceable): +class UnparsedExposure(HasYamlMetadata, Replaceable): name: str type: ExposureType owner: ExposureOwner diff --git a/core/dbt/node_types.py b/core/dbt/node_types.py index 8ba6d5900ea..e6502ca7030 100644 --- a/core/dbt/node_types.py +++ b/core/dbt/node_types.py @@ -46,6 +46,7 @@ def documentable(cls) -> List['NodeType']: cls.Source, cls.Macro, cls.Analysis, + cls.Exposure ] def pluralize(self) -> str: diff --git a/core/dbt/parser/manifest.py b/core/dbt/parser/manifest.py index 9af7f7d6635..5b9928786a4 100644 --- a/core/dbt/parser/manifest.py +++ b/core/dbt/parser/manifest.py @@ -622,6 +622,12 @@ def _process_docs_for_macro( arg.description = get_rendered(arg.description, context) +def _process_docs_for_exposure( + context: Dict[str, Any], exposure: ParsedExposure +) -> None: + exposure.description = get_rendered(exposure.description, context) + + def process_docs(manifest: Manifest, config: RuntimeConfig): for node in manifest.nodes.values(): ctx = generate_runtime_docs( @@ -647,6 +653,14 @@ def process_docs(manifest: Manifest, config: RuntimeConfig): config.project_name, ) _process_docs_for_macro(ctx, macro) + for exposure in manifest.exposures.values(): + ctx = generate_runtime_docs( + config, + exposure, + manifest, + config.project_name, + ) + _process_docs_for_exposure(ctx, exposure) def _process_refs_for_exposure( From 8db2d674ed5ff2c3bbe6baac141fc50a9d721b59 Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Sat, 28 Nov 2020 15:08:13 +1300 Subject: [PATCH 02/16] Update CHANGELOG.md --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 724ba5b9e8a..e1677a1430a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ - Widen supported Google Cloud libraries dependencies ([#2794](https://github.com/fishtown-analytics/dbt/pull/2794), [#2877](https://github.com/fishtown-analytics/dbt/pull/2877)). - dbt list command always return 0 as exit code ([#2886](https://github.com/fishtown-analytics/dbt/issues/2886), [#2892](https://github.com/fishtown-analytics/dbt/issues/2892)) - Set default `materialized` for test node configs to `test` ([#2806](https://github.com/fishtown-analytics/dbt/issues/2806), [#2902](https://github.com/fishtown-analytics/dbt/pull/2902)) +- Allow docs blocks in exposure descriptions ([#2913](https://github.com/fishtown-analytics/dbt/issues/2913), [#2920](https://github.com/fishtown-analytics/dbt/pull/2920)) ### Under the hood - Bump hologram version to 0.0.11. Add scripts/dtr.py ([#2888](https://github.com/fishtown-analytics/dbt/issues/2840),[#2889](https://github.com/fishtown-analytics/dbt/pull/2889)) @@ -29,6 +30,7 @@ Contributors: - [@franloza](https://github.com/franloza) ([#2837](https://github.com/fishtown-analytics/dbt/pull/2837)) - [@max-sixty](https://github.com/max-sixty) ([#2877](https://github.com/fishtown-analytics/dbt/pull/2877)) - [@rsella](https://github.com/rsella) ([#2892](https://github.com/fishtown-analytics/dbt/issues/2892)) +- [@joellabes](https://github.com/joellabes) ([#2913](https://github.com/fishtown-analytics/dbt/issues/2913)) ## dbt 0.19.0b1 (October 21, 2020) From c8721ded62ca0b542c5ad191771a74ec4ad4a3d1 Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Mon, 30 Nov 2020 20:29:47 +1300 Subject: [PATCH 03/16] Code review: non-optional description, docs block tests, yaml exposure attributes --- core/dbt/contracts/graph/unparsed.py | 2 +- .../ref_models/docs.md | 4 +++ .../ref_models/schema.yml | 13 +++++++++ .../test_docs_generate.py | 27 ++++++++++++++++++- test/unit/test_contracts_graph_unparsed.py | 8 +++++- 5 files changed, 51 insertions(+), 3 deletions(-) diff --git a/core/dbt/contracts/graph/unparsed.py b/core/dbt/contracts/graph/unparsed.py index 693ab57516a..26af41e244c 100644 --- a/core/dbt/contracts/graph/unparsed.py +++ b/core/dbt/contracts/graph/unparsed.py @@ -413,9 +413,9 @@ class ExposureOwner(JsonSchemaMixin, Replaceable): @dataclass class UnparsedExposure(HasYamlMetadata, Replaceable): name: str + description: str = '' type: ExposureType owner: ExposureOwner maturity: Optional[MaturityType] = None url: Optional[str] = None - description: Optional[str] = None depends_on: List[str] = field(default_factory=list) diff --git a/test/integration/029_docs_generate_tests/ref_models/docs.md b/test/integration/029_docs_generate_tests/ref_models/docs.md index 1918e825b44..c5ad96862c6 100644 --- a/test/integration/029_docs_generate_tests/ref_models/docs.md +++ b/test/integration/029_docs_generate_tests/ref_models/docs.md @@ -25,3 +25,7 @@ My table {% docs column_info %} An ID field {% enddocs %} + +{% docs notebook_info %} +A description of the complex exposure +{% enddocs %} diff --git a/test/integration/029_docs_generate_tests/ref_models/schema.yml b/test/integration/029_docs_generate_tests/ref_models/schema.yml index 3cc4c7aac10..ab20ba02463 100644 --- a/test/integration/029_docs_generate_tests/ref_models/schema.yml +++ b/test/integration/029_docs_generate_tests/ref_models/schema.yml @@ -29,3 +29,16 @@ sources: columns: - name: id description: "{{ doc('column_info') }}" + +exposures: + - name: notebook_exposure + type: notebook + depends_on: + - ref('model') + - ref('second_model') + owner: + email: something@example.com + name: Some name + description: "{{ doc('notebook_info') }}" + maturity: medium + url: http://example.com/notebook/1 diff --git a/test/integration/029_docs_generate_tests/test_docs_generate.py b/test/integration/029_docs_generate_tests/test_docs_generate.py index 56907b3e259..88411b8645f 100644 --- a/test/integration/029_docs_generate_tests/test_docs_generate.py +++ b/test/integration/029_docs_generate_tests/test_docs_generate.py @@ -1992,7 +1992,32 @@ def expected_postgres_references_manifest(self, model_database=None): 'unrendered_config': {} }, }, - 'exposures': {}, + 'exposures': { + 'exposure.test.notebook_exposure': { + 'depends_on': { + 'macros': [], + 'nodes': ['model.test.model', 'model.test.second_model'] + }, + 'description': 'A description of the complex exposure', + 'fqn': ['test', 'notebook_exposure'], + 'maturity': 'medium', + 'name': 'notebook_exposure', + 'original_file_path': self.dir('models/schema.yml'), + 'owner': { + 'email': 'something@example.com', + 'name': 'Some name' + }, + 'package_name': 'test', + 'path': 'schema.yml', + 'refs': [['model'], ['second_model']], + 'resource_type': 'exposure', + 'root_path': self.test_root_realpath, + 'sources': [], + 'type': 'notebook', + 'unique_id': 'exposure.test.notebook_exposure', + 'url': 'http://example.com/notebook/1' + }, + }, 'selectors': {}, 'docs': { 'dbt.__overview__': ANY, diff --git a/test/unit/test_contracts_graph_unparsed.py b/test/unit/test_contracts_graph_unparsed.py index 0ca5a749928..424f254353d 100644 --- a/test/unit/test_contracts_graph_unparsed.py +++ b/test/unit/test_contracts_graph_unparsed.py @@ -576,6 +576,7 @@ class TestUnparsedExposure(ContractTestCase): def get_ok_dict(self): return { + 'yaml_key': 'exposures' 'name': 'my_exposure', 'type': 'dashboard', 'owner': { @@ -587,11 +588,14 @@ def get_ok_dict(self): 'depends_on': [ 'ref("my_model")', 'source("raw", "source_table")', - ] + ], + 'original_file_path': '/some/fake/path', + 'package_name': 'test' } def test_ok(self): exposure = self.ContractType( + yaml_key='exposures' name='my_exposure', type=ExposureType.Dashboard, owner=ExposureOwner(email='name@example.com'), @@ -599,6 +603,8 @@ def test_ok(self): url='https://example.com/dashboards/1', description='A exposure', depends_on=['ref("my_model")', 'source("raw", "source_table")'], + original_file_path='/some/fake/path', + package_name='test' ) dct = self.get_ok_dict() self.assert_symmetric(exposure, dct) From 5ac4f2d80baf6f2a296d81d4298cd8c51c031a7b Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Tue, 1 Dec 2020 12:33:08 +1300 Subject: [PATCH 04/16] Move description arg to be below default-free args --- core/dbt/contracts/graph/unparsed.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/dbt/contracts/graph/unparsed.py b/core/dbt/contracts/graph/unparsed.py index 26af41e244c..6e272bafaf7 100644 --- a/core/dbt/contracts/graph/unparsed.py +++ b/core/dbt/contracts/graph/unparsed.py @@ -413,9 +413,9 @@ class ExposureOwner(JsonSchemaMixin, Replaceable): @dataclass class UnparsedExposure(HasYamlMetadata, Replaceable): name: str - description: str = '' type: ExposureType owner: ExposureOwner + description: str = '' maturity: Optional[MaturityType] = None url: Optional[str] = None depends_on: List[str] = field(default_factory=list) From dbb6b57b76811343f5e2ad3bbfa05c1204c071d2 Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Tue, 1 Dec 2020 12:40:51 +1300 Subject: [PATCH 05/16] Forgot a comma --- test/unit/test_contracts_graph_unparsed.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/test_contracts_graph_unparsed.py b/test/unit/test_contracts_graph_unparsed.py index 424f254353d..f3b29e6242a 100644 --- a/test/unit/test_contracts_graph_unparsed.py +++ b/test/unit/test_contracts_graph_unparsed.py @@ -576,7 +576,7 @@ class TestUnparsedExposure(ContractTestCase): def get_ok_dict(self): return { - 'yaml_key': 'exposures' + 'yaml_key': 'exposures', 'name': 'my_exposure', 'type': 'dashboard', 'owner': { From 7f3396c0022349e0460e4b32aa0aee75895c9fa0 Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Tue, 1 Dec 2020 12:46:26 +1300 Subject: [PATCH 06/16] Forgot another comma :facepalm: --- test/unit/test_contracts_graph_unparsed.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/test_contracts_graph_unparsed.py b/test/unit/test_contracts_graph_unparsed.py index f3b29e6242a..32ae398bf3a 100644 --- a/test/unit/test_contracts_graph_unparsed.py +++ b/test/unit/test_contracts_graph_unparsed.py @@ -595,7 +595,7 @@ def get_ok_dict(self): def test_ok(self): exposure = self.ContractType( - yaml_key='exposures' + yaml_key='exposures', name='my_exposure', type=ExposureType.Dashboard, owner=ExposureOwner(email='name@example.com'), From 9afe8a129745a4dbb0e3cf9a4fcbc4c087fe4611 Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Tue, 1 Dec 2020 17:35:42 +1300 Subject: [PATCH 07/16] Default to empty string for ParsedExposure description --- core/dbt/contracts/graph/parsed.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/dbt/contracts/graph/parsed.py b/core/dbt/contracts/graph/parsed.py index 422c78f5390..0a7e41c26a0 100644 --- a/core/dbt/contracts/graph/parsed.py +++ b/core/dbt/contracts/graph/parsed.py @@ -654,9 +654,9 @@ class ParsedExposure(UnparsedBaseNode, HasUniqueID, HasFqn): type: ExposureType owner: ExposureOwner resource_type: NodeType = NodeType.Exposure + description: str = '' maturity: Optional[MaturityType] = None url: Optional[str] = None - description: Optional[str] = None depends_on: DependsOn = field(default_factory=DependsOn) refs: List[List[str]] = field(default_factory=list) sources: List[List[str]] = field(default_factory=list) From 36d91aded6a4d7f795bc3a4fe31a5edeea443cc2 Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Tue, 1 Dec 2020 17:56:55 +1300 Subject: [PATCH 08/16] Empty description for minimal/basic exposure object tests --- test/unit/test_contracts_graph_parsed.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/unit/test_contracts_graph_parsed.py b/test/unit/test_contracts_graph_parsed.py index 9161af7ae4a..16ef193900c 100644 --- a/test/unit/test_contracts_graph_parsed.py +++ b/test/unit/test_contracts_graph_parsed.py @@ -2017,6 +2017,7 @@ def minimal_parsed_exposure_dict(): 'path': 'models/something.yml', 'root_path': '/usr/src/app', 'original_file_path': 'models/something.yml', + 'description': '' } @@ -2041,6 +2042,7 @@ def basic_parsed_exposure_dict(): 'path': 'models/something.yml', 'root_path': '/usr/src/app', 'original_file_path': 'models/something.yml', + 'description': '' } @@ -2056,6 +2058,7 @@ def basic_parsed_exposure_object(): root_path='/usr/src/app', original_file_path='models/something.yml', owner=ExposureOwner(email='test@example.com'), + description='' ) From a90510f6f21cf746dda9cf5c022561b9cddaccd2 Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Wed, 2 Dec 2020 10:40:34 +1300 Subject: [PATCH 09/16] Ref a model that actually exists --- test/integration/029_docs_generate_tests/ref_models/schema.yml | 3 +-- test/integration/029_docs_generate_tests/test_docs_generate.py | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/test/integration/029_docs_generate_tests/ref_models/schema.yml b/test/integration/029_docs_generate_tests/ref_models/schema.yml index ab20ba02463..99ac66900f6 100644 --- a/test/integration/029_docs_generate_tests/ref_models/schema.yml +++ b/test/integration/029_docs_generate_tests/ref_models/schema.yml @@ -34,8 +34,7 @@ exposures: - name: notebook_exposure type: notebook depends_on: - - ref('model') - - ref('second_model') + - ref('view_summary') owner: email: something@example.com name: Some name diff --git a/test/integration/029_docs_generate_tests/test_docs_generate.py b/test/integration/029_docs_generate_tests/test_docs_generate.py index 88411b8645f..2704481a513 100644 --- a/test/integration/029_docs_generate_tests/test_docs_generate.py +++ b/test/integration/029_docs_generate_tests/test_docs_generate.py @@ -1996,7 +1996,7 @@ def expected_postgres_references_manifest(self, model_database=None): 'exposure.test.notebook_exposure': { 'depends_on': { 'macros': [], - 'nodes': ['model.test.model', 'model.test.second_model'] + 'nodes': ['model.test.view_summary'] }, 'description': 'A description of the complex exposure', 'fqn': ['test', 'notebook_exposure'], From 03210c63f43d3228cdac5bef5d717fcdb0136495 Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Wed, 2 Dec 2020 10:57:47 +1300 Subject: [PATCH 10/16] Blank instead of none description --- test/integration/029_docs_generate_tests/test_docs_generate.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/integration/029_docs_generate_tests/test_docs_generate.py b/test/integration/029_docs_generate_tests/test_docs_generate.py index 2704481a513..ddb792fdfb8 100644 --- a/test/integration/029_docs_generate_tests/test_docs_generate.py +++ b/test/integration/029_docs_generate_tests/test_docs_generate.py @@ -1594,7 +1594,7 @@ def expected_seeded_manifest(self, model_database=None, quote_model=False): 'model.test.model' ], }, - 'description': None, + 'description': '', 'fqn': ['test', 'simple_exposure'], 'name': 'simple_exposure', 'original_file_path': self.dir('models/schema.yml'), From 217aafce39a42e5c95345bfc22ec3f3f90342cd5 Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Wed, 2 Dec 2020 11:47:29 +1300 Subject: [PATCH 11/16] Add line break to description, fix refs and maybe fix original_file_path --- .../029_docs_generate_tests/test_docs_generate.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/integration/029_docs_generate_tests/test_docs_generate.py b/test/integration/029_docs_generate_tests/test_docs_generate.py index ddb792fdfb8..d7d9fb36b45 100644 --- a/test/integration/029_docs_generate_tests/test_docs_generate.py +++ b/test/integration/029_docs_generate_tests/test_docs_generate.py @@ -1567,7 +1567,7 @@ def expected_seeded_manifest(self, model_database=None, quote_model=False): 'macros': [], 'nodes': ['model.test.model', 'model.test.second_model'] }, - 'description': 'A description of the complex exposure', + 'description': 'A description of the complex exposure\n', 'fqn': ['test', 'notebook_exposure'], 'maturity': 'medium', 'name': 'notebook_exposure', @@ -2002,14 +2002,14 @@ def expected_postgres_references_manifest(self, model_database=None): 'fqn': ['test', 'notebook_exposure'], 'maturity': 'medium', 'name': 'notebook_exposure', - 'original_file_path': self.dir('models/schema.yml'), + 'original_file_path': 'models/schema.yml', 'owner': { 'email': 'something@example.com', 'name': 'Some name' }, 'package_name': 'test', 'path': 'schema.yml', - 'refs': [['model'], ['second_model']], + 'refs': [['view_summary']], 'resource_type': 'exposure', 'root_path': self.test_root_realpath, 'sources': [], From 23be083c39f43d8ed689608d7291d9ab47ec3380 Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Wed, 2 Dec 2020 11:59:21 +1300 Subject: [PATCH 12/16] Change models folder to ref_models folder --- test/integration/029_docs_generate_tests/test_docs_generate.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/integration/029_docs_generate_tests/test_docs_generate.py b/test/integration/029_docs_generate_tests/test_docs_generate.py index d7d9fb36b45..ba3f563acbe 100644 --- a/test/integration/029_docs_generate_tests/test_docs_generate.py +++ b/test/integration/029_docs_generate_tests/test_docs_generate.py @@ -2002,7 +2002,7 @@ def expected_postgres_references_manifest(self, model_database=None): 'fqn': ['test', 'notebook_exposure'], 'maturity': 'medium', 'name': 'notebook_exposure', - 'original_file_path': 'models/schema.yml', + 'original_file_path': self.dir('ref_models/schema.yml'), 'owner': { 'email': 'something@example.com', 'name': 'Some name' From c4c5b593128f3c4406e46742d3d0d93544dac296 Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Mon, 7 Dec 2020 17:45:12 +1300 Subject: [PATCH 13/16] Stab at updating parent and child maps --- .../integration/029_docs_generate_tests/test_docs_generate.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/integration/029_docs_generate_tests/test_docs_generate.py b/test/integration/029_docs_generate_tests/test_docs_generate.py index ba3f563acbe..51740cb8f94 100644 --- a/test/integration/029_docs_generate_tests/test_docs_generate.py +++ b/test/integration/029_docs_generate_tests/test_docs_generate.py @@ -2110,8 +2110,9 @@ def expected_postgres_references_manifest(self, model_database=None): }, 'child_map': { 'model.test.ephemeral_copy': ['model.test.ephemeral_summary'], + 'exposure.test.notebook_exposure': ['model.test.view_summary'], 'model.test.ephemeral_summary': ['model.test.view_summary'], - 'model.test.view_summary': [], + 'model.test.view_summary': ['exposure.test.notebook_exposure'], 'seed.test.seed': ['snapshot.test.snapshot_seed'], 'snapshot.test.snapshot_seed': [], 'source.test.my_source.my_table': ['model.test.ephemeral_copy'], @@ -2120,6 +2121,7 @@ def expected_postgres_references_manifest(self, model_database=None): 'model.test.ephemeral_copy': ['source.test.my_source.my_table'], 'model.test.ephemeral_summary': ['model.test.ephemeral_copy'], 'model.test.view_summary': ['model.test.ephemeral_summary'], + 'exposure.test.notebook_exposure': ['model.test.view_summary'], 'seed.test.seed': [], 'snapshot.test.snapshot_seed': ['seed.test.seed'], 'source.test.my_source.my_table': [], From 35c9206916bb21a49761f367bed35c80c3b91914 Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Mon, 7 Dec 2020 21:15:44 +1300 Subject: [PATCH 14/16] Fix test failure (?) --- test/integration/029_docs_generate_tests/test_docs_generate.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/integration/029_docs_generate_tests/test_docs_generate.py b/test/integration/029_docs_generate_tests/test_docs_generate.py index 51740cb8f94..48619b885fb 100644 --- a/test/integration/029_docs_generate_tests/test_docs_generate.py +++ b/test/integration/029_docs_generate_tests/test_docs_generate.py @@ -2121,7 +2121,7 @@ def expected_postgres_references_manifest(self, model_database=None): 'model.test.ephemeral_copy': ['source.test.my_source.my_table'], 'model.test.ephemeral_summary': ['model.test.ephemeral_copy'], 'model.test.view_summary': ['model.test.ephemeral_summary'], - 'exposure.test.notebook_exposure': ['model.test.view_summary'], + 'exposure.test.notebook_exposure': [], 'seed.test.seed': [], 'snapshot.test.snapshot_seed': ['seed.test.seed'], 'source.test.my_source.my_table': [], From f62bea65a12984c33553094b1bf7943252736dfa Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Sun, 13 Dec 2020 14:11:04 +1300 Subject: [PATCH 15/16] Move model.test.view_summary to parent map instead of child map --- .../integration/029_docs_generate_tests/test_docs_generate.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/integration/029_docs_generate_tests/test_docs_generate.py b/test/integration/029_docs_generate_tests/test_docs_generate.py index 48619b885fb..09b4bfd2164 100644 --- a/test/integration/029_docs_generate_tests/test_docs_generate.py +++ b/test/integration/029_docs_generate_tests/test_docs_generate.py @@ -2110,7 +2110,7 @@ def expected_postgres_references_manifest(self, model_database=None): }, 'child_map': { 'model.test.ephemeral_copy': ['model.test.ephemeral_summary'], - 'exposure.test.notebook_exposure': ['model.test.view_summary'], + 'exposure.test.notebook_exposure': [], 'model.test.ephemeral_summary': ['model.test.view_summary'], 'model.test.view_summary': ['exposure.test.notebook_exposure'], 'seed.test.seed': ['snapshot.test.snapshot_seed'], @@ -2121,7 +2121,7 @@ def expected_postgres_references_manifest(self, model_database=None): 'model.test.ephemeral_copy': ['source.test.my_source.my_table'], 'model.test.ephemeral_summary': ['model.test.ephemeral_copy'], 'model.test.view_summary': ['model.test.ephemeral_summary'], - 'exposure.test.notebook_exposure': [], + 'exposure.test.notebook_exposure': ['model.test.view_summary'], 'seed.test.seed': [], 'snapshot.test.snapshot_seed': ['seed.test.seed'], 'source.test.my_source.my_table': [], From 441f86f3eddf414eb2ea201694b52285285010a3 Mon Sep 17 00:00:00 2001 From: Joel Labes Date: Sun, 13 Dec 2020 14:25:37 +1300 Subject: [PATCH 16/16] Add test.notebook_info to expected manifest --- .../029_docs_generate_tests/test_docs_generate.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/test/integration/029_docs_generate_tests/test_docs_generate.py b/test/integration/029_docs_generate_tests/test_docs_generate.py index 09b4bfd2164..c597fd097d7 100644 --- a/test/integration/029_docs_generate_tests/test_docs_generate.py +++ b/test/integration/029_docs_generate_tests/test_docs_generate.py @@ -2098,6 +2098,15 @@ def expected_postgres_references_manifest(self, model_database=None): 'root_path': self.test_root_realpath, 'unique_id': 'test.macro_info', }, + 'test.notebook_info': { + 'block_contents': 'A description of the complex exposure', + 'name': 'notebook_info', + 'original_file_path': docs_path, + 'package_name': 'test', + 'path': 'docs.md', + 'root_path': self.test_root_realpath, + 'unique_id': 'test.notebook_info' + }, 'test.macro_arg_info': { 'block_contents': 'The model for my custom test', 'name': 'macro_arg_info',