From 1478a68e9490ba5b94001968606820d81d60a7d6 Mon Sep 17 00:00:00 2001 From: John Lynch Date: Thu, 24 Sep 2020 17:19:43 -0500 Subject: [PATCH 1/4] adding source tags --- src/app/main/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/main/index.js b/src/app/main/index.js index 3d482a09..fa7bd8e0 100644 --- a/src/app/main/index.js +++ b/src/app/main/index.js @@ -222,7 +222,7 @@ angular var packages = _.unique(_.pluck(_.values(project.nodes), 'package_name')) var all_tags = [null]; _.each(project.nodes, function(node) { - if (node.resource_type == 'model') { + if (node.resource_type == 'model' || node.resource_type == 'source') { var tags = node.tags; all_tags = _.union(all_tags, tags); }; From 80755aa28016ba178cf3d6329d2aeede647c8dd6 Mon Sep 17 00:00:00 2001 From: John Lynch Date: Fri, 25 Sep 2020 12:04:44 -0500 Subject: [PATCH 2/4] changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4371d020..4bec3dd0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,8 @@ ## dbt 0.19.0 (Release TBD) +- Fixed issue where sources with tags were not showing up in graph viz. ([docs#93](https://github.com/fishtown-analytics/dbt-docs/issues/93)) + +Contributors: +- [@jplynch77](https://github.com/jplynch77) ([docs#139](https://github.com/fishtown-analytics/dbt-docs/pull/139)) ## dbt 0.18.1 (Unreleased) - Add Exposure nodes ([docs#135](https://github.com/fishtown-analytics/dbt-docs/issues/135), [docs#136](https://github.com/fishtown-analytics/dbt-docs/pull/136), [docs#137](https://github.com/fishtown-analytics/dbt-docs/pull/137)) From 96860c0c2ec5c0a2f905beecc5370af3cc69241c Mon Sep 17 00:00:00 2001 From: John Lynch Date: Fri, 25 Sep 2020 12:10:58 -0500 Subject: [PATCH 3/4] cla-email --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4bec3dd0..1828169a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,5 @@ ## dbt 0.19.0 (Release TBD) -- Fixed issue where sources with tags were not showing up in graph viz. ([docs#93](https://github.com/fishtown-analytics/dbt-docs/issues/93)) +- Fixed issue where sources with tags were not showing up in graph viz ([docs#93](https://github.com/fishtown-analytics/dbt-docs/issues/93)) Contributors: - [@jplynch77](https://github.com/jplynch77) ([docs#139](https://github.com/fishtown-analytics/dbt-docs/pull/139)) From ce7877f2716acdb370fe7d02c602bc2f664e9343 Mon Sep 17 00:00:00 2001 From: John Lynch Date: Fri, 25 Sep 2020 14:27:27 -0500 Subject: [PATCH 4/4] exclude tests instead of include sources --- src/app/main/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/main/index.js b/src/app/main/index.js index fa7bd8e0..fb72d0aa 100644 --- a/src/app/main/index.js +++ b/src/app/main/index.js @@ -222,7 +222,7 @@ angular var packages = _.unique(_.pluck(_.values(project.nodes), 'package_name')) var all_tags = [null]; _.each(project.nodes, function(node) { - if (node.resource_type == 'model' || node.resource_type == 'source') { + if (node.resource_type != 'test') { var tags = node.tags; all_tags = _.union(all_tags, tags); };