From 2c8abf8b7489ba24bb616ec4567f4bc8ba7897b1 Mon Sep 17 00:00:00 2001 From: Jeremy Cohen Date: Fri, 3 Dec 2021 20:12:22 +0100 Subject: [PATCH 1/2] Return AdapterResponse from get_response --- dbt/adapters/spark/connections.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/dbt/adapters/spark/connections.py b/dbt/adapters/spark/connections.py index 1848a72a8..1d3a920c2 100644 --- a/dbt/adapters/spark/connections.py +++ b/dbt/adapters/spark/connections.py @@ -3,7 +3,7 @@ import dbt.exceptions from dbt.adapters.base import Credentials from dbt.adapters.sql import SQLConnectionManager -from dbt.contracts.connection import ConnectionState +from dbt.contracts.connection import ConnectionState, AdapterResponse from dbt.events import AdapterLogger from dbt.utils import DECIMALS from dbt.adapters.spark import __version__ @@ -304,8 +304,12 @@ def cancel(self, connection): connection.handle.cancel() @classmethod - def get_response(cls, cursor): - return 'OK' + def get_response(cls, cursor) -> AdapterResponse: + # until we do this better: https://github.com/dbt-labs/dbt-spark/issues/142 + message = 'OK' + return AdapterResponse( + _message=message + ) # No transactions on Spark.... def add_begin_query(self, *args, **kwargs): From 89d72838ee0b2ddb148c8324953bfa57294e5dd1 Mon Sep 17 00:00:00 2001 From: Jeremy Cohen Date: Fri, 3 Dec 2021 20:16:04 +0100 Subject: [PATCH 2/2] fix flake --- dbt/adapters/spark/connections.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dbt/adapters/spark/connections.py b/dbt/adapters/spark/connections.py index 1d3a920c2..2a055bf27 100644 --- a/dbt/adapters/spark/connections.py +++ b/dbt/adapters/spark/connections.py @@ -305,7 +305,7 @@ def cancel(self, connection): @classmethod def get_response(cls, cursor) -> AdapterResponse: - # until we do this better: https://github.com/dbt-labs/dbt-spark/issues/142 + # https://github.com/dbt-labs/dbt-spark/issues/142 message = 'OK' return AdapterResponse( _message=message