'; - var shadowRoot2 = shadowRoot1 + const shadowRoot2 = shadowRoot1 .querySelector('article') .attachShadow({ mode: 'open' }); shadowRoot2.innerHTML = 'Hello world'; - var target = shadowRoot2.querySelector('h1'); - var sel = axe.utils.getAncestry(target); + const target = shadowRoot2.querySelector('h1'); + const sel = axe.utils.getAncestry(target); assert.deepEqual(sel, [ 'html > body > div:nth-child(1) > section', 'div > article', 'h1' ]); }); + + it('generates selectors of siblings in shadow tree', () => { + const node = document.createElement('section'); + fixture.appendChild(node); + + const shadowRoot = node.attachShadow({ mode: 'open' }); + shadowRoot.innerHTML = '1 2'; + + const sel1 = axe.utils.getAncestry(shadowRoot.children[0]); + assert.deepEqual(sel1, [ + 'html > body > div:nth-child(1) > section', + 'div:nth-child(1)' + ]); + + const sel2 = axe.utils.getAncestry(shadowRoot.children[1]); + assert.deepEqual(sel2, [ + 'html > body > div:nth-child(1) > section', + 'div:nth-child(2)' + ]); + }); }); diff --git a/test/integration/full/rerun/rerun.js b/test/integration/full/rerun/rerun.js index d40a02810c..1545084b67 100644 --- a/test/integration/full/rerun/rerun.js +++ b/test/integration/full/rerun/rerun.js @@ -15,17 +15,22 @@ describe('rerun axe in the same tick' + window.location.pathname, function () { // First run axe.run(options, function (err1, res1) { - assert.isNull(err1); + try { + assert.isNull(err1); - // Second run, on the same tick - axe.run(options, function (err2, res2) { - assert.isNull(err2); - - delete res1.timestamp; - delete res2.timestamp; - assert.deepEqual(res1, res2); - done(); - }); + // Second run, on the same tick + axe.run(options, function (err2, res2) { + try { + assert.isNull(err2); + axe.testUtils.assertResultsDeepEqual(res1, res2); + done(); + } catch (e) { + done(e); + } + }); + } catch (e) { + done(e); + } }); }); }); diff --git a/test/integration/full/run-partial/after-method.js b/test/integration/full/run-partial/after-method.js index 88fdfdd6fa..7ec90206a2 100644 --- a/test/integration/full/run-partial/after-method.js +++ b/test/integration/full/run-partial/after-method.js @@ -22,9 +22,7 @@ describe('run-partial, after-method', function () { var axeRunPartialResult = results[0]; var axeRunResult = results[1]; assert.lengthOf(axeRunPartialResult.violations, 0); - axeRunPartialResult.testEnvironment = axeRunResult.testEnvironment; - axeRunPartialResult.timestamp = axeRunResult.timestamp; - assert.deepEqual(axeRunPartialResult, axeRunResult); + axe.testUtils.assertResultsDeepEqual(axeRunPartialResult, axeRunResult); done(); }) .catch(done); @@ -51,8 +49,7 @@ describe('run-partial, after-method', function () { assert.lengthOf(nodes, 1); assert.deepEqual(nodes[0].target, ['#frame1', 'h3']); - axeRunPartialResult.timestamp = axeRunResult.timestamp; - assert.deepEqual(axeRunPartialResult, axeRunResult); + axe.testUtils.assertResultsDeepEqual(axeRunPartialResult, axeRunResult); done(); }) .catch(done); diff --git a/test/integration/full/run-partial/context-size-focusable.js b/test/integration/full/run-partial/context-size-focusable.js index 03c56ca095..ba46478f59 100644 --- a/test/integration/full/run-partial/context-size-focusable.js +++ b/test/integration/full/run-partial/context-size-focusable.js @@ -25,9 +25,7 @@ describe('run-partial, context-size-focusable', function () { var axeRunPartialResult = results[0]; var axeRunResult = results[1]; assert.lengthOf(axeRunPartialResult.violations, 0); - axeRunPartialResult.testEnvironment = axeRunResult.testEnvironment; - axeRunPartialResult.timestamp = axeRunResult.timestamp; - assert.deepEqual(axeRunPartialResult, axeRunResult); + axe.testUtils.assertResultsDeepEqual(axeRunPartialResult, axeRunResult); done(); }) .catch(done); @@ -54,8 +52,7 @@ describe('run-partial, context-size-focusable', function () { assert.deepEqual(nodes[0].target, ['#fail1', 'html']); assert.deepEqual(nodes[1].target, ['#fail2', 'iframe', 'html']); - axeRunPartialResult.timestamp = axeRunResult.timestamp; - assert.deepEqual(axeRunPartialResult, axeRunResult); + axe.testUtils.assertResultsDeepEqual(axeRunPartialResult, axeRunResult); done(); }) .catch(done); diff --git a/test/integration/full/run-partial/page-level.js b/test/integration/full/run-partial/page-level.js index 589058efc2..11c84be011 100644 --- a/test/integration/full/run-partial/page-level.js +++ b/test/integration/full/run-partial/page-level.js @@ -31,9 +31,7 @@ describe('run-partial, page-level', function () { var axeRunResult = results[1]; assert.lengthOf(axeRunPartialResult.incomplete, 0); assert.lengthOf(axeRunPartialResult.passes, 0); - axeRunPartialResult.timestamp = axeRunResult.timestamp; - axeRunPartialResult.testEnvironment = axeRunResult.testEnvironment; - assert.deepEqual(axeRunPartialResult, axeRunResult); + axe.testUtils.assertResultsDeepEqual(axeRunPartialResult, axeRunResult); done(); }) .catch(done); @@ -60,8 +58,7 @@ describe('run-partial, page-level', function () { assert.lengthOf(nodes, 1); assert.deepEqual(nodes[0].target, ['html']); - axeRunPartialResult.timestamp = axeRunResult.timestamp; - assert.deepEqual(axeRunPartialResult, axeRunResult); + axe.testUtils.assertResultsDeepEqual(axeRunPartialResult, axeRunResult); done(); }) .catch(done); diff --git a/test/integration/rules/button-name/button-name.html b/test/integration/rules/button-name/button-name.html index b3bef1c537..129304e173 100644 --- a/test/integration/rules/button-name/button-name.html +++ b/test/integration/rules/button-name/button-name.html @@ -20,6 +20,10 @@ +Name +Name + + Does not apply diff --git a/test/integration/rules/button-name/button-name.json b/test/integration/rules/button-name/button-name.json index 2ae4a86502..432daca115 100644 --- a/test/integration/rules/button-name/button-name.json +++ b/test/integration/rules/button-name/button-name.json @@ -20,6 +20,8 @@ ["#combo"], ["#buttonTitle"], ["#pass1"], - ["#pass2"] + ["#pass2"], + ["#pass3"], + ["#pass4"] ] } diff --git a/test/integration/rules/input-button-name/input-button-name.html b/test/integration/rules/input-button-name/input-button-name.html index 0019d982e6..a1f483e3ac 100644 --- a/test/integration/rules/input-button-name/input-button-name.html +++ b/test/integration/rules/input-button-name/input-button-name.html @@ -24,6 +24,10 @@ + Name + Name + + diff --git a/test/integration/rules/input-button-name/input-button-name.json b/test/integration/rules/input-button-name/input-button-name.json index 6a92578341..7521299031 100644 --- a/test/integration/rules/input-button-name/input-button-name.json +++ b/test/integration/rules/input-button-name/input-button-name.json @@ -26,6 +26,8 @@ ["#pass10"], ["#pass11"], ["#pass12"], - ["#pass13"] + ["#pass13"], + ["#pass14"], + ["#pass15"] ] } diff --git a/test/integration/rules/input-image-alt/input-image-alt.html b/test/integration/rules/input-image-alt/input-image-alt.html index 8823830a52..de92c53ca9 100644 --- a/test/integration/rules/input-image-alt/input-image-alt.html +++ b/test/integration/rules/input-image-alt/input-image-alt.html @@ -15,6 +15,10 @@ + Name + Name + + { fixture.innerHTML = testObj.content; waitForFrames(fixture, () => { - axe.run( - fixture, - { - /** - * The debug flag helps log errors in a fairly detailed fashion, - * when tests fail in webdriver - */ - debug: true, - performanceTimer: false, - runOnly: { type: 'rule', values: [ruleId] } - }, - (err, r) => { - // assert that there are no errors - if error exists a stack trace is logged. - const errStack = err && err.stack ? err.stack : ''; - assert.isNull(err, 'Error should be null. ' + errStack); - // assert that result is defined - assert.isDefined(r, 'Results are defined.'); - // assert that result has certain keys - assert.hasAnyKeys(r, ['incomplete', 'violations', 'passes']); - // assert incomplete(s) does not have error - r.incomplete.forEach(incomplete => { - assert.isUndefined(incomplete.error); - }); - // flatten results - results = flattenResult(r); - done(); - } - ); + // The setTimeout is a workaround for a Firefox bug. See: + // - https://github.com/dequelabs/axe-core/issues/4556 + // - https://bugzilla.mozilla.org/show_bug.cgi?id=1912115 + setTimeout(() => { + axe.run( + fixture, + { + /** + * The debug flag helps log errors in a fairly detailed fashion, + * when tests fail in webdriver + */ + debug: true, + performanceTimer: false, + runOnly: { type: 'rule', values: [ruleId] } + }, + (err, r) => { + // assert that there are no errors - if error exists a stack trace is logged. + const errStack = err && err.stack ? err.stack : ''; + assert.isNull(err, 'Error should be null. ' + errStack); + // assert that result is defined + assert.isDefined(r, 'Results are defined.'); + // assert that result has certain keys + assert.hasAnyKeys(r, ['incomplete', 'violations', 'passes']); + // assert incomplete(s) does not have error + r.incomplete.forEach(incomplete => { + assert.isUndefined(incomplete.error); + }); + // flatten results + results = flattenResult(r); + done(); + } + ); + }, 0); }); }); runTest(testObj, 'passes'); diff --git a/test/integration/virtual-rules/button-name.js b/test/integration/virtual-rules/button-name.js index 74e2782332..d54ef0f62d 100644 --- a/test/integration/virtual-rules/button-name.js +++ b/test/integration/virtual-rules/button-name.js @@ -1,6 +1,6 @@ -describe('button-name virtual-rule', function () { - it('should pass for aria-label', function () { - var results = axe.runVirtualRule('button-name', { +describe('button-name virtual-rule', () => { + it('should pass for aria-label', () => { + const results = axe.runVirtualRule('button-name', { nodeName: 'button', attributes: { 'aria-label': 'foobar' @@ -12,21 +12,24 @@ describe('button-name virtual-rule', function () { assert.lengthOf(results.incomplete, 0); }); - it('should incomplete for aria-labelledby', function () { - var results = axe.runVirtualRule('button-name', { + it('should incomplete for aria-labelledby', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'button', attributes: { 'aria-labelledby': 'foobar' } }); + node.parent = null; + + const results = axe.runVirtualRule('button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 0); assert.lengthOf(results.incomplete, 1); }); - it('should pass for title', function () { - var results = axe.runVirtualRule('button-name', { + it('should pass for title', () => { + const results = axe.runVirtualRule('button-name', { nodeName: 'button', attributes: { title: 'foobar' @@ -38,8 +41,8 @@ describe('button-name virtual-rule', function () { assert.lengthOf(results.incomplete, 0); }); - it('should pass for role=presentation when disabled', function () { - var results = axe.runVirtualRule('button-name', { + it('should pass for role=presentation when disabled', () => { + const results = axe.runVirtualRule('button-name', { nodeName: 'button', attributes: { role: 'presentation', @@ -52,8 +55,8 @@ describe('button-name virtual-rule', function () { assert.lengthOf(results.incomplete, 0); }); - it('should pass for role=none when disabled', function () { - var results = axe.runVirtualRule('button-name', { + it('should pass for role=none when disabled', () => { + const results = axe.runVirtualRule('button-name', { nodeName: 'button', attributes: { role: 'none', @@ -66,30 +69,30 @@ describe('button-name virtual-rule', function () { assert.lengthOf(results.incomplete, 0); }); - it('should pass for visible text content', function () { - var node = new axe.SerialVirtualNode({ + it('should pass for visible text content', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'button' }); - var child = new axe.SerialVirtualNode({ + const child = new axe.SerialVirtualNode({ nodeName: '#text', nodeType: 3, nodeValue: 'foobar' }); node.children = [child]; - var results = axe.runVirtualRule('button-name', node); + const results = axe.runVirtualRule('button-name', node); assert.lengthOf(results.passes, 1); assert.lengthOf(results.violations, 0); assert.lengthOf(results.incomplete, 0); }); - it('should fail for hidden text', function () { - var button = new axe.SerialVirtualNode({ + it('should fail for hidden text', () => { + const button = new axe.SerialVirtualNode({ nodeName: 'button' }); - var span = new axe.SerialVirtualNode({ + const span = new axe.SerialVirtualNode({ nodeName: 'span', attributes: { 'aria-hidden': true @@ -98,119 +101,168 @@ describe('button-name virtual-rule', function () { span.parent = button; button.children = [span]; - var text = new axe.SerialVirtualNode({ + const text = new axe.SerialVirtualNode({ nodeName: '#text', nodeType: 3, nodeValue: 'foobar' }); text.parent = span; span.children = [text]; + button.parent = null; - var results = axe.runVirtualRule('button-name', button); + const results = axe.runVirtualRule('button-name', button); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - it('should incomplete when alt and children are missing', function () { - var results = axe.runVirtualRule('button-name', { + it('should incomplete when alt and children are missing', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'button', attributes: {} }); + node.parent = null; + + const results = axe.runVirtualRule('button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 0); assert.lengthOf(results.incomplete, 1); }); - it('should fail children contain no visible text', function () { - var node = new axe.SerialVirtualNode({ + it('should fail children contain no visible text', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'button' }); node.children = []; + node.parent = null; - var results = axe.runVirtualRule('button-name', node); + const results = axe.runVirtualRule('button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - it('should fail when alt contains only whitespace', function () { - var node = new axe.SerialVirtualNode({ + it('should fail when alt contains only whitespace', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'button', attributes: { alt: ' \t \n ' } }); node.children = []; + node.parent = null; - var results = axe.runVirtualRule('button-name', node); + const results = axe.runVirtualRule('button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - it('should fail when aria-label is empty', function () { - var node = new axe.SerialVirtualNode({ + it('should fail when aria-label is empty', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'button', attributes: { alt: '' } }); node.children = []; + node.parent = null; - var results = axe.runVirtualRule('button-name', node); + const results = axe.runVirtualRule('button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - it('should fail when title is empty', function () { - var node = new axe.SerialVirtualNode({ + it('should fail when title is empty', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'button', attributes: { title: '' } }); node.children = []; + node.parent = null; - var results = axe.runVirtualRule('button-name', node); + const results = axe.runVirtualRule('button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - it('should fail for role=presentation', function () { - var node = new axe.SerialVirtualNode({ + it('should pass for implicit label', function () { + const node = new axe.SerialVirtualNode({ + nodeName: 'button' + }); + const parent = new axe.SerialVirtualNode({ + nodeName: 'label' + }); + const child = new axe.SerialVirtualNode({ + nodeName: '#text', + nodeType: 3, + nodeValue: 'foobar' + }); + node.parent = parent; + node.children = []; + parent.children = [child, node]; + + const results = axe.runVirtualRule('button-name', node); + + assert.lengthOf(results.passes, 1); + assert.lengthOf(results.violations, 0); + assert.lengthOf(results.incomplete, 0); + }); + + it('should incomplete for explicit label', function () { + const node = new axe.SerialVirtualNode({ + nodeName: 'button', + attributes: { + id: 'foobar' + } + }); + node.parent = null; + + const results = axe.runVirtualRule('button-name', node); + + assert.lengthOf(results.passes, 0); + assert.lengthOf(results.violations, 0); + assert.lengthOf(results.incomplete, 1); + }); + + it('should fail for role=presentation', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'button', attributes: { role: 'presentation' } }); node.children = []; + node.parent = null; - var results = axe.runVirtualRule('button-name', node); + const results = axe.runVirtualRule('button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - it('should fail for role=none', function () { - var node = new axe.SerialVirtualNode({ + it('should fail for role=none', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'button', attributes: { role: 'none' } }); node.children = []; + node.parent = null; - var results = axe.runVirtualRule('button-name', node); + const results = axe.runVirtualRule('button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); diff --git a/test/integration/virtual-rules/input-button-name.js b/test/integration/virtual-rules/input-button-name.js index 80f03a90d5..b8972de4c2 100644 --- a/test/integration/virtual-rules/input-button-name.js +++ b/test/integration/virtual-rules/input-button-name.js @@ -1,6 +1,6 @@ -describe('input-button-name virtual-rule', function () { - it('should pass for type=submit without value', function () { - var results = axe.runVirtualRule('input-button-name', { +describe('input-button-name virtual-rule', () => { + it('should pass for type=submit without value', () => { + const results = axe.runVirtualRule('input-button-name', { nodeName: 'input', attributes: { type: 'submit' @@ -12,8 +12,8 @@ describe('input-button-name virtual-rule', function () { assert.lengthOf(results.incomplete, 0); }); - it('should pass for value', function () { - var results = axe.runVirtualRule('input-button-name', { + it('should pass for value', () => { + const results = axe.runVirtualRule('input-button-name', { nodeName: 'input', attributes: { type: 'button', @@ -26,8 +26,8 @@ describe('input-button-name virtual-rule', function () { assert.lengthOf(results.incomplete, 0); }); - it('should pass for aria-label', function () { - var results = axe.runVirtualRule('input-button-name', { + it('should pass for aria-label', () => { + const results = axe.runVirtualRule('input-button-name', { nodeName: 'input', attributes: { type: 'button', @@ -40,22 +40,25 @@ describe('input-button-name virtual-rule', function () { assert.lengthOf(results.incomplete, 0); }); - it('should incomplete for aria-labelledby', function () { - var results = axe.runVirtualRule('input-button-name', { + it('should incomplete for aria-labelledby', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'input', attributes: { type: 'button', 'aria-labelledby': 'foobar' } }); + node.parent = null; + + const results = axe.runVirtualRule('input-button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 0); assert.lengthOf(results.incomplete, 1); }); - it('should pass for title', function () { - var results = axe.runVirtualRule('input-button-name', { + it('should pass for title', () => { + const results = axe.runVirtualRule('input-button-name', { nodeName: 'input', attributes: { type: 'button', @@ -68,8 +71,8 @@ describe('input-button-name virtual-rule', function () { assert.lengthOf(results.incomplete, 0); }); - it('should pass for role=presentation when disabled', function () { - var results = axe.runVirtualRule('input-button-name', { + it('should pass for role=presentation when disabled', () => { + const results = axe.runVirtualRule('input-button-name', { nodeName: 'input', attributes: { type: 'button', @@ -83,8 +86,8 @@ describe('input-button-name virtual-rule', function () { assert.lengthOf(results.incomplete, 0); }); - it('should pass for role=none when disabled', function () { - var results = axe.runVirtualRule('input-button-name', { + it('should pass for role=none when disabled', () => { + const results = axe.runVirtualRule('input-button-name', { nodeName: 'input', attributes: { type: 'button', @@ -98,97 +101,159 @@ describe('input-button-name virtual-rule', function () { assert.lengthOf(results.incomplete, 0); }); - it('should fail when no other attributes are passed', function () { - var results = axe.runVirtualRule('input-button-name', { + it('should pass for implicit label', function () { + const node = new axe.SerialVirtualNode({ + nodeName: 'input', + attributes: { + type: 'button' + } + }); + const parent = new axe.SerialVirtualNode({ + nodeName: 'label' + }); + const child = new axe.SerialVirtualNode({ + nodeName: '#text', + nodeType: 3, + nodeValue: 'foobar' + }); + node.parent = parent; + node.children = []; + parent.children = [child, node]; + + const results = axe.runVirtualRule('input-button-name', node); + + assert.lengthOf(results.passes, 1); + assert.lengthOf(results.violations, 0); + assert.lengthOf(results.incomplete, 0); + }); + + it('should incomplete for explicit label', function () { + const node = new axe.SerialVirtualNode({ + nodeName: 'input', + attributes: { + type: 'button' + } + }); + + const results = axe.runVirtualRule('input-button-name', node); + + assert.lengthOf(results.passes, 0); + assert.lengthOf(results.violations, 0); + assert.lengthOf(results.incomplete, 1); + }); + + it('should fail when no other attributes are passed', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'input', attributes: { type: 'button' } }); + node.parent = null; + + const results = axe.runVirtualRule('input-button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - it('should fail when value is empty', function () { - var results = axe.runVirtualRule('input-button-name', { + it('should fail when value is empty', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'input', attributes: { type: 'button', value: '' } }); + node.parent = null; + + const results = axe.runVirtualRule('input-button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - it('should fail when alt contains only whitespace', function () { - var results = axe.runVirtualRule('input-button-name', { + it('should fail when alt contains only whitespace', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'input', attributes: { type: 'button', alt: ' \t \n ' } }); + node.parent = null; + + const results = axe.runVirtualRule('input-button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - it('should fail when aria-label is empty', function () { - var results = axe.runVirtualRule('input-button-name', { + it('should fail when aria-label is empty', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'input', attributes: { type: 'button', 'aria-label': '' } }); + node.parent = null; + + const results = axe.runVirtualRule('input-button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - it('should fail when title is empty', function () { - var results = axe.runVirtualRule('input-button-name', { + it('should fail when title is empty', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'input', attributes: { type: 'button', title: '' } }); + node.parent = null; + + const results = axe.runVirtualRule('input-button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - it('should pass for role=presentation', function () { - var results = axe.runVirtualRule('input-button-name', { + it('should fail for role=presentation', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'input', attributes: { type: 'button', role: 'presentation' } }); + node.parent = null; + + const results = axe.runVirtualRule('input-button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - it('should pass for role=none', function () { - var results = axe.runVirtualRule('input-button-name', { + it('should fail for role=none', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'input', attributes: { type: 'button', role: 'none' } }); + node.parent = null; + + const results = axe.runVirtualRule('input-button-name', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); diff --git a/test/integration/virtual-rules/input-image-alt.js b/test/integration/virtual-rules/input-image-alt.js index e2b5d48f23..27d8cd1aca 100644 --- a/test/integration/virtual-rules/input-image-alt.js +++ b/test/integration/virtual-rules/input-image-alt.js @@ -1,6 +1,6 @@ -describe('input-image-alt virtual-rule', function () { - it('should pass for alt', function () { - var results = axe.runVirtualRule('input-image-alt', { +describe('input-image-alt virtual-rule', () => { + it('should pass for alt', () => { + const results = axe.runVirtualRule('input-image-alt', { nodeName: 'input', attributes: { type: 'image', @@ -13,8 +13,8 @@ describe('input-image-alt virtual-rule', function () { assert.lengthOf(results.incomplete, 0); }); - it('should pass for aria-label', function () { - var results = axe.runVirtualRule('input-image-alt', { + it('should pass for aria-label', () => { + const results = axe.runVirtualRule('input-image-alt', { nodeName: 'input', attributes: { type: 'image', @@ -27,22 +27,25 @@ describe('input-image-alt virtual-rule', function () { assert.lengthOf(results.incomplete, 0); }); - it('should incomplete for aria-labelledby', function () { - var results = axe.runVirtualRule('input-image-alt', { + it('should incomplete for aria-labelledby', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'input', attributes: { type: 'image', 'aria-labelledby': 'foobar' } }); + node.parent = null; + + const results = axe.runVirtualRule('input-image-alt', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 0); assert.lengthOf(results.incomplete, 1); }); - it('should pass for title', function () { - var results = axe.runVirtualRule('image-alt', { + it('should pass for title', () => { + const results = axe.runVirtualRule('image-alt', { nodeName: 'img', attributes: { title: 'foobar' @@ -54,55 +57,108 @@ describe('input-image-alt virtual-rule', function () { assert.lengthOf(results.incomplete, 0); }); - it('should fail when alt is missing', function () { - var results = axe.runVirtualRule('input-image-alt', { + it('should pass for implicit label', () => { + const node = new axe.SerialVirtualNode({ + nodeName: 'input', + attributes: { + type: 'image' + } + }); + const parent = new axe.SerialVirtualNode({ + nodeName: 'label' + }); + const child = new axe.SerialVirtualNode({ + nodeName: '#text', + nodeType: 3, + nodeValue: 'foobar' + }); + node.parent = parent; + node.children = []; + parent.children = [child, node]; + + const results = axe.runVirtualRule('input-image-alt', node); + + assert.lengthOf(results.passes, 1); + assert.lengthOf(results.violations, 0); + assert.lengthOf(results.incomplete, 0); + }); + + it('should incomplete for explicit label', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'input', attributes: { type: 'image' } }); + const results = axe.runVirtualRule('input-image-alt', node); + + assert.lengthOf(results.passes, 0); + assert.lengthOf(results.violations, 0); + assert.lengthOf(results.incomplete, 1); + }); + + it('should fail when alt is missing', () => { + const node = new axe.SerialVirtualNode({ + nodeName: 'input', + attributes: { + type: 'image' + } + }); + node.parent = null; + + const results = axe.runVirtualRule('input-image-alt', node); + assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - it('should fail when alt is empty', function () { - var results = axe.runVirtualRule('input-image-alt', { + it('should fail when alt is empty', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'input', attributes: { type: 'image', alt: '' } }); + node.parent = null; + + const results = axe.runVirtualRule('input-image-alt', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - it('should fail when aria-label is empty', function () { - var results = axe.runVirtualRule('input-image-alt', { + it('should fail when aria-label is empty', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'input', attributes: { type: 'image', 'aria-label': '' } }); + node.parent = null; + + const results = axe.runVirtualRule('input-image-alt', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); assert.lengthOf(results.incomplete, 0); }); - it('should fail when title is empty', function () { - var results = axe.runVirtualRule('input-image-alt', { + it('should fail when title is empty', () => { + const node = new axe.SerialVirtualNode({ nodeName: 'input', attributes: { type: 'image', title: '' } }); + node.parent = null; + + const results = axe.runVirtualRule('input-image-alt', node); assert.lengthOf(results.passes, 0); assert.lengthOf(results.violations, 1); diff --git a/test/testutils.js b/test/testutils.js index fe4d38fee0..fa822200b0 100644 --- a/test/testutils.js +++ b/test/testutils.js @@ -708,4 +708,86 @@ var commons; fixtureNode.appendChild(child.cloneNode(true)); } } + + testUtils.assertResultsDeepEqual = ( + expected, + actual, + ignoredPaths = [ + 'timestamp', + // testEnvironment is ignored by default because Chrome's UI animations for the + // "an automated test is controlling this browser" notification can cause + // inconsistencies in windowHeight for otherwise-identical scans. + 'testEnvironment' + ], + keyPath = 'result' + ) => { + const typeObj1 = getType(expected); + const typeObj2 = getType(actual); + + axe.utils.assert( + typeObj1 === typeObj2, + `Expected type of ${keyPath} to equal ${typeObj1} but got ${typeObj2}` + ); + + if (typeObj1 === 'object') { + const res1Keys = Object.keys(expected); + const res2Keys = Object.keys(actual); + + axe.utils.assert( + res1Keys.length === res2Keys.length && + res1Keys.every(key => res2Keys.includes(key)), + `Expected ${keyPath} to have keys "${JSON.stringify(res1Keys)}" but got "${JSON.stringify(res2Keys)}"` + ); + + for (const key of res1Keys) { + if (ignoredPaths.includes(key)) { + continue; + } + + testUtils.assertResultsDeepEqual( + expected[key], + actual[key], + ignoredPaths, + `${keyPath}.${key}` + ); + } + } else if (typeObj1 === 'array') { + axe.utils.assert( + expected.length === actual.length, + `Expected ${keyPath} to have length of "${expected.length}" but got "${actual.length}"` + ); + + for (let i = 0; i < expected.length; i++) { + testUtils.assertResultsDeepEqual( + expected[i], + actual[i], + ignoredPaths, + `${keyPath}[${i}]` + ); + } + } else { + axe.utils.assert( + expected === actual, + `Expected ${keyPath} to equal "${expected}" but got "${actual}"` + ); + } + }; + + function isObject(obj) { + return obj && typeof obj === 'object' && !Array.isArray(obj); + } + + function getType(obj) { + if (isObject(obj)) { + return 'object'; + } + if (Array.isArray(obj)) { + return 'array'; + } + if (obj === null) { + return 'null'; + } + + return typeof obj; + } })(); diff --git a/typings/axe-core/axe-core-tests.ts b/typings/axe-core/axe-core-tests.ts index 1b8a9fda60..43a1286ff0 100644 --- a/typings/axe-core/axe-core-tests.ts +++ b/typings/axe-core/axe-core-tests.ts @@ -35,6 +35,13 @@ axe.run( console.log(error || results); } ); +// axe.run preload: boolean +axe.run({ preload: false }); +axe.run({ preload: true }); +// axe.run preload: options +axe.run({ preload: { assets: ['cssom'] } }); +axe.run({ preload: { assets: ['cssom'], timeout: 50000 } }); + export async function runAsync() { await axe.run('main'); // Single selector await axe.run(['main']); // Array of one selector