From 6fe1fc00a65d5b7ff51fb84f9713031dfdeccb07 Mon Sep 17 00:00:00 2001
From: EGOIST <0x142857@gmail.com>
Date: Sun, 9 Jun 2019 18:35:29 +0800
Subject: [PATCH] feat: add openInNewTab option to nav and sidebar (#236)

* add openInNewTab option to nav and sidebar

* update docs

* tweaks
---
 src/components/HeaderNav.vue   | 15 +++++++++++----
 src/components/SidebarItem.vue | 35 +++++++++++++++++-----------------
 src/components/UniLink.vue     | 13 ++++++++++---
 website/docs/options.md        |  9 +++++++++
 website/docs/zh/options.md     |  9 +++++++++
 5 files changed, 56 insertions(+), 25 deletions(-)

diff --git a/src/components/HeaderNav.vue b/src/components/HeaderNav.vue
index 6a418a9a..478b253a 100644
--- a/src/components/HeaderNav.vue
+++ b/src/components/HeaderNav.vue
@@ -11,14 +11,21 @@
             v-for="(childItem, index) in item.children"
             :key="index"
           >
-            <uni-link :to="childItem.link">{{ childItem.title }}</uni-link>
+            <uni-link
+              :to="childItem.link"
+              :openInNewTab="childItem.openInNewTab"
+              >{{ childItem.title }}</uni-link
+            >
           </li>
         </ul>
       </div>
 
-      <uni-link v-if="!item.children" :to="item.link">{{
-        item.title
-      }}</uni-link>
+      <uni-link
+        v-if="!item.children"
+        :to="item.link"
+        :openInNewTab="item.openInNewTab"
+        >{{ item.title }}</uni-link
+      >
     </div>
   </div>
 </template>
diff --git a/src/components/SidebarItem.vue b/src/components/SidebarItem.vue
index a722905a..df7a3aec 100644
--- a/src/components/SidebarItem.vue
+++ b/src/components/SidebarItem.vue
@@ -16,26 +16,14 @@
     </div>
     <template v-if="!item.collapsable || open">
       <template v-for="(link, index) of children">
-        <a
-          v-if="isExternalLink(link.link)"
-          :key="index"
-          :href="link.link"
+        <uni-link
           class="ItemLink"
-          target="_blank"
-        >
-          {{ link.title }}
-          <external-link-icon />
-        </a>
-        <router-link
-          v-else
           :key="index"
           :to="link.link"
-          :prefetch-files="getPrefetchFiles(link.link)"
-          class="ItemLink"
-          :class="{active: $route.path === link.link}"
+          :openInNewTab="link.openInNewTab"
+          :prefetchFiles="getPrefetchFiles(link.link)"
+          >{{ link.title }}</uni-link
         >
-          {{ link.title }}
-        </router-link>
         <div
           class="LinkToc"
           v-if="
@@ -54,8 +42,7 @@
             v-for="heading in $store.state.page.headings"
             :key="heading.slug"
             v-html="heading.text"
-          >
-          </router-link>
+          ></router-link>
         </div>
       </template>
     </template>
@@ -64,8 +51,12 @@
 
 <script>
 import {isExternalLink, getFileUrl, getFilenameByPath} from '../utils'
+import UniLink from './UniLink.vue'
 
 export default {
+  components: {
+    UniLink
+  },
   props: {
     item: {
       type: Object,
@@ -89,6 +80,7 @@ export default {
   },
   methods: {
     isExternalLink,
+
     getPrefetchFiles(path) {
       const {sourcePath, routes} = this.$store.getters.config
       if (routes && routes[path]) {
@@ -98,6 +90,13 @@ export default {
       const filename = getFilenameByPath(path)
       const fileUrl = getFileUrl(sourcePath, filename)
       return fileUrl ? [fileUrl] : []
+    },
+
+    getLinkTarget(link) {
+      if (!isExternalLink(link) || link.openInNewTab === false) {
+        return '_self'
+      }
+      return '_blank'
     }
   }
 }
diff --git a/src/components/UniLink.vue b/src/components/UniLink.vue
index dcbae2ed..51d18bbb 100644
--- a/src/components/UniLink.vue
+++ b/src/components/UniLink.vue
@@ -6,9 +6,11 @@ export default {
 
   render(h, {data, children}) {
     const attrs = {...data.attrs}
-    const {to} = attrs
+    const {to, openInNewTab} = attrs
+    delete attrs.openInNewTab
     if (isExternalLink(to)) {
       delete attrs.to
+      delete attrs.prefetchFiles
       return h(
         'a',
         {
@@ -17,10 +19,15 @@ export default {
           attrs: {
             ...attrs,
             href: to,
-            target: '_blank'
+            target: openInNewTab === false ? '_self' : '_blank'
           }
         },
-        [...children, h('external-link-icon', {class: 'external-link-icon'})]
+        [
+          ...children,
+          openInNewTab === false
+            ? null
+            : h('external-link-icon', {class: 'external-link-icon'})
+        ]
       )
     }
     return h('router-link', data, children)
diff --git a/website/docs/options.md b/website/docs/options.md
index 395666f5..dccabbfe 100644
--- a/website/docs/options.md
+++ b/website/docs/options.md
@@ -40,6 +40,10 @@ An array of navigation items to display at navbar.
 interface NavItem {
   title: string
   link?: string
+  // Whether to open the link in a new tab
+  // Only works for external links
+  // Defaults to `true`
+  openInNewTab?: boolean
   // Or use `children` to display dropdown menu
   children?: Array<NavItemLink>
 }
@@ -47,6 +51,7 @@ interface NavItem {
 interface NavItemLink {
   title: string
   link: string
+  openInNewTab?: boolean
 }
 ```
 
@@ -66,6 +71,10 @@ interface SidebarItem {
 interface SidebarItemLink {
   title: string
   link: string
+  // Whether to open the link in a new tab
+  // Only works for external links
+  // Defaults to `true`
+  openInNewTab?: boolean
   /* Whether to show TOC, true by default */
   toc?: boolean
 }
diff --git a/website/docs/zh/options.md b/website/docs/zh/options.md
index 3fd2f870..fb35a2ad 100644
--- a/website/docs/zh/options.md
+++ b/website/docs/zh/options.md
@@ -41,6 +41,10 @@ Customize the logo in header.
 interface NavItem {
   title: string
   link?: string
+  // Whether to open the link in a new tab
+  // Only works for external links
+  // Defaults to `true`
+  openInNewTab?: boolean
   // Use `children` instead of `link` to display dropdown
   children?: Array<NavItemLink>
 }
@@ -48,6 +52,7 @@ interface NavItem {
 interface NavItemLink {
   title: string
   link: string
+  openInNewTab?: boolean
 }
 ```
 
@@ -66,6 +71,10 @@ interface SidebarItem {
 interface ItemLink {
   title: string
   link: string
+  // Whether to open the link in a new tab
+  // Only works for external links
+  // Defaults to `true`
+  openInNewTab?: boolean
   /* 是否显示 TOC，默认为 true */
   toc: boolean
 }