diff --git a/.eclipseformat.xml b/.eclipseformat.xml index 9e913b41926a8..19ac64cbb4583 100644 --- a/.eclipseformat.xml +++ b/.eclipseformat.xml @@ -51,7 +51,7 @@ - + @@ -101,7 +101,7 @@ - + @@ -286,7 +286,7 @@ - + diff --git a/buildSrc/src/main/java/org/elasticsearch/gradle/JdkDownloadPlugin.java b/buildSrc/src/main/java/org/elasticsearch/gradle/JdkDownloadPlugin.java index b1895727949ef..c808f2a026421 100644 --- a/buildSrc/src/main/java/org/elasticsearch/gradle/JdkDownloadPlugin.java +++ b/buildSrc/src/main/java/org/elasticsearch/gradle/JdkDownloadPlugin.java @@ -215,8 +215,7 @@ private static void setupRootJdkDownload(Project rootProject, String platform, S String[] pathSegments = details.getRelativePath().getSegments(); int index = 0; for (; index < pathSegments.length; index++) { - if (pathSegments[index].matches("jdk-.*")) - break; + if (pathSegments[index].matches("jdk-.*")) break; } assert index + 1 <= pathSegments.length; String[] newPathSegments = Arrays.copyOfRange(pathSegments, index + 1, pathSegments.length); diff --git a/buildSrc/src/main/java/org/elasticsearch/gradle/precommit/TestingConventionRule.java b/buildSrc/src/main/java/org/elasticsearch/gradle/precommit/TestingConventionRule.java index 32838fd243d6f..c85e74b5218e2 100644 --- a/buildSrc/src/main/java/org/elasticsearch/gradle/precommit/TestingConventionRule.java +++ b/buildSrc/src/main/java/org/elasticsearch/gradle/precommit/TestingConventionRule.java @@ -87,10 +87,8 @@ public Set getTaskNames() { @Override public boolean equals(Object o) { - if (this == o) - return true; - if (o == null || getClass() != o.getClass()) - return false; + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; TestingConventionRule that = (TestingConventionRule) o; return Objects.equals(suffix, that.suffix); } diff --git a/buildSrc/src/main/java/org/elasticsearch/gradle/tar/SymbolicLinkPreservingTar.java b/buildSrc/src/main/java/org/elasticsearch/gradle/tar/SymbolicLinkPreservingTar.java index e92221f1f869e..f34a78754cbf1 100644 --- a/buildSrc/src/main/java/org/elasticsearch/gradle/tar/SymbolicLinkPreservingTar.java +++ b/buildSrc/src/main/java/org/elasticsearch/gradle/tar/SymbolicLinkPreservingTar.java @@ -139,8 +139,7 @@ private boolean isChildOfVisitedSymbolicLink(final FileCopyDetailsInternal detai return false; } for (final File symbolicLink : visitedSymbolicLinks) { - if (isChildOf(symbolicLink, file)) - return true; + if (isChildOf(symbolicLink, file)) return true; } return false; } diff --git a/buildSrc/src/main/java/org/elasticsearch/gradle/test/ErrorReportingTestListener.java b/buildSrc/src/main/java/org/elasticsearch/gradle/test/ErrorReportingTestListener.java index 37811f335763c..cc133bf28edf3 100644 --- a/buildSrc/src/main/java/org/elasticsearch/gradle/test/ErrorReportingTestListener.java +++ b/buildSrc/src/main/java/org/elasticsearch/gradle/test/ErrorReportingTestListener.java @@ -193,10 +193,8 @@ public String getFullName() { @Override public boolean equals(Object o) { - if (this == o) - return true; - if (o == null || getClass() != o.getClass()) - return false; + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; Descriptor that = (Descriptor) o; return Objects.equals(name, that.name) && Objects.equals(className, that.className) && Objects.equals(parent, that.parent); } diff --git a/buildSrc/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchCluster.java b/buildSrc/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchCluster.java index c77e10c0b82f8..0c700e51972d8 100644 --- a/buildSrc/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchCluster.java +++ b/buildSrc/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchCluster.java @@ -442,10 +442,8 @@ public NamedDomainObjectContainer getNodes() { @Override public boolean equals(Object o) { - if (this == o) - return true; - if (o == null || getClass() != o.getClass()) - return false; + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; ElasticsearchCluster that = (ElasticsearchCluster) o; return Objects.equals(clusterName, that.clusterName) && Objects.equals(path, that.path); } diff --git a/buildSrc/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchNode.java b/buildSrc/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchNode.java index fda8d6ab9b307..86d05cd93649d 100644 --- a/buildSrc/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchNode.java +++ b/buildSrc/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchNode.java @@ -1209,10 +1209,8 @@ void waitForAllConditions() { @Override public boolean equals(Object o) { - if (this == o) - return true; - if (o == null || getClass() != o.getClass()) - return false; + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; ElasticsearchNode that = (ElasticsearchNode) o; return Objects.equals(name, that.name) && Objects.equals(path, that.path); } diff --git a/buildSrc/src/test/java/org/elasticsearch/gradle/precommit/ForbiddenPatternsTaskTests.java b/buildSrc/src/test/java/org/elasticsearch/gradle/precommit/ForbiddenPatternsTaskTests.java index 7d61cb46e77ea..9cea6dd9cd0f9 100644 --- a/buildSrc/src/test/java/org/elasticsearch/gradle/precommit/ForbiddenPatternsTaskTests.java +++ b/buildSrc/src/test/java/org/elasticsearch/gradle/precommit/ForbiddenPatternsTaskTests.java @@ -82,8 +82,7 @@ private void writeSourceFile(Project project, String name, String... lines) thro file.getParentFile().mkdirs(); file.createNewFile(); - if (lines.length != 0) - Files.write(file.toPath(), Arrays.asList(lines), StandardCharsets.UTF_8); + if (lines.length != 0) Files.write(file.toPath(), Arrays.asList(lines), StandardCharsets.UTF_8); } private void checkAndAssertTaskSuccessful(ForbiddenPatternsTask task) throws IOException { diff --git a/buildSrc/src/test/java/org/elasticsearch/gradle/test/JUnit3MethodProvider.java b/buildSrc/src/test/java/org/elasticsearch/gradle/test/JUnit3MethodProvider.java index 4b3384eb117c3..b407b0d5fdfd1 100644 --- a/buildSrc/src/test/java/org/elasticsearch/gradle/test/JUnit3MethodProvider.java +++ b/buildSrc/src/test/java/org/elasticsearch/gradle/test/JUnit3MethodProvider.java @@ -40,8 +40,7 @@ public Collection getTestMethods(Class suiteClass, ClassModel classMo ArrayList result = new ArrayList<>(); for (MethodModel mm : methods.values()) { // Skip any methods that have overrieds/ shadows. - if (mm.getDown() != null) - continue; + if (mm.getDown() != null) continue; Method m = mm.element; if (m.getName().startsWith("test") diff --git a/x-pack/plugin/enrich/src/main/java/org/elasticsearch/xpack/enrich/EnrichMetadata.java b/x-pack/plugin/enrich/src/main/java/org/elasticsearch/xpack/enrich/EnrichMetadata.java index 1788a8756666b..57677f57bfa5c 100644 --- a/x-pack/plugin/enrich/src/main/java/org/elasticsearch/xpack/enrich/EnrichMetadata.java +++ b/x-pack/plugin/enrich/src/main/java/org/elasticsearch/xpack/enrich/EnrichMetadata.java @@ -108,10 +108,8 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws @Override public boolean equals(Object o) { - if (this == o) - return true; - if (o == null || getClass() != o.getClass()) - return false; + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; EnrichMetadata that = (EnrichMetadata) o; return policies.equals(that.policies); }