From 3d025e953b5a5564ffb1b89a08145bd5e7cd7bd9 Mon Sep 17 00:00:00 2001
From: Stacey Gammon <gammon@elastic.co>
Date: Thu, 16 Feb 2017 21:34:29 -0500
Subject: [PATCH] save more screenshots

---
 test/functional/apps/dashboard/index.js     | 4 ++--
 test/support/page_objects/common.js         | 2 +-
 test/support/page_objects/dashboard_page.js | 4 +++-
 test/support/utils/try.js                   | 1 -
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/test/functional/apps/dashboard/index.js b/test/functional/apps/dashboard/index.js
index e145fd0eb1ee43..635113f876ee74 100644
--- a/test/functional/apps/dashboard/index.js
+++ b/test/functional/apps/dashboard/index.js
@@ -13,7 +13,7 @@ bdd.describe('dashboard app', function () {
     return remote.setWindowSize(1200,800);
   });
 
- // require('./_dashboard');
+  require('./_dashboard');
   require('./_dashboard_save');
- // require('./_dashboard_time');
+  require('./_dashboard_time');
 });
diff --git a/test/support/page_objects/common.js b/test/support/page_objects/common.js
index f528c3d7b63521..49f7d1022a9639 100644
--- a/test/support/page_objects/common.js
+++ b/test/support/page_objects/common.js
@@ -277,7 +277,7 @@ export default class Common {
       .findByCssSelector(selector)
       .then(() => true)
       .catch(() => false);
-    this.remote.setFindTimeout(defaultFindTimeout);
+    await this.remote.setFindTimeout(defaultFindTimeout);
 
     PageObjects.common.debug(`exists? ${exists}`);
     return exists;
diff --git a/test/support/page_objects/dashboard_page.js b/test/support/page_objects/dashboard_page.js
index 1b86e547039cec..414ec8ae407fd3 100644
--- a/test/support/page_objects/dashboard_page.js
+++ b/test/support/page_objects/dashboard_page.js
@@ -50,6 +50,7 @@ export default class DashboardPage {
         const searchFilter = await PageObjects.common.findTestSubject('searchFilter');
         PageObjects.common.debug('gotoDashboardLandingPage: search filter found? ' + searchFilter);
       });
+      await PageObjects.common.saveScreenshot('dashboard-should-be-on-landing-page');
     }
   }
 
@@ -200,11 +201,12 @@ export default class DashboardPage {
       const searchFilter = await PageObjects.common.findTestSubject('searchFilter');
       PageObjects.common.debug('searchForDashboardWithName: search Filter object found: ' + searchFilter);
       await searchFilter.click();
+      await PageObjects.common.saveScreenshot('searchForDashboardWithName-after-click');
       // Note: this replacement of - to space is to preserve original logic but I'm not sure why or if it's needed.
       await searchFilter.type(dashName.replace('-',' '));
     });
 
-    return await PageObjects.header.waitUntilLoadingHasFinished();
+    await PageObjects.header.waitUntilLoadingHasFinished();
   }
 
   async getDashboardCountWithName(dashName) {
diff --git a/test/support/utils/try.js b/test/support/utils/try.js
index 281baaa500bfcc..eac1084d8b1bed 100644
--- a/test/support/utils/try.js
+++ b/test/support/utils/try.js
@@ -18,7 +18,6 @@ class Try {
     let prevMessage;
 
     function attempt() {
-      Log.debug('--- tryForTime: Retrying...');
       lastTry = Date.now();
 
       if (lastTry - start > timeout) {