From 5af1a379174e149911ea30afabd109a589df854c Mon Sep 17 00:00:00 2001
From: Vadim Yakhin <vadim.yakhin@elastic.co>
Date: Thu, 2 Dec 2021 14:40:49 -0800
Subject: [PATCH] Extract `github_via_app` and
 `github_enterprise_server_via_app` to constants

---
 .../public/applications/workplace_search/constants.ts    | 3 +++
 .../public/applications/workplace_search/routes.ts       | 9 +++++++--
 .../components/add_source/github_via_app_logic.ts        | 8 ++++++--
 .../views/content_sources/components/source_settings.tsx | 9 +++++++--
 4 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/x-pack/plugins/enterprise_search/public/applications/workplace_search/constants.ts b/x-pack/plugins/enterprise_search/public/applications/workplace_search/constants.ts
index 43da4ccef223a14..5b364f814083d04 100644
--- a/x-pack/plugins/enterprise_search/public/applications/workplace_search/constants.ts
+++ b/x-pack/plugins/enterprise_search/public/applications/workplace_search/constants.ts
@@ -336,6 +336,9 @@ export const GITHUB_LINK_TITLE = i18n.translate(
   }
 );
 
+export const GITHUB_VIA_APP_SERVICE_TYPE = 'github_via_app';
+export const GITHUB_ENTERPRISE_SERVER_VIA_APP_SERVICE_TYPE = 'github_enterprise_server_via_app';
+
 export const CUSTOM_SERVICE_TYPE = 'custom';
 
 export const WORKPLACE_SEARCH_URL_PREFIX = '/app/enterprise_search/workplace_search';
diff --git a/x-pack/plugins/enterprise_search/public/applications/workplace_search/routes.ts b/x-pack/plugins/enterprise_search/public/applications/workplace_search/routes.ts
index 6573ca3734eba77..12dd9791b2de46e 100644
--- a/x-pack/plugins/enterprise_search/public/applications/workplace_search/routes.ts
+++ b/x-pack/plugins/enterprise_search/public/applications/workplace_search/routes.ts
@@ -9,6 +9,11 @@ import { generatePath } from 'react-router-dom';
 
 import { docLinks } from '../shared/doc_links';
 
+import {
+  GITHUB_VIA_APP_SERVICE_TYPE,
+  GITHUB_ENTERPRISE_SERVER_VIA_APP_SERVICE_TYPE,
+} from './constants';
+
 export const SETUP_GUIDE_PATH = '/setup_guide';
 
 export const NOT_FOUND_PATH = '/404';
@@ -72,8 +77,8 @@ export const ADD_CONFLUENCE_SERVER_PATH = `${SOURCES_PATH}/add/confluence_server
 export const ADD_DROPBOX_PATH = `${SOURCES_PATH}/add/dropbox`;
 export const ADD_GITHUB_ENTERPRISE_PATH = `${SOURCES_PATH}/add/github_enterprise_server`;
 export const ADD_GITHUB_PATH = `${SOURCES_PATH}/add/github`;
-export const ADD_GITHUB_VIA_APP_PATH = `${SOURCES_PATH}/add/github_via_app`;
-export const ADD_GITHUB_ENTERPRISE_SERVER_VIA_APP_PATH = `${SOURCES_PATH}/add/github_enterprise_server_via_app`;
+export const ADD_GITHUB_VIA_APP_PATH = `${SOURCES_PATH}/add/${GITHUB_VIA_APP_SERVICE_TYPE}`;
+export const ADD_GITHUB_ENTERPRISE_SERVER_VIA_APP_PATH = `${SOURCES_PATH}/add/${GITHUB_ENTERPRISE_SERVER_VIA_APP_SERVICE_TYPE}`;
 export const ADD_GMAIL_PATH = `${SOURCES_PATH}/add/gmail`;
 export const ADD_GOOGLE_DRIVE_PATH = `${SOURCES_PATH}/add/google_drive`;
 export const ADD_JIRA_PATH = `${SOURCES_PATH}/add/jira_cloud`;
diff --git a/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/add_source/github_via_app_logic.ts b/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/add_source/github_via_app_logic.ts
index bc30e87b2b080b5..34e0fbdac536b6c 100644
--- a/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/add_source/github_via_app_logic.ts
+++ b/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/add_source/github_via_app_logic.ts
@@ -11,6 +11,10 @@ import { flashAPIErrors, flashSuccessToast } from '../../../../../shared/flash_m
 import { HttpLogic } from '../../../../../shared/http';
 import { KibanaLogic } from '../../../../../shared/kibana';
 import { AppLogic } from '../../../../app_logic';
+import {
+  GITHUB_VIA_APP_SERVICE_TYPE,
+  GITHUB_ENTERPRISE_SERVER_VIA_APP_SERVICE_TYPE,
+} from '../../../../constants';
 import { SOURCES_PATH, getSourcesPath } from '../../../../routes';
 import { ContentSourceFullData } from '../../../../types';
 
@@ -86,8 +90,8 @@ export const GithubViaAppLogic = kea<MakeLogicType<GithubViaAppValues, GithubVia
 
       const params = {
         service_type: githubEnterpriseServerUrl
-          ? 'github_enterprise_server_via_app'
-          : 'github_via_app',
+          ? GITHUB_ENTERPRISE_SERVER_VIA_APP_SERVICE_TYPE
+          : GITHUB_VIA_APP_SERVICE_TYPE,
         app_id: githubAppId,
         base_url: githubEnterpriseServerUrl,
         private_key: stagedPrivateKey,
diff --git a/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/source_settings.tsx b/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/source_settings.tsx
index bea6cd3f251c72d..e5924b672c771fe 100644
--- a/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/source_settings.tsx
+++ b/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/source_settings.tsx
@@ -29,7 +29,11 @@ import { AppLogic } from '../../../app_logic';
 import { ContentSection } from '../../../components/shared/content_section';
 import { SourceConfigFields } from '../../../components/shared/source_config_fields';
 import { ViewContentHeader } from '../../../components/shared/view_content_header';
-import { NAV } from '../../../constants';
+import {
+  NAV,
+  GITHUB_VIA_APP_SERVICE_TYPE,
+  GITHUB_ENTERPRISE_SERVER_VIA_APP_SERVICE_TYPE,
+} from '../../../constants';
 
 import {
   CANCEL_BUTTON,
@@ -88,7 +92,8 @@ export const SourceSettings: React.FC = () => {
   }, []);
 
   const isGithubApp =
-    serviceType === 'github_via_app' || serviceType === 'github_enterprise_server_via_app';
+    serviceType === GITHUB_VIA_APP_SERVICE_TYPE ||
+    serviceType === GITHUB_ENTERPRISE_SERVER_VIA_APP_SERVICE_TYPE;
 
   const editPath = isGithubApp
     ? undefined // undefined for GitHub apps, as they are configured source-wide, and don't use a connector where you can edit the configuration