diff --git a/x-pack/plugins/canvas/public/index.ts b/x-pack/plugins/canvas/public/index.ts index a15b15fcae3337f..1143663c84abe8d 100644 --- a/x-pack/plugins/canvas/public/index.ts +++ b/x-pack/plugins/canvas/public/index.ts @@ -9,9 +9,9 @@ import { PluginInitializerContext } from 'kibana/public'; import { CoreStart } from '../../../../src/core/public'; import { CanvasServices } from './services'; import { CanvasSetup, CanvasStart, CanvasStartDeps, CanvasPlugin } from './plugin'; +export { CANVAS_APP } from '../common/lib/constants'; export { CanvasSetup, CanvasStart }; - export interface WithKibanaProps { kibana: { services: CoreStart & CanvasStartDeps & { canvas: CanvasServices }; diff --git a/x-pack/plugins/ml/kibana.json b/x-pack/plugins/ml/kibana.json index 310ac5d65c98661..ca5a455411267c6 100644 --- a/x-pack/plugins/ml/kibana.json +++ b/x-pack/plugins/ml/kibana.json @@ -33,6 +33,7 @@ "server": true, "ui": true, "requiredBundles": [ + "canvas", "esUiShared", "kibanaUtils", "kibanaReact", diff --git a/x-pack/plugins/ml/public/embeddables/common/resolve_job_selection.tsx b/x-pack/plugins/ml/public/embeddables/common/resolve_job_selection.tsx index fbceeb7f7cf793b..01f0d884038b36b 100644 --- a/x-pack/plugins/ml/public/embeddables/common/resolve_job_selection.tsx +++ b/x-pack/plugins/ml/public/embeddables/common/resolve_job_selection.tsx @@ -16,6 +16,7 @@ import { } from '../../../../../../src/plugins/kibana_react/public'; import { getMlGlobalServices } from '../../application/app'; import { DashboardConstants } from '../../../../../../src/plugins/dashboard/public'; +import { CANVAS_APP } from '../../../../../../x-pack/plugins/canvas/public'; import { JobId } from '../../../common/types/anomaly_detection_jobs'; import { JobSelectorFlyout } from './components/job_selector_flyout'; @@ -90,8 +91,8 @@ export async function resolveJobSelection( } ); // Close the flyout when user navigates out of the dashboard plugin - currentAppId$.pipe(takeUntil(from(flyoutSession.onClose))).subscribe((appId) => { - if (appId !== DashboardConstants.DASHBOARDS_ID) { + currentAppId$.pipe(takeUntil(from(flyoutSession.onClose))).subscribe((appId = '') => { + if (![DashboardConstants.DASHBOARDS_ID, CANVAS_APP].includes(appId)) { flyoutSession.close(); } });