From ea53f618f81db30d6ed4f35b2b41a8204f176542 Mon Sep 17 00:00:00 2001 From: bhavyarm Date: Tue, 25 May 2021 10:57:16 -0400 Subject: [PATCH 1/2] unskipping advanced settings to figure out a11y test failure --- x-pack/test/accessibility/apps/advanced_settings.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/x-pack/test/accessibility/apps/advanced_settings.ts b/x-pack/test/accessibility/apps/advanced_settings.ts index 7382577c7ebe6d..3696293b8d2f97 100644 --- a/x-pack/test/accessibility/apps/advanced_settings.ts +++ b/x-pack/test/accessibility/apps/advanced_settings.ts @@ -13,7 +13,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const testSubjects = getService('testSubjects'); // FLAKY: https://github.com/elastic/kibana/issues/99006 - describe.skip('Stack Management -Advanced Settings', () => { + // running it in flaky test runner to figure out where is the failure. + describe('Stack Management -Advanced Settings', () => { // click on Management > Advanced settings it('click on advanced settings ', async () => { await PageObjects.common.navigateToUrl('management', 'kibana/settings', { From 44d6b3933a7456e34cece1647ee57c0685c092a1 Mon Sep 17 00:00:00 2001 From: bhavyarm Date: Fri, 28 May 2021 17:23:32 -0400 Subject: [PATCH 2/2] adding dismiss toasts method to reduce all flakiness --- x-pack/test/accessibility/apps/advanced_settings.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/x-pack/test/accessibility/apps/advanced_settings.ts b/x-pack/test/accessibility/apps/advanced_settings.ts index 3696293b8d2f97..6f2dc78a7b35b8 100644 --- a/x-pack/test/accessibility/apps/advanced_settings.ts +++ b/x-pack/test/accessibility/apps/advanced_settings.ts @@ -11,9 +11,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const PageObjects = getPageObjects(['common', 'settings', 'header']); const a11y = getService('a11y'); const testSubjects = getService('testSubjects'); + const toasts = getService('toasts'); - // FLAKY: https://github.com/elastic/kibana/issues/99006 - // running it in flaky test runner to figure out where is the failure. describe('Stack Management -Advanced Settings', () => { // click on Management > Advanced settings it('click on advanced settings ', async () => { @@ -21,36 +20,42 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { shouldUseHashForSubUrl: false, }); await testSubjects.click('settings'); + await toasts.dismissAllToasts(); await a11y.testAppSnapshot(); }); // clicking on the top search bar it('adv settings - search ', async () => { await testSubjects.click('settingsSearchBar'); + await toasts.dismissAllToasts(); await a11y.testAppSnapshot(); }); // clicking on the category dropdown it('adv settings - category -dropdown ', async () => { await testSubjects.click('settingsSearchBar'); + await toasts.dismissAllToasts(); await a11y.testAppSnapshot(); }); // clicking on the toggle button it('adv settings - toggle ', async () => { await testSubjects.click('advancedSetting-editField-csv:quoteValues'); + await toasts.dismissAllToasts(); await a11y.testAppSnapshot(); }); // clicking on editor panel it('adv settings - edit ', async () => { await testSubjects.click('advancedSetting-editField-csv:separator'); + await toasts.dismissAllToasts(); await a11y.testAppSnapshot(); }); // clicking on save button it('adv settings - save', async () => { await testSubjects.click('advancedSetting-saveButton'); + await toasts.dismissAllToasts(); await a11y.testAppSnapshot(); }); });