From 7c3b8405e725ab686f7c9e5c118f9a5066459a8a Mon Sep 17 00:00:00 2001 From: Yara Tercero Date: Tue, 20 Aug 2024 17:51:02 -0400 Subject: [PATCH] have rule edit success toast reflect updated name --- .../rule_creation_ui/pages/rule_editing/index.tsx | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_creation_ui/pages/rule_editing/index.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_creation_ui/pages/rule_editing/index.tsx index 5e6ed40d4d282f..e3e3046be552a3 100644 --- a/x-pack/plugins/security_solution/public/detection_engine/rule_creation_ui/pages/rule_editing/index.tsx +++ b/x-pack/plugins/security_solution/public/detection_engine/rule_creation_ui/pages/rule_editing/index.tsx @@ -23,6 +23,7 @@ import { useParams } from 'react-router-dom'; import type { DataViewListItem } from '@kbn/data-views-plugin/common'; +import { useAppToasts } from '../../../../common/hooks/use_app_toasts'; import { isEsqlRule } from '../../../../../common/detection_engine/utils'; import { RulePreview } from '../../components/rule_preview'; import { getIsRulePreviewDisabled } from '../../components/rule_preview/helpers'; @@ -38,7 +39,6 @@ import { getRuleDetailsUrl, getDetectionEngineUrl, } from '../../../../common/components/link_to/redirect_to_detection_engine'; -import { displaySuccessToast, useStateToaster } from '../../../../common/components/toasters'; import { SpyRoute } from '../../../../common/utils/route/spy_routes'; import { useUserData } from '../../../../detections/components/user_info'; import { StepPanel } from '../../../rule_creation/components/step_panel'; @@ -72,7 +72,7 @@ import { useEsqlIndex, useEsqlQueryForAboutStep } from '../../hooks'; import { CustomHeaderPageMemo } from '..'; const EditRulePageComponent: FC<{ rule: RuleResponse }> = ({ rule }) => { - const [, dispatchToaster] = useStateToaster(); + const { addSuccess } = useAppToasts(); const [ { loading: userInfoLoading, @@ -399,7 +399,7 @@ const EditRulePageComponent: FC<{ rule: RuleResponse }> = ({ rule }) => { actionsStepFormValid ) { startTransaction({ name: SINGLE_RULE_ACTIONS.SAVE }); - await updateRule({ + const updatedRule = await updateRule({ ...formatRule( defineStepData, aboutStepData, @@ -411,7 +411,7 @@ const EditRulePageComponent: FC<{ rule: RuleResponse }> = ({ rule }) => { ...(ruleId ? { id: ruleId } : {}), }); - displaySuccessToast(i18n.SUCCESSFULLY_SAVED_RULE(rule?.name ?? ''), dispatchToaster); + addSuccess(i18n.SUCCESSFULLY_SAVED_RULE(updatedRule?.name ?? '')); navigateToApp(APP_UI_ID, { deepLinkId: SecurityPageName.rules, path: getRuleDetailsUrl(ruleId ?? ''), @@ -428,11 +428,11 @@ const EditRulePageComponent: FC<{ rule: RuleResponse }> = ({ rule }) => { aboutStepData, scheduleStepData, actionsStepData, - rule, + triggersActionsUi.actionTypeRegistry, + rule?.exceptions_list, ruleId, - dispatchToaster, + addSuccess, navigateToApp, - triggersActionsUi.actionTypeRegistry, ]); const onTabClick = useCallback(async (tab: EuiTabbedContentTab) => {