From a454ae8b113036755ca9e5330a5d4809224ce2cc Mon Sep 17 00:00:00 2001 From: emizzle Date: Wed, 18 Mar 2020 17:50:57 +1100 Subject: [PATCH] feat(@embark/core): Support minimum truffle projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When taking a bare-minimum truffle project, created from the [`metacoin` truffle box](https://github.com/truffle-box/metacoin-box), there were only two steps that needed to happen as a prerequisite: 1. First, run `embark init`, creating a default `embark.json` 2. Second, run `npm init`, creating a default `package.json`. Trying to run `embark run` before those prequisites would error with appropriate directions in the console, guiding the user to run those steps explicitly. After running these two steps, Embark would hang waiting for the namesystem plugin to come up. Changing the default namesystem config to disabled allows Embark to start up successfully without hanging. The rationale behind this decision is that if `embark.json` doesn’t exist, then we cannot expect that the namesystem plugin will be installed in the project either, and thefore its default value should be disabled. --- packages/core/core/src/config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/core/src/config.ts b/packages/core/core/src/config.ts index 3a60f54471..6150817dba 100644 --- a/packages/core/core/src/config.ts +++ b/packages/core/core/src/config.ts @@ -562,7 +562,7 @@ export class Config { loadCommunicationConfigFile() { const configObject = { default: { - enabled: true, + enabled: false, provider: "whisper", available_providers: ["whisper"], client: "geth",