From f75d09b1466c5e005a455b381151bdab7b2398eb Mon Sep 17 00:00:00 2001 From: Rohan Kumar Date: Mon, 14 Oct 2019 23:22:43 +0530 Subject: [PATCH] Remove logging from offline builds --- CHANGELOG.md | 1 + .../maven/core/util/JibBuildServiceUtil.java | 13 +------------ 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 81a7db8759..48b3922f95 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ After this we will switch probably to real [Semantic Versioning 2.0.0](http://se * Fix #1710: Docker build args not working * Fix #1728: Ingress enricher is using Ingress kind * Fix #1732: Correctly replacing template placeholders in helm chart +* Fix #1734: Add logging during jib builds ### 4.3.0 (04-10-2019) * Updated custom-enricher sample diff --git a/core/src/main/java/io/fabric8/maven/core/util/JibBuildServiceUtil.java b/core/src/main/java/io/fabric8/maven/core/util/JibBuildServiceUtil.java index f1c6f0d98f..a04056588f 100644 --- a/core/src/main/java/io/fabric8/maven/core/util/JibBuildServiceUtil.java +++ b/core/src/main/java/io/fabric8/maven/core/util/JibBuildServiceUtil.java @@ -171,18 +171,7 @@ public static JibContainer buildContainer(JibContainerBuilder jibContainerBuilde if (offline) { logger.info("Trying to build the image tarball in the offline mode."); } - return jibContainerBuilder.containerize(Containerizer.to(image).setOfflineMode(offline) - .addEventHandler(LogEvent.class, JibBuildServiceUtil::log) - .addEventHandler( - TimerEvent.class, - new TimerEventHandler(message -> consoleLogger.log(LogEvent.Level.DEBUG, message))) - .addEventHandler( - ProgressEvent.class, - new ProgressEventHandler( - update -> - consoleLogger.setFooter( - ProgressDisplayGenerator.generateProgressDisplay( - update.getProgress(), update.getUnfinishedLeafTasks()))))); + return jibContainerBuilder.containerize(Containerizer.to(image).setOfflineMode(offline)); } catch (CacheDirectoryCreationException | IOException | InterruptedException | ExecutionException | RegistryException ex) { logger.error("Unable to build the image tarball: %s", ex.getMessage()); throw new IllegalStateException(ex);