From 59c1a182eed3befcfc779bd3e127aa8a146f7b44 Mon Sep 17 00:00:00 2001 From: Willie-Boy Date: Wed, 5 Apr 2023 23:44:30 +0300 Subject: [PATCH 1/2] Replace deprecated new-window with setWindowOpenHandler --- packages/react-devtools/app.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-devtools/app.js b/packages/react-devtools/app.js index 2153fad0e0703..32a7f5abb2ef9 100644 --- a/packages/react-devtools/app.js +++ b/packages/react-devtools/app.js @@ -40,9 +40,9 @@ app.on('ready', function () { } // https://stackoverflow.com/questions/32402327/ - mainWindow.webContents.on('new-window', function (event, url) { - event.preventDefault(); + mainWindow.webContents.setWindowOpenHandler(({ url }) => { require('electron').shell.openExternal(url); + return { action: 'deny' }; }); // and load the index.html of the app. From fa1747634bb671741f1fc785e63729965d3286d1 Mon Sep 17 00:00:00 2001 From: root Date: Thu, 6 Apr 2023 07:54:31 +0300 Subject: [PATCH 2/2] Import shell and run yarn prettier-all --- packages/react-devtools/app.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/react-devtools/app.js b/packages/react-devtools/app.js index 32a7f5abb2ef9..3912a80ef09d5 100644 --- a/packages/react-devtools/app.js +++ b/packages/react-devtools/app.js @@ -5,7 +5,7 @@ * LICENSE file in the root directory of this source tree. */ -const {app, BrowserWindow} = require('electron'); // Module to create native browser window. +const {app, BrowserWindow, shell} = require('electron'); // Module to create native browser window. const {join} = require('path'); const os = require('os'); @@ -40,9 +40,9 @@ app.on('ready', function () { } // https://stackoverflow.com/questions/32402327/ - mainWindow.webContents.setWindowOpenHandler(({ url }) => { - require('electron').shell.openExternal(url); - return { action: 'deny' }; + mainWindow.webContents.setWindowOpenHandler(({url}) => { + shell.openExternal(url); + return {action: 'deny'}; }); // and load the index.html of the app.