From 61caae4d054bbce8b41ee958d34abaadd4833375 Mon Sep 17 00:00:00 2001 From: Christophe Date: Tue, 5 Mar 2024 18:38:38 +0100 Subject: [PATCH] Fix GTX_norm cyclic include --- glm/gtx/norm.hpp | 1 - test/gtx/gtx_norm.cpp | 28 ++++++++++++++++------------ 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/glm/gtx/norm.hpp b/glm/gtx/norm.hpp index d6724a80b..ba6958bf5 100644 --- a/glm/gtx/norm.hpp +++ b/glm/gtx/norm.hpp @@ -16,7 +16,6 @@ // Dependency: #include "../geometric.hpp" -#include "../gtx/quaternion.hpp" #include "../gtx/component_wise.hpp" #ifndef GLM_ENABLE_EXPERIMENTAL diff --git a/test/gtx/gtx_norm.cpp b/test/gtx/gtx_norm.cpp index cc5fe4fc2..1fff0e74b 100644 --- a/test/gtx/gtx_norm.cpp +++ b/test/gtx/gtx_norm.cpp @@ -1,5 +1,9 @@ #define GLM_ENABLE_EXPERIMENTAL #include +#include +#include +#include +#include static int test_lMaxNorm() { @@ -7,12 +11,12 @@ static int test_lMaxNorm() { float norm = glm::lMaxNorm(glm::vec3(-1, -2, -3)); - Error += glm::epsilonEqual(norm, 3.f, 0.00001f) ? 0 : 1; + Error += glm::equal(norm, 3.f, 0.00001f) ? 0 : 1; } { float norm = glm::lMaxNorm(glm::vec3(2, 3, 1)); - Error += glm::epsilonEqual(norm, 3.f, 0.00001f) ? 0 : 1; + Error += glm::equal(norm, 3.f, 0.00001f) ? 0 : 1; } return Error; @@ -26,44 +30,44 @@ static int test_lxNorm() unsigned int depth_1 = 1; float normA = glm::lxNorm(glm::vec3(2, 3, 1), depth_1); float normB = glm::l1Norm(glm::vec3(2, 3, 1)); - Error += glm::epsilonEqual(normA, normB, 0.00001f) ? 0 : 1; - Error += glm::epsilonEqual(normA, 6.f, 0.00001f) ? 0 : 1; + Error += glm::equal(normA, normB, 0.00001f) ? 0 : 1; + Error += glm::equal(normA, 6.f, 0.00001f) ? 0 : 1; } { unsigned int depth_1 = 1; float normA = glm::lxNorm(glm::vec3(-1, -2, -3), depth_1); float normB = glm::l1Norm(glm::vec3(-1, -2, -3)); - Error += glm::epsilonEqual(normA, normB, 0.00001f) ? 0 : 1; - Error += glm::epsilonEqual(normA, 6.f, 0.00001f) ? 0 : 1; + Error += glm::equal(normA, normB, 0.00001f) ? 0 : 1; + Error += glm::equal(normA, 6.f, 0.00001f) ? 0 : 1; } { unsigned int depth_2 = 2; float normA = glm::lxNorm(glm::vec3(2, 3, 1), depth_2); float normB = glm::l2Norm(glm::vec3(2, 3, 1)); - Error += glm::epsilonEqual(normA, normB, 0.00001f) ? 0 : 1; - Error += glm::epsilonEqual(normA, 3.741657387f, 0.00001f) ? 0 : 1; + Error += glm::equal(normA, normB, 0.00001f) ? 0 : 1; + Error += glm::equal(normA, 3.741657387f, 0.00001f) ? 0 : 1; } { unsigned int depth_2 = 2; float normA = glm::lxNorm(glm::vec3(-1, -2, -3), depth_2); float normB = glm::l2Norm(glm::vec3(-1, -2, -3)); - Error += glm::epsilonEqual(normA, normB, 0.00001f) ? 0 : 1; - Error += glm::epsilonEqual(normA, 3.741657387f, 0.00001f) ? 0 : 1; + Error += glm::equal(normA, normB, 0.00001f) ? 0 : 1; + Error += glm::equal(normA, 3.741657387f, 0.00001f) ? 0 : 1; } { unsigned int oddDepth = 3; float norm = glm::lxNorm(glm::vec3(2, 3, 1), oddDepth); - Error += glm::epsilonEqual(norm, 3.301927249f, 0.00001f) ? 0 : 1; + Error += glm::equal(norm, 3.301927249f, 0.00001f) ? 0 : 1; } { unsigned int oddDepth = 3; float norm = glm::lxNorm(glm::vec3(-1, -2, -3), oddDepth); - Error += glm::epsilonEqual(norm, 3.301927249f, 0.00001f) ? 0 : 1; + Error += glm::equal(norm, 3.301927249f, 0.00001f) ? 0 : 1; } return Error;