From bb14e9ade0b86d3f0c60f432e04aa7474c69a367 Mon Sep 17 00:00:00 2001 From: Louise Poubel Date: Thu, 30 Sep 2021 19:15:15 -0700 Subject: [PATCH] more PR feedback Signed-off-by: Louise Poubel --- src/GuiEvents.cc | 6 +++--- src/plugins/minimal_scene/MinimalScene.cc | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/GuiEvents.cc b/src/GuiEvents.cc index ab9b4fcf8..16cacc25b 100644 --- a/src/GuiEvents.cc +++ b/src/GuiEvents.cc @@ -120,19 +120,19 @@ class ignition::gui::events::DropOnScene::Implementation class ignition::gui::events::ScrollOnScene::Implementation { - /// \brief Mouse event + /// \brief Mouse event with scroll information. public: common::MouseEvent mouse; }; class ignition::gui::events::DragOnScene::Implementation { - /// \brief The 2D point over which the user is hovering. + /// \brief Mouse event with drag information. public: common::MouseEvent mouse; }; class ignition::gui::events::MousePressOnScene::Implementation { - /// \brief Mouse event + /// \brief Mouse event with press information. public: common::MouseEvent mouse; }; diff --git a/src/plugins/minimal_scene/MinimalScene.cc b/src/plugins/minimal_scene/MinimalScene.cc index ddc8ec593..3e7fe3174 100644 --- a/src/plugins/minimal_scene/MinimalScene.cc +++ b/src/plugins/minimal_scene/MinimalScene.cc @@ -488,7 +488,7 @@ void IgnRenderer::BroadcastKeyRelease() ///////////////////////////////////////////////// void IgnRenderer::BroadcastKeyPress() { - if (this->dataPtr->keyEvent.Type() == common::KeyEvent::PRESS) + if (this->dataPtr->keyEvent.Type() != common::KeyEvent::PRESS) return; events::KeyPressOnScene keyPress(this->dataPtr->keyEvent);