From 997afee315d06430e3dce8fe07a661e92cfd22b6 Mon Sep 17 00:00:00 2001
From: Davis Bennett <davis.v.bennett@gmail.com>
Date: Tue, 23 Jul 2024 22:17:20 +0200
Subject: [PATCH] fix(datasource/zarr) `HEAD` to get content length (#611)

Use a HEAD request as fallback for http 206 status with no content-length.
---
 src/kvstore/special/index.ts | 64 +++++++++++++++++++++---------------
 1 file changed, 38 insertions(+), 26 deletions(-)

diff --git a/src/kvstore/special/index.ts b/src/kvstore/special/index.ts
index d3fc9e9a9..22423b00e 100644
--- a/src/kvstore/special/index.ts
+++ b/src/kvstore/special/index.ts
@@ -51,6 +51,33 @@ class SpecialProtocolKvStore implements ReadableKvStore {
     public credentialsProvider: SpecialProtocolCredentialsProvider,
     public baseUrl: string,
   ) {}
+
+  async getObjectLength(url: string, options: ReadOptions) {
+    // Use a HEAD request to get the length of an object
+    const { cancellationToken = uncancelableToken } = options;
+    const headResponse = await cancellableFetchSpecialOk(
+      this.credentialsProvider,
+      url,
+      { method: "HEAD" },
+      async (response) => response,
+      cancellationToken,
+    );
+
+    if (headResponse.status !== 200) {
+      throw new Error(
+        "Failed to determine total size in order to fetch suffix",
+      );
+    }
+    const contentLength = headResponse.headers.get("content-length");
+    if (contentLength === undefined) {
+      throw new Error(
+        "Failed to determine total size in order to fetch suffix",
+      );
+    }
+    const contentLengthNumber = Number(contentLength);
+    return contentLengthNumber;
+  }
+
   async read(
     key: string,
     options: ReadOptions,
@@ -83,14 +110,17 @@ class SpecialProtocolKvStore implements ReadableKvStore {
           if (contentRange === null) {
             if (byteRangeRequest !== undefined) {
               if ("suffixLength" in byteRangeRequest) {
-                throw new Error(
-                  "Content-range header not provided with HTTP 206 response.  Check server CORS configuration.",
-                );
+                const objectSize = await this.getObjectLength(url, options);
+                byteRange = {
+                  offset: objectSize - byteRangeRequest.suffixLength,
+                  length: Number(response.headers.get("content-length")),
+                };
+              } else {
+                byteRange = {
+                  offset: byteRangeRequest.offset,
+                  length: data.byteLength,
+                };
               }
-              byteRange = {
-                offset: byteRangeRequest.offset,
-                length: data.byteLength,
-              };
             } else {
               throw new Error(
                 "Unexpected HTTP 206 response when no byte range specified.",
@@ -134,25 +164,7 @@ class SpecialProtocolKvStore implements ReadableKvStore {
         ) {
           // Some servers, such as the npm http-server package, do not support suffixLength
           // byte-range requests.
-          const headResponse = await cancellableFetchSpecialOk(
-            this.credentialsProvider,
-            url,
-            { method: "HEAD" },
-            async (response) => response,
-            cancellationToken,
-          );
-          if (headResponse.status !== 200) {
-            throw new Error(
-              "Failed to determine total size in order to fetch suffix",
-            );
-          }
-          const contentLength = headResponse.headers.get("content-length");
-          if (contentLength === undefined) {
-            throw new Error(
-              "Failed to determine total size in order to fetch suffix",
-            );
-          }
-          const contentLengthNumber = Number(contentLength);
+          const contentLengthNumber = await this.getObjectLength(url, options);
           byteRangeRequest = composeByteRangeRequest(
             { offset: 0, length: contentLengthNumber },
             byteRangeRequest,