From 1f057f7ab372ed72b612f771ad87283359342920 Mon Sep 17 00:00:00 2001 From: Tom Elliff Date: Fri, 22 Jun 2018 00:58:11 +0100 Subject: [PATCH] Raise an error when failing to retrieve RDS instance tags Just logging the error means that if the user is unable to call the ListTagsForResource API endpoint then they will see a diff showing that they need to add the tags each time. Instead it's better to actually error instead of hiding this from the user (unless they happen to check the logs). Closes https://github.com/terraform-providers/terraform-provider-aws/issues/345 --- aws/resource_aws_db_instance.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aws/resource_aws_db_instance.go b/aws/resource_aws_db_instance.go index f06ad81e79d7..ccd154014b3d 100644 --- a/aws/resource_aws_db_instance.go +++ b/aws/resource_aws_db_instance.go @@ -1035,7 +1035,7 @@ func resourceAwsDbInstanceRead(d *schema.ResourceData, meta interface{}) error { }) if err != nil { - log.Printf("[DEBUG] Error retrieving tags for ARN: %s", arn) + return fmt.Errorf("Error retrieving tags for ARN: %s", arn) } var dt []*rds.Tag