From d97a1ca6f44c7aa62d44f596208bbdad4b3a7e59 Mon Sep 17 00:00:00 2001
From: Oleg Nenashev <o.v.nenashev@gmail.com>
Date: Fri, 23 Feb 2018 18:53:08 +0100
Subject: [PATCH 1/3] Run FindBugs by default in components

---
 pom.xml | 39 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 38 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index fcd70bc..4145e33 100644
--- a/pom.xml
+++ b/pom.xml
@@ -589,6 +589,30 @@
     </pluginManagement>
 
     <plugins>
+      <plugin>
+        <groupId>org.codehaus.mojo</groupId>
+        <artifactId>findbugs-maven-plugin</artifactId>
+        <configuration>
+          <failOnError>${findbugs.failOnError}</failOnError>
+          <!--  Do not define excludeFilterFile here as it will force a plugin to provide a file -->
+          <!--  Instead we configure this in a profile -->
+          <xmlOutput>true</xmlOutput>
+          <findbugsXmlOutput>false</findbugsXmlOutput>
+          <effort>${findbugs.effort}</effort>
+          <threshold>${findbugs.threshold}</threshold>
+          <excludeFilterFile>${findbugs.excludeFilterFile}</excludeFilterFile>
+        </configuration>
+        <executions>
+          <execution>
+            <id>findbugs</id>
+            <goals>
+              <goal>check</goal>
+            </goals>
+            <phase>verify</phase>
+          </execution>
+        </executions>
+      </plugin>
+
       <plugin>
         <artifactId>maven-enforcer-plugin</artifactId>
         <executions>
@@ -718,6 +742,20 @@
     <!-- Use only if strictly necessary. It may cause problems in your IDE. -->
     <java.level.test>${java.level}</java.level.test>
 
+    <findbugs-maven-plugin.version>3.0.5</findbugs-maven-plugin.version>
+    <!-- Whether the build should fail if findbugs finds any error. -->
+    <!-- It is strongly encouraged to leave it as true. Use false with care only in transient situations. -->
+    <findbugs.failOnError>true</findbugs.failOnError>
+    <!-- Defines a FindBugs threshold. Use "Low" to discover low-priority bugs.
+         Hint: FindBugs considers some real NPE risks in Jenkins as low-priority issues, it is recommended to enable it in plugins.
+      -->
+    <findbugs.threshold>Medium</findbugs.threshold>
+    <!-- Defines a FindBugs effort. Use "Max" to maximize the scan depth -->
+    <findbugs.effort>default</findbugs.effort>
+    <!-- Defines an optional FindBugs excludes file.
+         Generally it is recommended to use @SuppressFBWarnings annotation unless you want to ignore an entire class of issues -->
+    <findbugs.excludeFilterFile></findbugs.excludeFilterFile>
+
     <!-- Define all plugin versions as properties so individual hierarchies can easily override -->
     <animal-sniffer-plugin.version>1.16</animal-sniffer-plugin.version>
     <apt-maven-plugin.version>1.0-alpha-5</apt-maven-plugin.version>
@@ -727,7 +765,6 @@
     <cargo-maven2-plugin.version>1.1.2</cargo-maven2-plugin.version>
     <cobertura-maven-plugin.version>2.7</cobertura-maven-plugin.version>
     <exec-maven-plugin.version>1.6.0</exec-maven-plugin.version>
-    <findbugs-maven-plugin.version>3.0.5</findbugs-maven-plugin.version>
     <gmaven-plugin.version>1.5-jenkins-3</gmaven-plugin.version>
     <gwt-maven-plugin.version>2.3.0-1</gwt-maven-plugin.version>
     <javancss-maven-plugin.version>2.1</javancss-maven-plugin.version>

From d8d62c1d055f1ba9e4ba8ca4ddf4ebd2063bcee4 Mon Sep 17 00:00:00 2001
From: Oleg Nenashev <o.v.nenashev@gmail.com>
Date: Fri, 23 Feb 2018 21:29:09 +0100
Subject: [PATCH 2/3] Add FindBugs annotations to the dependency management

---
 pom.xml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/pom.xml b/pom.xml
index 4145e33..c72a44d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -147,6 +147,11 @@
         <artifactId>test-annotations</artifactId>
         <version>1.2</version>
       </dependency>
+      <dependency>
+        <groupId>com.google.code.findbugs</groupId>
+        <artifactId>annotations</artifactId>
+        <version>3.0.1</version>
+      </dependency>
     </dependencies>
   </dependencyManagement>
 

From 181554e89a6336513c667e41db99ae0f137ec3c4 Mon Sep 17 00:00:00 2001
From: Oleg Nenashev <o.v.nenashev@gmail.com>
Date: Fri, 23 Feb 2018 21:35:39 +0100
Subject: [PATCH 3/3] Address comment from @dwnusbaum

---
 pom.xml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index c72a44d..ee0f0eb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -599,12 +599,11 @@
         <artifactId>findbugs-maven-plugin</artifactId>
         <configuration>
           <failOnError>${findbugs.failOnError}</failOnError>
-          <!--  Do not define excludeFilterFile here as it will force a plugin to provide a file -->
-          <!--  Instead we configure this in a profile -->
           <xmlOutput>true</xmlOutput>
           <findbugsXmlOutput>false</findbugsXmlOutput>
           <effort>${findbugs.effort}</effort>
           <threshold>${findbugs.threshold}</threshold>
+          <!-- Empty by default, child POMs are expected to override if needed -->
           <excludeFilterFile>${findbugs.excludeFilterFile}</excludeFilterFile>
         </configuration>
         <executions>