From da789737d4e97c2b47242742009824ba77eb853c Mon Sep 17 00:00:00 2001 From: Richard Barnes Date: Wed, 10 Jul 2024 08:41:35 -0700 Subject: [PATCH] Remove unused-variable in mapillary/opensfm/opensfm/src/geometry/absolute_pose.h Summary: LLVM-15 has a warning `-Wunused-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code or (b) qualifies the variable with `[[maybe_unused]]`. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: fabianschenk Differential Revision: D59586421 fbshipit-source-id: 6a8eece4ed9e6015a73021a0ee3bba4d1a0c49b6 --- opensfm/src/geometry/absolute_pose.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/opensfm/src/geometry/absolute_pose.h b/opensfm/src/geometry/absolute_pose.h index faa7a2633..2de1894b2 100644 --- a/opensfm/src/geometry/absolute_pose.h +++ b/opensfm/src/geometry/absolute_pose.h @@ -28,7 +28,6 @@ std::vector> AbsolutePoseThreePoints(IT begin, // Compute k1, k2 and k3 const Eigen::Vector3d k1 = (p1 - p2).normalized(); const Eigen::Vector3d k3 = (b1.cross(b2)).normalized(); - const Eigen::Vector3d k2 = (k1.cross(k3)).normalized(); // Compute ui and vi for i = 1, 2 const Eigen::Vector3d u1 = p1 - p3; @@ -93,7 +92,6 @@ std::vector> AbsolutePoseThreePoints(IT begin, e1 << 1, 0, 0; e2 << 0, 1, 0; - constexpr double eps = 1e-20; for (const auto &root : roots) { const auto cos_theta_1 = root; const auto sin_theta_1 =