From 17039f1649647ad7d8a72c868bd6f438b2140768 Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Fri, 3 Apr 2020 21:54:43 -0700 Subject: [PATCH] fix(webkit): fix non-mac screenshots w/ dsf (#1665) --- package.json | 2 +- test/golden-utils.js | 2 +- test/screenshot.spec.js | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 0369e1e120c71..5b62a00851a07 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ "playwright": { "chromium_revision": "754895", "firefox_revision": "1069", - "webkit_revision": "1187" + "webkit_revision": "1188" }, "scripts": { "ctest": "cross-env BROWSER=chromium node test/test.js", diff --git a/test/golden-utils.js b/test/golden-utils.js index 71211dbe022eb..b698d8f6c5ea9 100644 --- a/test/golden-utils.js +++ b/test/golden-utils.js @@ -56,7 +56,7 @@ function compareImages(actualBuffer, expectedBuffer, mimeType) { }; } const diff = new PNG({width: expected.width, height: expected.height}); - const count = pixelmatch(expected.data, actual.data, diff.data, expected.width, expected.height, {threshold: 0.15}); + const count = pixelmatch(expected.data, actual.data, diff.data, expected.width, expected.height, {threshold: 0.2}); return count > 0 ? { diff: PNG.sync.write(diff) } : null; } diff --git a/test/screenshot.spec.js b/test/screenshot.spec.js index fba63f023660f..e0059bfe4a44c 100644 --- a/test/screenshot.spec.js +++ b/test/screenshot.spec.js @@ -217,7 +217,7 @@ module.exports.describe = function({testRunner, expect, product, playwright, FFO expect(screenshot).toBeInstanceOf(Buffer); } }); - it.fail(WEBKIT)('should work with device scale factor', async({browser, server}) => { + it('should work with device scale factor', async({browser, server}) => { const context = await browser.newContext({ viewport: { width: 320, height: 480 }, deviceScaleFactor: 2 }); const page = await context.newPage(); await page.goto(server.PREFIX + '/grid.html'); @@ -394,7 +394,7 @@ module.exports.describe = function({testRunner, expect, product, playwright, FFO expect(screenshot).toBeGolden('screenshot-element-mobile.png'); await context.close(); }); - it.fail(WEBKIT && LINUX).skip(FFOX)('should work with device scale factor', async({browser, server}) => { + it.skip(FFOX)('should work with device scale factor', async({browser, server}) => { const context = await browser.newContext({ viewport: { width: 320, height: 480 }, deviceScaleFactor: 2 }); const page = await context.newPage(); await page.goto(server.PREFIX + '/grid.html');