From 29488be296d726f32aaa155e1478a98899e6ba89 Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Fri, 23 Jun 2023 16:52:10 +0200 Subject: [PATCH] PR review status repeats 'pending check' (#4947) Fixes #4942 --- webviews/components/merge.tsx | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/webviews/components/merge.tsx b/webviews/components/merge.tsx index 100577218..4935f7197 100644 --- a/webviews/components/merge.tsx +++ b/webviews/components/merge.tsx @@ -451,20 +451,29 @@ const StatusCheckDetails = ( { statuses }: { statuses: PullRequestCheckStatus[] ); -function getSummaryLabel(statuses: any[]) { - const statusTypes = groupBy(statuses, (status: any) => status.state); +function getSummaryLabel(statuses: PullRequestCheckStatus[]) { + const statusTypes = groupBy(statuses, (status: PullRequestCheckStatus) => { + switch (status.state) { + case CheckState.Success: + case CheckState.Failure: + case CheckState.Neutral: + return status.state; + default: + return CheckState.Pending; + } + }); const statusPhrases: string[] = []; for (const statusType of Object.keys(statusTypes)) { const numOfType = statusTypes[statusType].length; let statusAdjective = ''; switch (statusType) { - case 'success': + case CheckState.Success: statusAdjective = 'successful'; break; - case 'failure': + case CheckState.Failure: statusAdjective = 'failed'; break; - case 'neutral': + case CheckState.Neutral: statusAdjective = 'skipped'; break; default: