From ebc21673c0ac7a2326771679369f4aad974f6fe5 Mon Sep 17 00:00:00 2001 From: fitrah <91102425+fitrahfm@users.noreply.github.com> Date: Wed, 22 Nov 2023 11:46:39 +0000 Subject: [PATCH] feat(Navigation): enable target blank on Administration settings Signed-off-by: Fitrah Munir --- lib/private/NavigationManager.php | 1 + tests/lib/NavigationManagerTest.php | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/private/NavigationManager.php b/lib/private/NavigationManager.php index cac52ab5c9f1c..17424f1b5fe63 100644 --- a/lib/private/NavigationManager.php +++ b/lib/private/NavigationManager.php @@ -294,6 +294,7 @@ private function init() { 'id' => 'admin_settings', 'order' => 4, 'href' => $this->urlGenerator->linkToRoute('settings.AdminSettings.index', ['section' => 'overview']), + 'target' => '_blank', 'name' => $l->t('Administration settings'), 'icon' => $this->urlGenerator->imagePath('settings', 'admin.svg'), ]); diff --git a/tests/lib/NavigationManagerTest.php b/tests/lib/NavigationManagerTest.php index beefc2353d6c9..7571d651d00d0 100644 --- a/tests/lib/NavigationManagerTest.php +++ b/tests/lib/NavigationManagerTest.php @@ -343,7 +343,8 @@ public function providesNavigationConfig() { 'active' => false, 'type' => 'settings', 'classes' => '', - 'unread' => 0 + 'unread' => 0, + 'target' => '_blank', ] ];