From a25b430f37d61e98396987cc55508a220ce03382 Mon Sep 17 00:00:00 2001 From: timdeschryver <28659384+timdeschryver@users.noreply.github.com> Date: Fri, 24 Jul 2020 16:31:02 +0200 Subject: [PATCH] fix(router-store): add safety check to schematic --- modules/component-store/schematics-core/utility/visitors.ts | 2 +- modules/component/schematics-core/utility/visitors.ts | 2 +- modules/data/schematics-core/utility/visitors.ts | 2 +- modules/effects/schematics-core/utility/visitors.ts | 2 +- modules/entity/schematics-core/utility/visitors.ts | 2 +- modules/router-store/schematics-core/utility/visitors.ts | 2 +- modules/schematics-core/utility/visitors.ts | 2 +- modules/schematics/schematics-core/utility/visitors.ts | 2 +- modules/store-devtools/schematics-core/utility/visitors.ts | 2 +- modules/store/schematics-core/utility/visitors.ts | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/modules/component-store/schematics-core/utility/visitors.ts b/modules/component-store/schematics-core/utility/visitors.ts index c4a6af6e83..90d2a3d058 100644 --- a/modules/component-store/schematics-core/utility/visitors.ts +++ b/modules/component-store/schematics-core/utility/visitors.ts @@ -192,7 +192,7 @@ export function visitDecorator( } const [arg] = expression.arguments; - if (!ts.isObjectLiteralExpression(arg)) { + if (!arg || !ts.isObjectLiteralExpression(arg)) { return; } diff --git a/modules/component/schematics-core/utility/visitors.ts b/modules/component/schematics-core/utility/visitors.ts index c4a6af6e83..90d2a3d058 100644 --- a/modules/component/schematics-core/utility/visitors.ts +++ b/modules/component/schematics-core/utility/visitors.ts @@ -192,7 +192,7 @@ export function visitDecorator( } const [arg] = expression.arguments; - if (!ts.isObjectLiteralExpression(arg)) { + if (!arg || !ts.isObjectLiteralExpression(arg)) { return; } diff --git a/modules/data/schematics-core/utility/visitors.ts b/modules/data/schematics-core/utility/visitors.ts index c4a6af6e83..90d2a3d058 100644 --- a/modules/data/schematics-core/utility/visitors.ts +++ b/modules/data/schematics-core/utility/visitors.ts @@ -192,7 +192,7 @@ export function visitDecorator( } const [arg] = expression.arguments; - if (!ts.isObjectLiteralExpression(arg)) { + if (!arg || !ts.isObjectLiteralExpression(arg)) { return; } diff --git a/modules/effects/schematics-core/utility/visitors.ts b/modules/effects/schematics-core/utility/visitors.ts index c4a6af6e83..90d2a3d058 100644 --- a/modules/effects/schematics-core/utility/visitors.ts +++ b/modules/effects/schematics-core/utility/visitors.ts @@ -192,7 +192,7 @@ export function visitDecorator( } const [arg] = expression.arguments; - if (!ts.isObjectLiteralExpression(arg)) { + if (!arg || !ts.isObjectLiteralExpression(arg)) { return; } diff --git a/modules/entity/schematics-core/utility/visitors.ts b/modules/entity/schematics-core/utility/visitors.ts index c4a6af6e83..90d2a3d058 100644 --- a/modules/entity/schematics-core/utility/visitors.ts +++ b/modules/entity/schematics-core/utility/visitors.ts @@ -192,7 +192,7 @@ export function visitDecorator( } const [arg] = expression.arguments; - if (!ts.isObjectLiteralExpression(arg)) { + if (!arg || !ts.isObjectLiteralExpression(arg)) { return; } diff --git a/modules/router-store/schematics-core/utility/visitors.ts b/modules/router-store/schematics-core/utility/visitors.ts index c4a6af6e83..90d2a3d058 100644 --- a/modules/router-store/schematics-core/utility/visitors.ts +++ b/modules/router-store/schematics-core/utility/visitors.ts @@ -192,7 +192,7 @@ export function visitDecorator( } const [arg] = expression.arguments; - if (!ts.isObjectLiteralExpression(arg)) { + if (!arg || !ts.isObjectLiteralExpression(arg)) { return; } diff --git a/modules/schematics-core/utility/visitors.ts b/modules/schematics-core/utility/visitors.ts index c4a6af6e83..90d2a3d058 100644 --- a/modules/schematics-core/utility/visitors.ts +++ b/modules/schematics-core/utility/visitors.ts @@ -192,7 +192,7 @@ export function visitDecorator( } const [arg] = expression.arguments; - if (!ts.isObjectLiteralExpression(arg)) { + if (!arg || !ts.isObjectLiteralExpression(arg)) { return; } diff --git a/modules/schematics/schematics-core/utility/visitors.ts b/modules/schematics/schematics-core/utility/visitors.ts index c4a6af6e83..90d2a3d058 100644 --- a/modules/schematics/schematics-core/utility/visitors.ts +++ b/modules/schematics/schematics-core/utility/visitors.ts @@ -192,7 +192,7 @@ export function visitDecorator( } const [arg] = expression.arguments; - if (!ts.isObjectLiteralExpression(arg)) { + if (!arg || !ts.isObjectLiteralExpression(arg)) { return; } diff --git a/modules/store-devtools/schematics-core/utility/visitors.ts b/modules/store-devtools/schematics-core/utility/visitors.ts index c4a6af6e83..90d2a3d058 100644 --- a/modules/store-devtools/schematics-core/utility/visitors.ts +++ b/modules/store-devtools/schematics-core/utility/visitors.ts @@ -192,7 +192,7 @@ export function visitDecorator( } const [arg] = expression.arguments; - if (!ts.isObjectLiteralExpression(arg)) { + if (!arg || !ts.isObjectLiteralExpression(arg)) { return; } diff --git a/modules/store/schematics-core/utility/visitors.ts b/modules/store/schematics-core/utility/visitors.ts index c4a6af6e83..90d2a3d058 100644 --- a/modules/store/schematics-core/utility/visitors.ts +++ b/modules/store/schematics-core/utility/visitors.ts @@ -192,7 +192,7 @@ export function visitDecorator( } const [arg] = expression.arguments; - if (!ts.isObjectLiteralExpression(arg)) { + if (!arg || !ts.isObjectLiteralExpression(arg)) { return; }