From 11c674549bb706f0c71a067042f981f0a00eac3d Mon Sep 17 00:00:00 2001 From: Vse Mozhet Byt Date: Thu, 4 Oct 2018 01:12:23 +0300 Subject: [PATCH] doc: update author-ready label terms PR-URL: https://github.com/nodejs/node/pull/23249 Refs: https://github.com/nodejs/node/pull/22255 Reviewed-By: Refael Ackermann Reviewed-By: Rich Trott Reviewed-By: Trivikram Kamat Reviewed-By: Gireesh Punathil Reviewed-By: Sakthipriyan Vairamani --- COLLABORATOR_GUIDE.md | 9 +++++---- doc/onboarding.md | 3 ++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index fb1b5182b37725..7a435c6478bf45 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -83,10 +83,11 @@ necessary. ### Author ready pull requests A pull request that is still awaiting the minimum review time is considered -_author ready_ as soon as the CI has been started, it has at least one approval, -and it has no outstanding review comments. Please always make sure to add the -`author ready` label to the PR in that case and remove it again as soon as that -condition is not met anymore. +_author ready_ as soon as the CI has been started, it has at least two approvals +(one Collaborator approval is enough if the pull request has been open for more +than 7 days), and it has no outstanding review comments. Please always make sure +to add the `author ready` label to the PR in that case and remove it again as +soon as that condition is not met anymore. ### Handling own pull requests diff --git a/doc/onboarding.md b/doc/onboarding.md index 0c46318a7857bb..b08aabfff7d74e 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -99,7 +99,8 @@ onboarding session. * Please add the `author-ready` label for PRs where: * the CI has been started (not necessarily finished), * no outstanding review comments exist and - * at least one collaborator approved the PR. + * at least two Collaborators approved the PR (one Collaborator approval is + enough if the pull request has been open for more than 7 days). * See [Who to CC in the issue tracker][who-to-cc]. * This will come more naturally over time