From e41e9900388d67fd88defe1d686db6d7fbe1f000 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Thu, 4 Aug 2022 16:29:47 -0400 Subject: [PATCH] doc: add missing step for llhttp update Refs: https://github.com/nodejs/node/issues/43946 - Add instructions on updating llhttp version in file maintained only in Node.js repository as it needs to be kept in sync with what is copied from the llhttp repository when an update is made. Signed-off-by: Michael Dawson --- doc/contributing/maintaining-http.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/contributing/maintaining-http.md b/doc/contributing/maintaining-http.md index 2888367d861103..5e27381c3071e3 100644 --- a/doc/contributing/maintaining-http.md +++ b/doc/contributing/maintaining-http.md @@ -87,6 +87,8 @@ In order to update Node.js with a new version of llhttp: * copy the contents of the `release` directory from the directory you checked llhttp out to [deps/llhttp](https://github.com/nodejs/node/tree/HEAD/deps/llhttp) +* update the llhttp version number in the project line in CMakeLists.txt + to match that set in include/llhttp.h It should look like the following: