From 6ee703d12a4f1874493ead2be8de207928ca9cb4 Mon Sep 17 00:00:00 2001 From: Chris Sidi Date: Mon, 5 Aug 2024 16:16:56 -0400 Subject: [PATCH] fix: Don't restrict length for commit message footer (#467) Our breaking change footers related to engine changes are often >100 characters, resulting in commitlint CI failures. Example CI failure: https://github.com/npm/ssri/actions/runs/10169599799/job/28126863705#step:7:12 Associated PR: https://github.com/npm/ssri/pull/137 --- .commitlintrc.js | 1 + lib/content/commitlintrc-js.hbs | 1 + tap-snapshots/test/apply/source-snapshots.js.test.cjs | 2 ++ 3 files changed, 4 insertions(+) diff --git a/.commitlintrc.js b/.commitlintrc.js index e9c80b92..b706e527 100644 --- a/.commitlintrc.js +++ b/.commitlintrc.js @@ -7,5 +7,6 @@ module.exports = { 'header-max-length': [2, 'always', 80], 'subject-case': [0], 'body-max-line-length': [0], + 'footer-max-line-length': [0], }, } diff --git a/lib/content/commitlintrc-js.hbs b/lib/content/commitlintrc-js.hbs index 8b19e3fa..12d63d34 100644 --- a/lib/content/commitlintrc-js.hbs +++ b/lib/content/commitlintrc-js.hbs @@ -5,5 +5,6 @@ module.exports = { 'header-max-length': [2, 'always', 80], 'subject-case': [0], 'body-max-line-length': [0], + 'footer-max-line-length': [0], }, } diff --git a/tap-snapshots/test/apply/source-snapshots.js.test.cjs b/tap-snapshots/test/apply/source-snapshots.js.test.cjs index bba9adb9..5c39d2f1 100644 --- a/tap-snapshots/test/apply/source-snapshots.js.test.cjs +++ b/tap-snapshots/test/apply/source-snapshots.js.test.cjs @@ -17,6 +17,7 @@ module.exports = { 'header-max-length': [2, 'always', 80], 'subject-case': [0], 'body-max-line-length': [0], + 'footer-max-line-length': [0], }, } @@ -1455,6 +1456,7 @@ module.exports = { 'header-max-length': [2, 'always', 80], 'subject-case': [0], 'body-max-line-length': [0], + 'footer-max-line-length': [0], }, }