From cbce81946617e965c44146ff1e2f8cb96cfd6f08 Mon Sep 17 00:00:00 2001 From: David Fowler Date: Tue, 21 Feb 2023 19:51:00 -0800 Subject: [PATCH 1/2] Clean up Program.cs Removed unnecessary API calls and added await. --- src/cartservice/src/Program.cs | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/src/cartservice/src/Program.cs b/src/cartservice/src/Program.cs index 18f85eff6e..0fc7bfa7a8 100644 --- a/src/cartservice/src/Program.cs +++ b/src/cartservice/src/Program.cs @@ -37,7 +37,7 @@ cartStore = new RedisCartStore(redisAddress); // Initialize the redis store -cartStore.InitializeAsync().GetAwaiter().GetResult(); +await cartStore.InitializeAsync(); Console.WriteLine("Initialization completed"); builder.Services.AddSingleton(cartStore); @@ -72,22 +72,12 @@ var app = builder.Build(); -if (app.Environment.IsDevelopment()) - { - app.UseDeveloperExceptionPage(); - } +app.MapGrpcService(); +app.MapGrpcHealthChecksService(); -app.UseRouting(); - -app.UseEndpoints(endpoints => +app.MapGet("/", async context => { - endpoints.MapGrpcService(); - endpoints.MapGrpcHealthChecksService(); - - endpoints.MapGet("/", async context => - { - await context.Response.WriteAsync("Communication with gRPC endpoints must be made through a gRPC client. To learn how to create a client, visit: https://go.microsoft.com/fwlink/?linkid=2086909"); - }); + await context.Response.WriteAsync("Communication with gRPC endpoints must be made through a gRPC client. To learn how to create a client, visit: https://go.microsoft.com/fwlink/?linkid=2086909"); }); app.Run(); From 6ee99d422032e571107fa63a19b5fbae065ccb19 Mon Sep 17 00:00:00 2001 From: David Fowler Date: Wed, 22 Feb 2023 07:05:08 -0800 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d0dd30b231..b763b6292e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ release. ([#729](https://github.com/open-telemetry/opentelemetry-demo/issues/729)) * rename proto package from hipstershop to oteldemo ([#740](https://github.com/open-telemetry/opentelemetry-demo/pull/740)) +* Removed unnecessary code from Program.cs ## v0.1.0