diff --git a/ecommerce/extensions/api/serializers.py b/ecommerce/extensions/api/serializers.py index 9336dbfdc41..ea0ff29b6dc 100644 --- a/ecommerce/extensions/api/serializers.py +++ b/ecommerce/extensions/api/serializers.py @@ -956,6 +956,7 @@ class VoucherSerializer(serializers.ModelSerializer): is_available_to_user = serializers.SerializerMethodField() benefit = serializers.SerializerMethodField() redeem_url = serializers.SerializerMethodField() + end_datetime = serializers.DateTimeField(format=ISO_8601_FORMAT) def get_is_available_to_user(self, obj): request = self.context.get('request') diff --git a/ecommerce/extensions/api/v2/tests/views/test_vouchers.py b/ecommerce/extensions/api/v2/tests/views/test_vouchers.py index 8bed8b0d908..761ac98d1e5 100644 --- a/ecommerce/extensions/api/v2/tests/views/test_vouchers.py +++ b/ecommerce/extensions/api/v2/tests/views/test_vouchers.py @@ -68,6 +68,30 @@ def create_vouchers(self, partner=None, count=1): coupon_vouchers.vouchers.add(voucher) return vouchers + def test_generate_correct_end_datetime(self): + """ + Test that the 'end_datetime' parameter is generated in the correct format. + + The 'end_datetime' parameter should be generated as a string in the + format '%Y-%m-%dT%H:%M:%SZ', representing the end date and time. + The created voucher's 'end_datetime' has the milliseconds part if to + retrieve it directly from the DB. + """ + self.create_vouchers() + response = self.client.get(self.path) + response_data = response.json() + result = response_data['results'][0] + end_datetime = result['end_datetime'] + is_valid_format = False + + try: + datetime.datetime.strptime(end_datetime, '%Y-%m-%dT%H:%M:%SZ') + is_valid_format = True + except ValueError: + pass + + self.assertTrue(is_valid_format) + def test_list(self): """ Verify the endpoint lists all vouchers. """ vouchers = self.create_vouchers(count=3)