From 65b0ff1cb3b17f56ba7f641a6dc481eda5ad66aa Mon Sep 17 00:00:00 2001 From: Garrett Moon Date: Fri, 28 Feb 2020 16:25:53 -0800 Subject: [PATCH 1/4] Check if analyze failed --- .github/workflows/ci.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 24e4dc4..db5cd9d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,7 +28,11 @@ jobs: -scheme PINOperation \ ONLY_ACTIVE_ARCH=NO \ CODE_SIGNING_REQUIRED=NO \ + CLANG_ANALYZER_OUTPUT=plist-html \ + CLANG_ANALYZER_OUTPUT_DIR="$(shell pwd)/clang" \ | xcpretty + if [[ -n `find $(shell pwd)/clang -name "*.html"` ]] ; then rm -rf `pwd`/clang; exit 1; fi + rm -rf $(shell pwd)/clang cocoapods: name: CocoaPods runs-on: macOS-latest From 2159d02826abfeeae1e7fb2f2ebeebc513a2af55 Mon Sep 17 00:00:00 2001 From: Garrett Moon Date: Fri, 28 Feb 2020 16:26:19 -0800 Subject: [PATCH 2/4] Add an analyzer error --- Source/PINOperationQueue.m | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Source/PINOperationQueue.m b/Source/PINOperationQueue.m index 5d0a38f..ddbe6c5 100644 --- a/Source/PINOperationQueue.m +++ b/Source/PINOperationQueue.m @@ -377,6 +377,12 @@ - (void)scheduleNextOperations:(BOOL)onlyCheckSerial [self lock]; PINOperation *operation = [self locked_nextOperationByPriority]; [self unlock]; + + NSString *test = @"Great!"; + + if (YES) { + test = @"super great"; + } if (operation) { dispatch_async(self->_concurrentQueue, ^{ From 3bf70a7c725305c5e53d5d19c7a243a6ac4c7579 Mon Sep 17 00:00:00 2001 From: Garrett Moon Date: Fri, 28 Feb 2020 16:30:56 -0800 Subject: [PATCH 3/4] fix shell command not found --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index db5cd9d..d4b5dbf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -29,10 +29,10 @@ jobs: ONLY_ACTIVE_ARCH=NO \ CODE_SIGNING_REQUIRED=NO \ CLANG_ANALYZER_OUTPUT=plist-html \ - CLANG_ANALYZER_OUTPUT_DIR="$(shell pwd)/clang" \ + CLANG_ANALYZER_OUTPUT_DIR="$(pwd)/clang" \ | xcpretty - if [[ -n `find $(shell pwd)/clang -name "*.html"` ]] ; then rm -rf `pwd`/clang; exit 1; fi - rm -rf $(shell pwd)/clang + if [[ -n `find $(pwd)/clang -name "*.html"` ]] ; then rm -rf $(pwd)/clang; exit 1; fi + rm -rf $(pwd)/clang cocoapods: name: CocoaPods runs-on: macOS-latest From aa57e9e9837a6b15e94745a9faa0bcef25285624 Mon Sep 17 00:00:00 2001 From: Garrett Moon Date: Fri, 28 Feb 2020 16:32:49 -0800 Subject: [PATCH 4/4] Revert "Add an analyzer error" This reverts commit 2159d02826abfeeae1e7fb2f2ebeebc513a2af55. --- Source/PINOperationQueue.m | 6 ------ 1 file changed, 6 deletions(-) diff --git a/Source/PINOperationQueue.m b/Source/PINOperationQueue.m index ddbe6c5..5d0a38f 100644 --- a/Source/PINOperationQueue.m +++ b/Source/PINOperationQueue.m @@ -377,12 +377,6 @@ - (void)scheduleNextOperations:(BOOL)onlyCheckSerial [self lock]; PINOperation *operation = [self locked_nextOperationByPriority]; [self unlock]; - - NSString *test = @"Great!"; - - if (YES) { - test = @"super great"; - } if (operation) { dispatch_async(self->_concurrentQueue, ^{