From 875003a735fdd6334782250d15baa8142896a9a5 Mon Sep 17 00:00:00 2001
From: "Jason R. Coombs" <jaraco@jaraco.com>
Date: Thu, 1 Aug 2024 15:48:57 -0400
Subject: [PATCH] Disallow passing of 'dist' to EntryPoints.select.

Closes python/cpython#107220.
---
 importlib_metadata/__init__.py      | 17 +++++++++++++++++
 newsfragments/+29a322e3.feature.rst |  1 +
 2 files changed, 18 insertions(+)
 create mode 100644 newsfragments/+29a322e3.feature.rst

diff --git a/importlib_metadata/__init__.py b/importlib_metadata/__init__.py
index 2eefb1d6..9a96d061 100644
--- a/importlib_metadata/__init__.py
+++ b/importlib_metadata/__init__.py
@@ -227,9 +227,26 @@ def matches(self, **params):
         >>> ep.matches(attr='bong')
         True
         """
+        self._disallow_dist(params)
         attrs = (getattr(self, param) for param in params)
         return all(map(operator.eq, params.values(), attrs))
 
+    @staticmethod
+    def _disallow_dist(params):
+        """
+        Querying by dist is not allowed (dist objects are not comparable).
+        >>> EntryPoint(name='fan', value='fav', group='fag').matches(dist='foo')
+        Traceback (most recent call last):
+        ...
+        ValueError: "dist" is not suitable for matching...
+        """
+        if "dist" in params:
+            raise ValueError(
+                '"dist" is not suitable for matching. '
+                "Instead, use Distribution.entry_points.select() on a "
+                "located distribution."
+            )
+
     def _key(self):
         return self.name, self.value, self.group
 
diff --git a/newsfragments/+29a322e3.feature.rst b/newsfragments/+29a322e3.feature.rst
new file mode 100644
index 00000000..0e80b746
--- /dev/null
+++ b/newsfragments/+29a322e3.feature.rst
@@ -0,0 +1 @@
+Disallow passing of 'dist' to EntryPoints.select.
\ No newline at end of file