From 7ff936bd2d00e8bc2ac1445d1f537443d1460eb3 Mon Sep 17 00:00:00 2001 From: Charles Lew Date: Fri, 1 May 2020 10:43:34 +0800 Subject: [PATCH] Switch `confusable_idents` lint to warn. --- src/liballoc/tests/lib.rs | 1 + src/libcore/lib.rs | 1 + src/libcore/tests/lib.rs | 1 + src/librustc_ast/lib.rs | 1 + src/librustc_ast_lowering/lib.rs | 1 + src/librustc_codegen_ssa/lib.rs | 1 + src/librustc_data_structures/lib.rs | 1 + src/librustc_expand/lib.rs | 1 + src/librustc_hir/lib.rs | 1 + src/librustc_incremental/lib.rs | 1 + src/librustc_infer/lib.rs | 1 + src/librustc_lint/non_ascii_idents.rs | 3 +-- src/librustc_metadata/lib.rs | 1 + src/librustc_middle/lib.rs | 1 + src/librustc_mir/lib.rs | 1 + src/librustc_mir_build/lib.rs | 1 + src/librustc_trait_selection/lib.rs | 1 + src/librustc_typeck/lib.rs | 1 + src/librustdoc/lib.rs | 1 + src/libserialize/lib.rs | 1 + src/libstd/lib.rs | 1 + src/test/ui/issues/issue-40003.rs | 1 + 22 files changed, 22 insertions(+), 2 deletions(-) diff --git a/src/liballoc/tests/lib.rs b/src/liballoc/tests/lib.rs index 78d49558262e3..7bef69a065f44 100644 --- a/src/liballoc/tests/lib.rs +++ b/src/liballoc/tests/lib.rs @@ -15,6 +15,7 @@ #![feature(vec_remove_item)] #![feature(split_inclusive)] #![feature(binary_heap_retain)] +#![allow(unknown_lints, confusable_idents)] use std::collections::hash_map::DefaultHasher; use std::hash::{Hash, Hasher}; diff --git a/src/libcore/lib.rs b/src/libcore/lib.rs index 3b7929f00168a..b2e6b72581f2d 100644 --- a/src/libcore/lib.rs +++ b/src/libcore/lib.rs @@ -62,6 +62,7 @@ #![warn(missing_docs)] #![warn(missing_debug_implementations)] #![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings +#![allow(unknown_lints, confusable_idents)] #![allow(explicit_outlives_requirements)] #![allow(incomplete_features)] #![feature(allow_internal_unstable)] diff --git a/src/libcore/tests/lib.rs b/src/libcore/tests/lib.rs index e7d36d327cd89..2a529a6703f4b 100644 --- a/src/libcore/tests/lib.rs +++ b/src/libcore/tests/lib.rs @@ -43,6 +43,7 @@ #![feature(leading_trailing_ones)] #![feature(const_forget)] #![feature(option_unwrap_none)] +#![allow(unknown_lints, confusable_idents)] extern crate test; diff --git a/src/librustc_ast/lib.rs b/src/librustc_ast/lib.rs index f81622d091400..52c0a13e9c8e3 100644 --- a/src/librustc_ast/lib.rs +++ b/src/librustc_ast/lib.rs @@ -18,6 +18,7 @@ #![feature(try_trait)] #![feature(unicode_internals)] #![recursion_limit = "256"] +#![allow(unknown_lints, confusable_idents)] #[macro_export] macro_rules! unwrap_or { diff --git a/src/librustc_ast_lowering/lib.rs b/src/librustc_ast_lowering/lib.rs index 47dd757823be2..c4bdf262b1d0f 100644 --- a/src/librustc_ast_lowering/lib.rs +++ b/src/librustc_ast_lowering/lib.rs @@ -36,6 +36,7 @@ #![feature(specialization)] #![feature(or_patterns)] #![recursion_limit = "256"] +#![allow(unknown_lints, confusable_idents)] use rustc_ast::ast; use rustc_ast::ast::*; diff --git a/src/librustc_codegen_ssa/lib.rs b/src/librustc_codegen_ssa/lib.rs index 7dc09b595c36e..70e8e24e4e7ae 100644 --- a/src/librustc_codegen_ssa/lib.rs +++ b/src/librustc_codegen_ssa/lib.rs @@ -8,6 +8,7 @@ #![feature(trusted_len)] #![feature(associated_type_bounds)] #![recursion_limit = "256"] +#![allow(unknown_lints, confusable_idents)] //! This crate contains codegen code that is used by all codegen backends (LLVM and others). //! The backend-agnostic functions of this crate use functions defined in various traits that diff --git a/src/librustc_data_structures/lib.rs b/src/librustc_data_structures/lib.rs index bc2da535fd372..c67724afbc52d 100644 --- a/src/librustc_data_structures/lib.rs +++ b/src/librustc_data_structures/lib.rs @@ -23,6 +23,7 @@ #![feature(associated_type_bounds)] #![feature(thread_id_value)] #![allow(rustc::default_hash_types)] +#![allow(unknown_lints, confusable_idents)] #[macro_use] extern crate log; diff --git a/src/librustc_expand/lib.rs b/src/librustc_expand/lib.rs index 1e3ab2c5ec2db..57b0fedbe76b0 100644 --- a/src/librustc_expand/lib.rs +++ b/src/librustc_expand/lib.rs @@ -7,6 +7,7 @@ #![feature(proc_macro_internals)] #![feature(proc_macro_span)] #![feature(try_blocks)] +#![allow(unknown_lints, confusable_idents)] extern crate proc_macro as pm; diff --git a/src/librustc_hir/lib.rs b/src/librustc_hir/lib.rs index 49692c73fad80..8a0acfef360a4 100644 --- a/src/librustc_hir/lib.rs +++ b/src/librustc_hir/lib.rs @@ -10,6 +10,7 @@ #![feature(or_patterns)] #![feature(specialization)] #![recursion_limit = "256"] +#![allow(unknown_lints, confusable_idents)] #[macro_use] extern crate rustc_data_structures; diff --git a/src/librustc_incremental/lib.rs b/src/librustc_incremental/lib.rs index dd715c6c81d56..bf434f0f4d0cc 100644 --- a/src/librustc_incremental/lib.rs +++ b/src/librustc_incremental/lib.rs @@ -4,6 +4,7 @@ #![feature(in_band_lifetimes)] #![feature(nll)] #![recursion_limit = "256"] +#![allow(unknown_lints, confusable_idents)] #[macro_use] extern crate rustc_middle; diff --git a/src/librustc_infer/lib.rs b/src/librustc_infer/lib.rs index 28d42cea6d300..6bb2507689710 100644 --- a/src/librustc_infer/lib.rs +++ b/src/librustc_infer/lib.rs @@ -22,6 +22,7 @@ #![feature(in_band_lifetimes)] #![feature(crate_visibility_modifier)] #![recursion_limit = "512"] // For rustdoc +#![allow(unknown_lints, confusable_idents)] #[macro_use] extern crate rustc_macros; diff --git a/src/librustc_lint/non_ascii_idents.rs b/src/librustc_lint/non_ascii_idents.rs index d07b12880bd77..61d53a7eb5ae6 100644 --- a/src/librustc_lint/non_ascii_idents.rs +++ b/src/librustc_lint/non_ascii_idents.rs @@ -15,10 +15,9 @@ declare_lint! { "detects uncommon Unicode codepoints in identifiers" } -// FIXME: Change this to warn. declare_lint! { pub CONFUSABLE_IDENTS, - Allow, + Warn, "detects uncommon Unicode codepoints in identifiers" } diff --git a/src/librustc_metadata/lib.rs b/src/librustc_metadata/lib.rs index 8db107ed68aa5..94716eae5b623 100644 --- a/src/librustc_metadata/lib.rs +++ b/src/librustc_metadata/lib.rs @@ -10,6 +10,7 @@ #![feature(specialization)] #![feature(stmt_expr_attributes)] #![recursion_limit = "256"] +#![allow(unknown_lints, confusable_idents)] extern crate proc_macro; diff --git a/src/librustc_middle/lib.rs b/src/librustc_middle/lib.rs index 4ed03fd21ad18..0f06383fc54d6 100644 --- a/src/librustc_middle/lib.rs +++ b/src/librustc_middle/lib.rs @@ -52,6 +52,7 @@ #![feature(hash_raw_entry)] #![feature(int_error_matching)] #![recursion_limit = "512"] +#![allow(unknown_lints, confusable_idents)] #[macro_use] extern crate bitflags; diff --git a/src/librustc_mir/lib.rs b/src/librustc_mir/lib.rs index ae7bbe9f36a3a..e7f0b85c0bf8f 100644 --- a/src/librustc_mir/lib.rs +++ b/src/librustc_mir/lib.rs @@ -28,6 +28,7 @@ Rust MIR: a lowered representation of Rust. #![feature(option_expect_none)] #![feature(or_patterns)] #![recursion_limit = "256"] +#![allow(unknown_lints, confusable_idents)] #[macro_use] extern crate log; diff --git a/src/librustc_mir_build/lib.rs b/src/librustc_mir_build/lib.rs index c6d65d56c93f0..7d8c995f4ac4e 100644 --- a/src/librustc_mir_build/lib.rs +++ b/src/librustc_mir_build/lib.rs @@ -11,6 +11,7 @@ #![feature(bool_to_option)] #![feature(or_patterns)] #![recursion_limit = "256"] +#![allow(unknown_lints, confusable_idents)] #[macro_use] extern crate log; diff --git a/src/librustc_trait_selection/lib.rs b/src/librustc_trait_selection/lib.rs index 4796b431d8dca..3f7038143fc96 100644 --- a/src/librustc_trait_selection/lib.rs +++ b/src/librustc_trait_selection/lib.rs @@ -19,6 +19,7 @@ #![feature(str_strip)] #![feature(option_zip)] #![recursion_limit = "512"] // For rustdoc +#![allow(unknown_lints, confusable_idents)] #[macro_use] extern crate rustc_macros; diff --git a/src/librustc_typeck/lib.rs b/src/librustc_typeck/lib.rs index 8d8a1b4d96761..bb62e23cf3784 100644 --- a/src/librustc_typeck/lib.rs +++ b/src/librustc_typeck/lib.rs @@ -67,6 +67,7 @@ This API is completely unstable and subject to change. #![feature(never_type)] #![feature(slice_partition_dedup)] #![recursion_limit = "256"] +#![allow(unknown_lints, confusable_idents)] #[macro_use] extern crate log; diff --git a/src/librustdoc/lib.rs b/src/librustdoc/lib.rs index 5fb7b7bf959cf..d2bd23b256c21 100644 --- a/src/librustdoc/lib.rs +++ b/src/librustdoc/lib.rs @@ -14,6 +14,7 @@ #![feature(crate_visibility_modifier)] #![feature(never_type)] #![recursion_limit = "256"] +#![allow(unknown_lints, confusable_idents)] extern crate env_logger; extern crate rustc_ast; diff --git a/src/libserialize/lib.rs b/src/libserialize/lib.rs index c0011fddf4ff3..a07aced500f66 100644 --- a/src/libserialize/lib.rs +++ b/src/libserialize/lib.rs @@ -14,6 +14,7 @@ Core encoding and decoding interfaces. #![feature(never_type)] #![feature(nll)] #![feature(associated_type_bounds)] +#![allow(unknown_lints, confusable_idents)] #![cfg_attr(test, feature(test))] #![allow(rustc::internal)] diff --git a/src/libstd/lib.rs b/src/libstd/lib.rs index ac07af5e278fb..f2543ead2e812 100644 --- a/src/libstd/lib.rs +++ b/src/libstd/lib.rs @@ -211,6 +211,7 @@ #![warn(missing_docs)] #![warn(missing_debug_implementations)] #![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings +#![allow(unknown_lints, confusable_idents)] #![allow(explicit_outlives_requirements)] #![allow(unused_lifetimes)] // Tell the compiler to link to either panic_abort or panic_unwind diff --git a/src/test/ui/issues/issue-40003.rs b/src/test/ui/issues/issue-40003.rs index 642de6b8fe352..ccacda0712bb6 100644 --- a/src/test/ui/issues/issue-40003.rs +++ b/src/test/ui/issues/issue-40003.rs @@ -1,5 +1,6 @@ // run-pass #![allow(unused_must_use)] +#![allow(unknown_lints, confusable_idents)] fn main() { if false { test(); } }