From f4f390ff39ae5828821817dc8849a12bdfd5b8fa Mon Sep 17 00:00:00 2001 From: spalger Date: Thu, 25 Aug 2016 11:28:50 -0700 Subject: [PATCH] re-enable and autofix quotes rule --- .eslintrc | 1 - src/cli/cluster/__tests__/worker.js | 2 +- src/cli/cluster/base_path_proxy.js | 2 +- .../serve/__tests__/reload_logging_config.js | 18 +++---- src/cli_plugin/install/kibana.js | 2 +- src/cli_plugin/install/progress.js | 2 +- .../elasticsearch/lib/check_es_version.js | 2 +- .../directives/pipeline_setup.js | 2 +- .../visualize/editor/__tests__/draggable.js | 18 +++---- src/fixtures/agg_resp/range.js | 54 +++++++++---------- src/optimize/index.js | 2 +- src/optimize/lazy/lazy.js | 2 +- src/optimize/lazy/lazy_optimizer.js | 2 +- src/server/config/schema.js | 4 +- src/ui/public/agg_table/__tests__/_table.js | 2 +- .../public/chrome/__tests__/nav_controls.js | 8 +-- .../__tests__/global_nav_link.js | 12 ++--- src/ui/public/config/_delayed_updater.js | 10 ++-- src/ui/public/config/config.js | 8 +-- .../__tests__/segmented_index_selection.js | 2 +- .../public/doc_viewer/__tests__/doc_viewer.js | 2 +- .../__tests__/pattern_checker.js | 10 ++-- src/ui/settings/__tests__/index.js | 18 +++---- 23 files changed, 92 insertions(+), 93 deletions(-) diff --git a/.eslintrc b/.eslintrc index 3178da0110b06f..d54bd19499d7d7 100644 --- a/.eslintrc +++ b/.eslintrc @@ -2,4 +2,3 @@ extends: '@elastic/kibana' rules: no-unused-vars: off - quotes: off diff --git a/src/cli/cluster/__tests__/worker.js b/src/cli/cluster/__tests__/worker.js index 4d8f4f53af148f..5091c7bfa41b8d 100644 --- a/src/cli/cluster/__tests__/worker.js +++ b/src/cli/cluster/__tests__/worker.js @@ -96,7 +96,7 @@ describe('CLI cluster manager', function () { describe('#parseIncomingMessage()', function () { context('on a started worker', function () { - it(`is bound to fork's message event`, async function () { + it('is bound to fork\'s message event', async function () { const worker = setup(); await worker.start(); sinon.assert.calledWith(worker.fork.on, 'message'); diff --git a/src/cli/cluster/base_path_proxy.js b/src/cli/cluster/base_path_proxy.js index 803afeffdc36e7..eddd75d058680e 100644 --- a/src/cli/cluster/base_path_proxy.js +++ b/src/cli/cluster/base_path_proxy.js @@ -103,7 +103,7 @@ export default class BasePathProxy { server.route({ method: '*', - path: `/{oldBasePath}/{kbnPath*}`, + path: '/{oldBasePath}/{kbnPath*}', handler(req, reply) { const {oldBasePath, kbnPath = ''} = req.params; diff --git a/src/cli/serve/__tests__/reload_logging_config.js b/src/cli/serve/__tests__/reload_logging_config.js index 721ebad27b84bf..d768d1973708d6 100644 --- a/src/cli/serve/__tests__/reload_logging_config.js +++ b/src/cli/serve/__tests__/reload_logging_config.js @@ -6,8 +6,8 @@ import es from 'event-stream'; import readYamlConfig from '../read_yaml_config'; import expect from 'expect.js'; -const testConfigFile = follow(`fixtures/reload_logging_config/kibana.test.yml`); -const cli = follow(`../../../../bin/kibana`); +const testConfigFile = follow('fixtures/reload_logging_config/kibana.test.yml'); +const cli = follow('../../../../bin/kibana'); function follow(file) { return relative(process.cwd(), resolve(__dirname, file)); @@ -22,19 +22,19 @@ function setLoggingJson(enabled) { return conf; } -describe(`Server logging configuration`, function () { +describe('Server logging configuration', function () { const isWindows = /^win/.test(process.platform); if (isWindows) { it('SIGHUP is not a feature of Windows.'); } else { - it(`should be reloadable via SIGHUP process signaling`, function (done) { + it('should be reloadable via SIGHUP process signaling', function (done) { this.timeout(60000); let asserted = false; let json = Infinity; const conf = setLoggingJson(true); - const child = spawn(cli, [`--config`, testConfigFile]); + const child = spawn(cli, ['--config', testConfigFile]); child.on('error', err => { done(new Error(`error in child process while attempting to reload config. ${err.stack || err.message || err}`)); @@ -62,7 +62,7 @@ describe(`Server logging configuration`, function () { function parseJsonLogLine(line) { try { const data = JSON.parse(line); - const listening = data.tags.indexOf(`listening`) !== -1; + const listening = data.tags.indexOf('listening') !== -1; if (listening) { switchToPlainTextLog(); } @@ -74,13 +74,13 @@ describe(`Server logging configuration`, function () { function switchToPlainTextLog() { json = 3; // ignore both "reloading" messages + ui settings status message setLoggingJson(false); - child.kill(`SIGHUP`); // reload logging config + child.kill('SIGHUP'); // reload logging config } function expectPlainTextLogLine(line) { // assert - const tags = `[\u001b[32minfo\u001b[39m][\u001b[36mconfig\u001b[39m]`; - const status = `Reloaded logging configuration due to SIGHUP.`; + const tags = '[\u001b[32minfo\u001b[39m][\u001b[36mconfig\u001b[39m]'; + const status = 'Reloaded logging configuration due to SIGHUP.'; const expected = `${tags} ${status}`; const actual = line.slice(-expected.length); expect(actual).to.eql(expected); diff --git a/src/cli_plugin/install/kibana.js b/src/cli_plugin/install/kibana.js index 065808f658eaa4..750c722fa8163c 100644 --- a/src/cli_plugin/install/kibana.js +++ b/src/cli_plugin/install/kibana.js @@ -47,7 +47,7 @@ export async function rebuildCache(settings, logger) { export function assertVersion(settings) { if (!settings.plugins[0].version) { - throw new Error (`Plugin version not found. Check package.json in archive`); + throw new Error ('Plugin version not found. Check package.json in archive'); } const actual = cleanVersion(settings.plugins[0].version); diff --git a/src/cli_plugin/install/progress.js b/src/cli_plugin/install/progress.js index dca7f9a2b88fcb..f0e8424852b5e5 100644 --- a/src/cli_plugin/install/progress.js +++ b/src/cli_plugin/install/progress.js @@ -32,7 +32,7 @@ export default class Progress { } complete() { - this.logger.log(`Transfer complete`, false); + this.logger.log('Transfer complete', false); } } diff --git a/src/core_plugins/elasticsearch/lib/check_es_version.js b/src/core_plugins/elasticsearch/lib/check_es_version.js index 287132324e6a84..09167eea4acf4a 100644 --- a/src/core_plugins/elasticsearch/lib/check_es_version.js +++ b/src/core_plugins/elasticsearch/lib/check_es_version.js @@ -22,7 +22,7 @@ module.exports = function (server) { return 'Elasticsearch v' + node.version + ' @ ' + node.http_address + ' (' + node.ip + ')'; }); - const message = `This version of Kibana requires Elasticsearch ` + + const message = 'This version of Kibana requires Elasticsearch ' + `${engineVersion} on all nodes. I found ` + `the following incompatible nodes in your cluster: ${badNodeNames.join(',')}`; diff --git a/src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/directives/pipeline_setup.js b/src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/directives/pipeline_setup.js index 667849fa7aa50c..15c4e3f3276fb8 100644 --- a/src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/directives/pipeline_setup.js +++ b/src/core_plugins/kibana/public/management/sections/indices/add_data_steps/pipeline_setup/directives/pipeline_setup.js @@ -39,7 +39,7 @@ app.directive('pipelineSetup', function () { }, controller: function ($scope, debounce, Private, Notifier) { const ingest = Private(IngestProvider); - const notify = new Notifier({ location: `Ingest Pipeline Setup` }); + const notify = new Notifier({ location: 'Ingest Pipeline Setup' }); $scope.sample = {}; //determines which processors are available on the cluster diff --git a/src/core_plugins/kibana/public/visualize/editor/__tests__/draggable.js b/src/core_plugins/kibana/public/visualize/editor/__tests__/draggable.js index d8673d30a42e42..86447ff376c0d2 100644 --- a/src/core_plugins/kibana/public/visualize/editor/__tests__/draggable.js +++ b/src/core_plugins/kibana/public/visualize/editor/__tests__/draggable.js @@ -22,7 +22,7 @@ describe('draggable_* directives', function () { ]; // create the markup - const $elem = angular.element(`
`); + const $elem = angular.element('
'); $elem.html(markup); // compile the directive @@ -52,21 +52,21 @@ describe('draggable_* directives', function () { }); it('should not be able to move extraneous DOM elements', function () { - const bare = angular.element(`
`); + const bare = angular.element('
'); const { $scope } = init(); expect($scope.drake.canMove(bare[0])).to.eql(false); }); it('should not be able to move non-[draggable-item] elements', function () { - const bare = angular.element(`
`); + const bare = angular.element('
'); const { $scope, $elem } = init(); $elem.append(bare); expect($scope.drake.canMove(bare[0])).to.eql(false); }); it('shouldn\'t be able to move extraneous [draggable-item] elements', function () { - const anotherParent = angular.element(`
`); - const item = angular.element(`
`); + const anotherParent = angular.element('
'); + const item = angular.element('
'); const scope = $rootScope.$new(); anotherParent.append(item); $compile(anotherParent)(scope); @@ -82,7 +82,7 @@ describe('draggable_* directives', function () {
`); - const item = $elem.find(`[draggable-item]`); + const item = $elem.find('[draggable-item]'); expect($scope.drake.canMove(item[0])).to.eql(false); }); @@ -92,14 +92,14 @@ describe('draggable_* directives', function () {
`); - const handle = $elem.find(`[draggable-handle]`); + const handle = $elem.find('[draggable-handle]'); expect($scope.drake.canMove(handle[0])).to.eql(true); }); }); describe('draggable_item', function () { it('should be required to be a child to [draggable-container]', function () { - const item = angular.element(`
`); + const item = angular.element('
'); const scope = $rootScope.$new(); expect(() => { $compile(item)(scope); @@ -110,7 +110,7 @@ describe('draggable_* directives', function () { describe('draggable_handle', function () { it('should be required to be a child to [draggable-item]', function () { - const handle = angular.element(`
`); + const handle = angular.element('
'); const scope = $rootScope.$new(); expect(() => { $compile(handle)(scope); diff --git a/src/fixtures/agg_resp/range.js b/src/fixtures/agg_resp/range.js index f857951c270515..6e1e7bf0726f05 100644 --- a/src/fixtures/agg_resp/range.js +++ b/src/fixtures/agg_resp/range.js @@ -1,35 +1,35 @@ export default { - "took": 35, - "timed_out": false, - "_shards": { - "total": 7, - "successful": 7, - "failed": 0 + 'took': 35, + 'timed_out': false, + '_shards': { + 'total': 7, + 'successful': 7, + 'failed': 0 }, - "hits": { - "total": 218512, - "max_score": 0, - "hits": [] + 'hits': { + 'total': 218512, + 'max_score': 0, + 'hits': [] }, - "aggregations": { - "1": { - "buckets": { - "*-1024.0": { - "to": 1024, - "to_as_string": "1024.0", - "doc_count": 20904 + 'aggregations': { + '1': { + 'buckets': { + '*-1024.0': { + 'to': 1024, + 'to_as_string': '1024.0', + 'doc_count': 20904 }, - "1024.0-2560.0": { - "from": 1024, - "from_as_string": "1024.0", - "to": 2560, - "to_as_string": "2560.0", - "doc_count": 23358 + '1024.0-2560.0': { + 'from': 1024, + 'from_as_string': '1024.0', + 'to': 2560, + 'to_as_string': '2560.0', + 'doc_count': 23358 }, - "2560.0-*": { - "from": 2560, - "from_as_string": "2560.0", - "doc_count": 174250 + '2560.0-*': { + 'from': 2560, + 'from_as_string': '2560.0', + 'doc_count': 174250 } } } diff --git a/src/optimize/index.js b/src/optimize/index.js index fa0028ffe42047..14ceeb30fbcec8 100644 --- a/src/optimize/index.js +++ b/src/optimize/index.js @@ -26,7 +26,7 @@ module.exports = async (kbnServer, server, config) => { if (!invalidBundles.getIds().length) { server.log( ['debug', 'optimize'], - `All bundles are cached and ready to go!` + 'All bundles are cached and ready to go!' ); return; } diff --git a/src/optimize/lazy/lazy.js b/src/optimize/lazy/lazy.js index c370f88c16de17..d553e42ef4efa0 100644 --- a/src/optimize/lazy/lazy.js +++ b/src/optimize/lazy/lazy.js @@ -3,7 +3,7 @@ module.exports = async (kbnServer, server, config) => { if (!isWorker) { - throw new Error(`lazy optimization is only available in "watch" mode`); + throw new Error('lazy optimization is only available in "watch" mode'); } /** diff --git a/src/optimize/lazy/lazy_optimizer.js b/src/optimize/lazy/lazy_optimizer.js index 62c4e2cec0e06b..0a00a0fb0714e0 100644 --- a/src/optimize/lazy/lazy_optimizer.js +++ b/src/optimize/lazy/lazy_optimizer.js @@ -87,7 +87,7 @@ module.exports = class LazyOptimizer extends BaseOptimizer { logRunStart() { this.log(['info', 'optimize'], { - tmpl: `Lazy optimization started`, + tmpl: 'Lazy optimization started', bundles: this.bundles.getIds() }); } diff --git a/src/server/config/schema.js b/src/server/config/schema.js index 074ccec05b5792..1445d85781e65f 100644 --- a/src/server/config/schema.js +++ b/src/server/config/schema.js @@ -38,8 +38,8 @@ module.exports = () => Joi.object({ port: Joi.number().default(5601), maxPayloadBytes: Joi.number().default(1048576), autoListen: Joi.boolean().default(true), - defaultRoute: Joi.string().default('/app/kibana').regex(/^\//, `start with a slash`), - basePath: Joi.string().default('').allow('').regex(/(^$|^\/.*[^\/]$)/, `start with a slash, don't end with one`), + defaultRoute: Joi.string().default('/app/kibana').regex(/^\//, 'start with a slash'), + basePath: Joi.string().default('').allow('').regex(/(^$|^\/.*[^\/]$)/, 'start with a slash, don\'t end with one'), ssl: Joi.object({ cert: Joi.string(), key: Joi.string() diff --git a/src/ui/public/agg_table/__tests__/_table.js b/src/ui/public/agg_table/__tests__/_table.js index b6b1f5cf758216..e1800833ed4fac 100644 --- a/src/ui/public/agg_table/__tests__/_table.js +++ b/src/ui/public/agg_table/__tests__/_table.js @@ -186,7 +186,7 @@ describe('AggTable Directive', function () { it('should use the export-title attribute', function () { const expected = 'export file name'; - const $el = $compile(``)($scope); + const $el = $compile('')($scope); $scope.$digest(); const $tableScope = $el.isolateScope(); diff --git a/src/ui/public/chrome/__tests__/nav_controls.js b/src/ui/public/chrome/__tests__/nav_controls.js index 921ee5e7710f92..f8e35b4ca188de 100644 --- a/src/ui/public/chrome/__tests__/nav_controls.js +++ b/src/ui/public/chrome/__tests__/nav_controls.js @@ -32,7 +32,7 @@ describe('chrome nav controls', function () { return { name: 'control', order: 100, - template: `` + template: '' }; }); @@ -45,21 +45,21 @@ describe('chrome nav controls', function () { return { name: 'control2', order: 2, - template: `` + template: '' }; }); stubRegistry.register(function () { return { name: 'control1', order: 1, - template: `` + template: '' }; }); stubRegistry.register(function () { return { name: 'control3', order: 3, - template: `` + template: '' }; }); diff --git a/src/ui/public/chrome/directives/global_nav/global_nav_link/__tests__/global_nav_link.js b/src/ui/public/chrome/directives/global_nav/global_nav_link/__tests__/global_nav_link.js index 54254736724e4a..e9c11fd68662d9 100644 --- a/src/ui/public/chrome/directives/global_nav/global_nav_link/__tests__/global_nav_link.js +++ b/src/ui/public/chrome/directives/global_nav/global_nav_link/__tests__/global_nav_link.js @@ -43,7 +43,7 @@ describe('globalNavLink directive', () => { describe('interface', () => { describe('isActive attribute', () => { - it(`doesn't apply the active class when false`, () => { + it('doesn\'t apply the active class when false', () => { const element = create({ isActive: false, }); @@ -59,7 +59,7 @@ describe('globalNavLink directive', () => { }); describe('isDisabled attribute', () => { - it(`doesn't apply the is-global-nav-link-disabled class when false`, () => { + it('doesn\'t apply the is-global-nav-link-disabled class when false', () => { const element = create({ isDisabled: false, }); @@ -107,7 +107,7 @@ describe('globalNavLink directive', () => { }); describe('kbnRoute attribute', () => { - it(`is applied to the link when href isn't defined`, () => { + it('is applied to the link when href isn\'t defined', () => { const attrs = { kbnRoute: '#test', }; @@ -116,7 +116,7 @@ describe('globalNavLink directive', () => { expect(link.attr('href')).to.be(attrs.kbnRoute); }); - it(`isn't applied to the link when href is defined`, () => { + it('isn\'t applied to the link when href is defined', () => { const attrs = { href: 'link to a website', kbnRoute: '#test', @@ -147,7 +147,7 @@ describe('globalNavLink directive', () => { expect(placeholder.length).to.be(0); }); - it(`is set as the img src`, () => { + it('is set as the img src', () => { const attrs = { icon: 'icon url', }; @@ -176,7 +176,7 @@ describe('globalNavLink directive', () => { expect(placeholder.length).to.be(1); }); - it(`uses the title's first letter as the placeholder`, () => { + it('uses the title\'s first letter as the placeholder', () => { const attrs = { icon: undefined, title: 'Xyz', diff --git a/src/ui/public/config/_delayed_updater.js b/src/ui/public/config/_delayed_updater.js index bba170fa1804d7..01f2e00f8e1b76 100644 --- a/src/ui/public/config/_delayed_updater.js +++ b/src/ui/public/config/_delayed_updater.js @@ -27,8 +27,8 @@ export default function DelayedUpdaterFactory($http, chrome, Promise) { unsavedChanges = {}; persist(changes) - .then(result => settle(promises, `resolve`, result)) - .catch(reason => settle(promises, `reject`, reason)); + .then(result => settle(promises, 'resolve', result)) + .catch(reason => settle(promises, 'reject', reason)); } function settle(listeners, decision, data) { @@ -47,15 +47,15 @@ export default function DelayedUpdaterFactory($http, chrome, Promise) { } function remove(key) { - return sync(`delete`, { postfix: `/${key}` }); + return sync('delete', { postfix: `/${key}` }); } function edit(key, value) { - return sync(`post`, { postfix: `/${key}`, data: { value } }); + return sync('post', { postfix: `/${key}`, data: { value } }); } function editMany(changes) { - return sync(`post`, { data: { changes } }); + return sync('post', { data: { changes } }); } function sync(method, { postfix = '', data } = {}) { diff --git a/src/ui/public/config/config.js b/src/ui/public/config/config.js index 265e0b5dd6afe7..e2d5505f75195c 100644 --- a/src/ui/public/config/config.js +++ b/src/ui/public/config/config.js @@ -7,9 +7,9 @@ import ConfigDelayedUpdaterProvider from 'ui/config/_delayed_updater'; const module = uiModules.get('kibana/config'); // service for delivering config variables to everywhere else -module.service(`config`, function (Private, $rootScope, $http, chrome, uiSettings) { +module.service('config', function (Private, $rootScope, $http, chrome, uiSettings) { const config = this; - const notify = new Notifier({ location: `Config` }); + const notify = new Notifier({ location: 'Config' }); const { defaults, user: initialUserSettings } = uiSettings; const delayedUpdate = Private(ConfigDelayedUpdaterProvider); let settings = mergeSettings(defaults, initialUserSettings); @@ -55,7 +55,7 @@ any custom setting configuration watchers for "${key}" may fix this issue.`); function watchAll(scope = $rootScope, fn) { const update = (e, ...args) => fn(...args); fn(null, null, null, config); - return scope.$on(`change:config`, update); + return scope.$on('change:config', update); } function change(key, value) { @@ -99,7 +99,7 @@ any custom setting configuration watchers for "${key}" may fix this issue.`); const newVal = config.get(key); notify.log(`config change: ${key}: ${oldVal} -> ${newVal}`); $rootScope.$broadcast(`change:config.${key}`, newVal, oldVal, key, config); - $rootScope.$broadcast(`change:config`, newVal, oldVal, key, config); + $rootScope.$broadcast('change:config', newVal, oldVal, key, config); } function nullOrEmpty(value) { diff --git a/src/ui/public/courier/fetch/request/__tests__/segmented_index_selection.js b/src/ui/public/courier/fetch/request/__tests__/segmented_index_selection.js index a302da89e7bc1d..56a7a955a2b85e 100644 --- a/src/ui/public/courier/fetch/request/__tests__/segmented_index_selection.js +++ b/src/ui/public/courier/fetch/request/__tests__/segmented_index_selection.js @@ -78,7 +78,7 @@ describe('Segmented Request Index Selection', function () { }); }); - it(`sets size 0 for indices that couldn't procude hits`, async function () { + it('sets size 0 for indices that couldn\'t procude hits', async function () { const search = new MockSource(); const indexPattern = search.get('index'); diff --git a/src/ui/public/doc_viewer/__tests__/doc_viewer.js b/src/ui/public/doc_viewer/__tests__/doc_viewer.js index fcd64aab90b1cf..70a20960d3df81 100644 --- a/src/ui/public/doc_viewer/__tests__/doc_viewer.js +++ b/src/ui/public/doc_viewer/__tests__/doc_viewer.js @@ -58,7 +58,7 @@ describe('docViewer', function () { title: 'exampleView', order: 0, directive: { - template: `Example` + template: 'Example' } }); }); diff --git a/src/ui/public/pattern_checker/__tests__/pattern_checker.js b/src/ui/public/pattern_checker/__tests__/pattern_checker.js index 0432c623cb6f82..20b499ff359271 100644 --- a/src/ui/public/pattern_checker/__tests__/pattern_checker.js +++ b/src/ui/public/pattern_checker/__tests__/pattern_checker.js @@ -37,7 +37,7 @@ describe('pattern checker', function () { $httpBackend.flush(); $rootScope.$digest(); - expect(_.contains(element.html(), `1 results`)).to.be.ok(); + expect(_.contains(element.html(), '1 results')).to.be.ok(); }); it('should poll the api for changes to the document count and update the ui', function () { @@ -47,13 +47,13 @@ describe('pattern checker', function () { $httpBackend.flush(); $rootScope.$digest(); - expect(_.contains(element.html(), `1 results`)).to.be.ok(); + expect(_.contains(element.html(), '1 results')).to.be.ok(); apiResponse.respond(200, {count: 2}); $timeout.flush(); $httpBackend.flush(); $rootScope.$digest(); - expect(_.contains(element.html(), `2 results`)).to.be.ok(); + expect(_.contains(element.html(), '2 results')).to.be.ok(); }); it('should display 0 results when API responds with 404', function () { @@ -63,7 +63,7 @@ describe('pattern checker', function () { $httpBackend.flush(); $rootScope.$digest(); - expect(_.contains(element.html(), `0 results`)).to.be.ok(); + expect(_.contains(element.html(), '0 results')).to.be.ok(); }); it('should throw a fatal notificaiton for any error other than a 404', function () { @@ -85,7 +85,7 @@ describe('pattern checker', function () { $httpBackend.flush(); $rootScope.$digest(); - expect(_.contains(element.html(), `1 results`)).to.be.ok(); + expect(_.contains(element.html(), '1 results')).to.be.ok(); scope.$destroy(); $timeout.flush(); diff --git a/src/ui/settings/__tests__/index.js b/src/ui/settings/__tests__/index.js index f1a3538e1fda5f..8e09f6ae82d74a 100644 --- a/src/ui/settings/__tests__/index.js +++ b/src/ui/settings/__tests__/index.js @@ -166,14 +166,14 @@ describe('ui settings', function () { expectElasticsearchGetQuery(server, configGet); }); - it(`without user configuration it's equal to the defaults`, async function () { + it('without user configuration it\'s equal to the defaults', async function () { const getResult = {}; const { server, uiSettings, configGet } = instantiate({ getResult }); const result = await uiSettings.getRaw(); expect(isEqual(result, defaultsProvider())).to.equal(true); }); - it(`user configuration gets merged with defaults`, async function () { + it('user configuration gets merged with defaults', async function () { const getResult = { foo: 'bar' }; const { server, uiSettings, configGet } = instantiate({ getResult }); const result = await uiSettings.getRaw(); @@ -182,7 +182,7 @@ describe('ui settings', function () { expect(isEqual(result, merged)).to.equal(true); }); - it(`user configuration gets merged into defaults`, async function () { + it('user configuration gets merged into defaults', async function () { const getResult = { dateFormat: 'YYYY-MM-DD' }; const { server, uiSettings, configGet } = instantiate({ getResult }); const result = await uiSettings.getRaw(); @@ -200,7 +200,7 @@ describe('ui settings', function () { expectElasticsearchGetQuery(server, configGet); }); - it(`returns key value pairs`, async function () { + it('returns key value pairs', async function () { const getResult = {}; const { server, uiSettings, configGet } = instantiate({ getResult }); const result = await uiSettings.getAll(); @@ -212,7 +212,7 @@ describe('ui settings', function () { expect(isEqual(result, expectation)).to.equal(true); }); - it(`returns key value pairs including user configuration`, async function () { + it('returns key value pairs including user configuration', async function () { const getResult = { something: 'user-provided' }; const { server, uiSettings, configGet } = instantiate({ getResult }); const result = await uiSettings.getAll(); @@ -225,7 +225,7 @@ describe('ui settings', function () { expect(isEqual(result, expectation)).to.equal(true); }); - it(`returns key value pairs including user configuration for existing settings`, async function () { + it('returns key value pairs including user configuration for existing settings', async function () { const getResult = { dateFormat: 'YYYY-MM-DD' }; const { server, uiSettings, configGet } = instantiate({ getResult }); const result = await uiSettings.getAll(); @@ -247,7 +247,7 @@ describe('ui settings', function () { expectElasticsearchGetQuery(server, configGet); }); - it(`returns the promised value for a key`, async function () { + it('returns the promised value for a key', async function () { const getResult = {}; const { server, uiSettings, configGet } = instantiate({ getResult }); const result = await uiSettings.get('dateFormat'); @@ -255,14 +255,14 @@ describe('ui settings', function () { expect(result).to.equal(defaults.dateFormat.value); }); - it(`returns the user-configured value for a custom key`, async function () { + it('returns the user-configured value for a custom key', async function () { const getResult = { custom: 'value' }; const { server, uiSettings, configGet } = instantiate({ getResult }); const result = await uiSettings.get('custom'); expect(result).to.equal('value'); }); - it(`returns the user-configured value for a modified key`, async function () { + it('returns the user-configured value for a modified key', async function () { const getResult = { dateFormat: 'YYYY-MM-DD' }; const { server, uiSettings, configGet } = instantiate({ getResult }); const result = await uiSettings.get('dateFormat');