From 31218384e261f523141b9e31c1c6419ab9b32fb0 Mon Sep 17 00:00:00 2001 From: Jenny Bryan Date: Thu, 5 May 2022 13:45:59 -0700 Subject: [PATCH] Add a job on Windows + R 4.1 The encoding improvements in R 4.2 on Windows mean that I really need to include 4.1 to make sure I can see the problem and that I have fixed it. Also make the GHA config more obvious in other ways. --- .github/workflows/R-CMD-check.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml index 3f2f751f..f6cced49 100644 --- a/.github/workflows/R-CMD-check.yaml +++ b/.github/workflows/R-CMD-check.yaml @@ -25,6 +25,8 @@ jobs: - {os: macOS-latest, r: 'release'} - {os: windows-latest, r: 'release'} + # Use 4.1 to trigger usage of RTools40 + - {os: windows-latest, r: '4.1'} # Use 3.6 to trigger usage of RTools35 - {os: windows-latest, r: '3.6'} @@ -35,7 +37,8 @@ jobs: - {os: ubuntu-18.04, r: 'oldrel-2'} - {os: ubuntu-18.04, r: 'oldrel-3'} - {os: ubuntu-18.04, r: 'oldrel-4'} - - {os: ubuntu-18.04, r: 'release', cran: "https://demo.rstudiopm.com/all/__linux__/bionic/latest", locale: 'en_US'} + # Check with a non-UTF-8 encoding + - {os: ubuntu-18.04, r: 'release', cran: "https://demo.rstudiopm.com/all/__linux__/bionic/latest", locale: 'en_US.ISO-8859-1'} env: GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} @@ -45,7 +48,8 @@ jobs: - uses: actions/checkout@v2 - name: Set locale - if: matrix.config.locale == 'en_US' + if: matrix.config.locale == 'en_US.ISO-8859-1' + # en_US is an alias for what we want run: | sudo locale-gen en_US echo "LC_ALL=en_US" >> $GITHUB_ENV