diff --git a/CHANGELOG.md b/CHANGELOG.md index cfb55ed..bf81d3b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## Version 1.4.1 + +- Only log error documents in backfill log + ## Version 1.4.0 - Shorten function names to fix issue with local emulator diff --git a/extension.yaml b/extension.yaml index 983d3a5..4536f9c 100644 --- a/extension.yaml +++ b/extension.yaml @@ -1,5 +1,5 @@ name: firestore-typesense-search -version: 1.4.0 +version: 1.4.1 specVersion: v1beta # Firebase Extensions specification version (do not edit) displayName: Search Firestore with Typesense diff --git a/functions/src/backfill.js b/functions/src/backfill.js index 8cb4172..d90d188 100644 --- a/functions/src/backfill.js +++ b/functions/src/backfill.js @@ -59,7 +59,14 @@ module.exports = functions.firestore.document(config.typesenseBackfillTriggerDoc currentDocumentsBatch = []; functions.logger.info(`Imported ${currentDocumentNumber} documents into Typesense`); } catch (error) { - functions.logger.error("Import error", error); + if (error.importResults) { + const failedItems = error.importResults.filter( + (r) => r.success === false, + ); + functions.logger.error("Import failed with document errors", failedItems); + } else { + functions.logger.error("Import error", error); + } } } } @@ -71,7 +78,14 @@ module.exports = functions.firestore.document(config.typesenseBackfillTriggerDoc .import(currentDocumentsBatch, {action: "upsert"}); functions.logger.info(`Imported ${currentDocumentNumber} documents into Typesense`); } catch (error) { - functions.logger.error("Import error", error); + if (error.importResults) { + const failedItems = error.importResults.filter( + (r) => r.success === false, + ); + functions.logger.error("Import failed with document errors", failedItems); + } else { + functions.logger.error("Import error", error); + } } }