From 3be63d8cf04c4b39cc823c8aac31847dafdb3884 Mon Sep 17 00:00:00 2001
From: SanHalacogluImproving <san.halacoglu@improving.com>
Date: Fri, 5 Apr 2024 11:31:08 -0700
Subject: [PATCH] Minor documentation update + changed param from int to long +
 minor IT update.

---
 java/client/src/main/java/glide/api/BaseClient.java         | 4 ++--
 .../src/main/java/glide/api/commands/ListBaseCommands.java  | 4 ++--
 .../src/main/java/glide/api/models/BaseTransaction.java     | 6 +++---
 java/client/src/test/java/glide/api/RedisClientTest.java    | 4 ++--
 java/integTest/src/test/java/glide/SharedCommandTests.java  | 5 +++--
 5 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/java/client/src/main/java/glide/api/BaseClient.java b/java/client/src/main/java/glide/api/BaseClient.java
index a5ecca2150..3aa56a3f3f 100644
--- a/java/client/src/main/java/glide/api/BaseClient.java
+++ b/java/client/src/main/java/glide/api/BaseClient.java
@@ -386,9 +386,9 @@ public CompletableFuture<String[]> lrange(@NonNull String key, long start, long
     }
 
     @Override
-    public CompletableFuture<String> lindex(@NonNull String key, int index) {
+    public CompletableFuture<String> lindex(@NonNull String key, long index) {
         return commandManager.submitNewCommand(
-                Lindex, new String[] {key, Integer.toString(index)}, this::handleStringOrNullResponse);
+                Lindex, new String[] {key, Long.toString(index)}, this::handleStringOrNullResponse);
     }
 
     @Override
diff --git a/java/client/src/main/java/glide/api/commands/ListBaseCommands.java b/java/client/src/main/java/glide/api/commands/ListBaseCommands.java
index 3b13fdf622..b0e6637554 100644
--- a/java/client/src/main/java/glide/api/commands/ListBaseCommands.java
+++ b/java/client/src/main/java/glide/api/commands/ListBaseCommands.java
@@ -103,7 +103,7 @@ public interface ListBaseCommands {
     CompletableFuture<String[]> lrange(String key, long start, long end);
 
     /**
-     * Returns the element at <code>index</code> in the list stored at <code>key</code>.<br>
+     * Returns the element at <code>index</code> from the list stored at <code>key</code>.<br>
      * The index is zero-based, so <code>0</code> means the first element, <code>1</code> the second
      * element and so on. Negative indices can be used to designate elements starting at the tail of
      * the list. Here, <code>-1</code> means the last element, <code>-2</code> means the penultimate
@@ -124,7 +124,7 @@ public interface ListBaseCommands {
      * assert payload2.equals('value3'); // Returns the last element in the list stored at 'myList'.
      * }</pre>
      */
-    CompletableFuture<String> lindex(String key, int index);
+    CompletableFuture<String> lindex(String key, long index);
 
     /**
      * Trims an existing list so that it will contain only the specified range of elements specified.
diff --git a/java/client/src/main/java/glide/api/models/BaseTransaction.java b/java/client/src/main/java/glide/api/models/BaseTransaction.java
index 7fe1de46d1..d5ef43432d 100644
--- a/java/client/src/main/java/glide/api/models/BaseTransaction.java
+++ b/java/client/src/main/java/glide/api/models/BaseTransaction.java
@@ -570,7 +570,7 @@ public T lrange(@NonNull String key, long start, long end) {
     }
 
     /**
-     * Returns the element at <code>index</code> in the list stored at <code>key</code>.<br>
+     * Returns the element at <code>index</code> from the list stored at <code>key</code>.<br>
      * The index is zero-based, so <code>0</code> means the first element, <code>1</code> the second
      * element and so on. Negative indices can be used to designate elements starting at the tail of
      * the list. Here, <code>-1</code> means the last element, <code>-2</code> means the penultimate
@@ -584,8 +584,8 @@ public T lrange(@NonNull String key, long start, long end) {
      *     If <code>index</code> is out of range or if <code>key</code> does not exist, <code>null
      *     </code> is returned.
      */
-    public T lindex(@NonNull String key, int index) {
-        ArgsArray commandArgs = buildArgs(key, Integer.toString(index));
+    public T lindex(@NonNull String key, long index) {
+        ArgsArray commandArgs = buildArgs(key, Long.toString(index));
 
         protobufTransaction.addCommands(buildCommand(Lindex, commandArgs));
         return getThis();
diff --git a/java/client/src/test/java/glide/api/RedisClientTest.java b/java/client/src/test/java/glide/api/RedisClientTest.java
index d90aa80e71..9bdf3a5116 100644
--- a/java/client/src/test/java/glide/api/RedisClientTest.java
+++ b/java/client/src/test/java/glide/api/RedisClientTest.java
@@ -1089,8 +1089,8 @@ public void lrange_returns_success() {
     public void lindex_returns_success() {
         // setup
         String key = "testKey";
-        int index = 2;
-        String[] args = new String[] {key, Integer.toString(index)};
+        long index = 2;
+        String[] args = new String[] {key, Long.toString(index)};
         String value = "value";
 
         CompletableFuture<String> testResponse = new CompletableFuture<>();
diff --git a/java/integTest/src/test/java/glide/SharedCommandTests.java b/java/integTest/src/test/java/glide/SharedCommandTests.java
index 7749aeb93d..fb53b740e0 100644
--- a/java/integTest/src/test/java/glide/SharedCommandTests.java
+++ b/java/integTest/src/test/java/glide/SharedCommandTests.java
@@ -593,10 +593,11 @@ public void lindex(BaseClient client) {
 
         assertEquals(2, client.lpush(key1, valueArray).get());
         assertEquals(valueArray[1], client.lindex(key1, 0).get());
-        assertEquals(valueArray[0], client.lindex(key1, 1).get());
+        assertEquals(valueArray[0], client.lindex(key1, -1).get());
         assertNull(client.lindex(key1, 3).get());
-        assertNull(client.lindex("nonExistingKey", 3).get());
+        assertNull(client.lindex(key2, 3).get());
 
+        // Key exists, but it is not a List
         assertEquals(OK, client.set(key2, "value").get());
         Exception executionException =
                 assertThrows(ExecutionException.class, () -> client.lindex(key2, 0).get());