From d4b0df1752e2ef46da9e53bfc02d7049db1b4ee5 Mon Sep 17 00:00:00 2001 From: Dmitrii Ustiugov Date: Tue, 11 May 2021 12:54:21 +0100 Subject: [PATCH 1/3] replaced the go-linter action with the official one Signed-off-by: Dmitrii Ustiugov --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4c9a893ef..c62206e58 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -22,7 +22,7 @@ jobs: build: strategy: matrix: - go: ['1.13', '1.14', '1.15'] + go: ['1.13', '1.14', '1.15', '1.16'] # Build all variants regardless of failures fail-fast: false @@ -42,7 +42,7 @@ jobs: fetch-depth: 21 - name: Check code - uses: Jerome1337/golint-action@v1.0.2 + uses: golangci/golangci-lint-action@v2 - name: Get dependencies run: | From 6ccc9e9c006da7ee287457043d4f0937d52a6d18 Mon Sep 17 00:00:00 2001 From: Dmitrii Ustiugov Date: Tue, 11 May 2021 12:55:52 +0100 Subject: [PATCH 2/3] Documentation update (minor) * Corrected the guide for using the kind container for development * Added YouTube links to the README Signed-off-by: Dmitrii Ustiugov --- .github/workflows/build.yml | 2 ++ README.md | 2 ++ docs/developers_guide.md | 5 ++--- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c62206e58..494dac54f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -43,6 +43,8 @@ jobs: - name: Check code uses: golangci/golangci-lint-action@v2 + with: + args: --timeout 5m - name: Get dependencies run: | diff --git a/README.md b/README.md index e93d53f68..3d2e46f40 100644 --- a/README.md +++ b/README.md @@ -38,6 +38,8 @@ The details of the vHive architecture can be found in our ASPLOS'21 paper * [Slides](docs/talks/vHive_REAP_@AWS_04_02_2021.pdf) from [Dmitrii](http://homepages.inf.ed.ac.uk/s1373190/)'s talk at AWS on Feb, 4th 2021. +* ASPLOS'21 talks on YouTube: +[short](https://www.youtube.com/watch?v=w1vGb0X0SUQ), [long](https://www.youtube.com/watch?v=zfLd_MTGOA8). ## Referencing our work diff --git a/docs/developers_guide.md b/docs/developers_guide.md index 5e0dcceeb..6ba381408 100644 --- a/docs/developers_guide.md +++ b/docs/developers_guide.md @@ -6,9 +6,8 @@ You can use the image to build/test/develop vHive inside a container. This image is preconfigured to run a single node Kubernetes cluster inside a container and contains packages to setup vHive on top of it. ```bash -git clone -b custom_docker_params_for_vHive https://github.com/ease-lab/kind -# build kind -cd kind && go build +# Set up the host (the same script as for the self-hosted GitHub CI runner) +./scripts/github_runner/setup_runner_host.sh # pull latest image docker pull vhiveease/vhive_dev_env # Start a container From b1301988f3338427745b81e0a6ee3e94f49ccc02 Mon Sep 17 00:00:00 2001 From: Dmitrii Ustiugov Date: Tue, 11 May 2021 13:25:29 +0100 Subject: [PATCH 3/3] removed the crontab setup Signed-off-by: Dmitrii Ustiugov --- scripts/github_runner/setup_runner_host.sh | 9 --------- 1 file changed, 9 deletions(-) diff --git a/scripts/github_runner/setup_runner_host.sh b/scripts/github_runner/setup_runner_host.sh index cc58aa6e5..267b5778d 100755 --- a/scripts/github_runner/setup_runner_host.sh +++ b/scripts/github_runner/setup_runner_host.sh @@ -58,12 +58,3 @@ newgrp docker # Allow profiling using Perf / PMU tools sudo sysctl -w kernel.perf_event_paranoid=-1 - -#setup crontab for nightly reboots -TMPFILE=$(mktemp) -#write out current crontab -sudo crontab -l > $TMPFILE -#echo new cron into cron file -sudo echo "00 02 * * * shutdown -r 0" >> $TMPFILE -#install new cron file -sudo crontab $TMPFILE